From: tip-bot for Shaokun Zhang <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: imammedo@redhat.com, tglx@linutronix.de, puwen@hygon.cn,
x86@kernel.org, suravee.suthikulpanit@amd.com, bp@suse.de,
mingo@redhat.com, zhenzhong.duan@oracle.com, mingo@kernel.org,
yazen.ghannam@amd.com, linux-kernel@vger.kernel.org,
zhangshaokun@hisilicon.com, konrad.wilk@oracle.com,
rppt@linux.vnet.ibm.com, hpa@zytor.com,
alison.schofield@intel.com
Subject: [tip:x86/cleanups] x86/smpboot: Remove unused phys_id variable
Date: Mon, 18 Feb 2019 08:34:12 -0800 [thread overview]
Message-ID: <tip-f91fecc09e498529230b4d5053cb361619a0c42d@git.kernel.org> (raw)
In-Reply-To: <1550495101-41755-1-git-send-email-zhangshaokun@hisilicon.com>
Commit-ID: f91fecc09e498529230b4d5053cb361619a0c42d
Gitweb: https://git.kernel.org/tip/f91fecc09e498529230b4d5053cb361619a0c42d
Author: Shaokun Zhang <zhangshaokun@hisilicon.com>
AuthorDate: Mon, 18 Feb 2019 21:05:01 +0800
Committer: Borislav Petkov <bp@suse.de>
CommitDate: Mon, 18 Feb 2019 17:09:24 +0100
x86/smpboot: Remove unused phys_id variable
The 'phys_id' local variable became unused after commit
ce4b1b16502b ("x86/smpboot: Initialize secondary CPU only if master CPU will wait for it").
Remove it.
Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: Alison Schofield <alison.schofield@intel.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Igor Mammedov <imammedo@redhat.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Mike Rapoport <rppt@linux.vnet.ibm.com>
Cc: Pu Wen <puwen@hygon.cn>
Cc: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: x86-ml <x86@kernel.org>
Cc: Yazen Ghannam <yazen.ghannam@amd.com>
Cc: Zhenzhong Duan <zhenzhong.duan@oracle.com>
Link: https://lkml.kernel.org/r/1550495101-41755-1-git-send-email-zhangshaokun@hisilicon.com
---
arch/x86/kernel/smpboot.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
index ccd1f2a8e557..5d5421b48e55 100644
--- a/arch/x86/kernel/smpboot.c
+++ b/arch/x86/kernel/smpboot.c
@@ -149,7 +149,7 @@ static inline void smpboot_restore_warm_reset_vector(void)
*/
static void smp_callin(void)
{
- int cpuid, phys_id;
+ int cpuid;
/*
* If waken up by an INIT in an 82489DX configuration
@@ -159,11 +159,6 @@ static void smp_callin(void)
*/
cpuid = smp_processor_id();
- /*
- * (This works even if the APIC is not enabled.)
- */
- phys_id = read_apic_id();
-
/*
* the boot CPU has finished the init stage and is spinning
* on callin_map until we finish. We are free to set up this
prev parent reply other threads:[~2019-02-18 16:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-18 13:05 [PATCH] x86/smpboot: Remove unused phys_id variable Shaokun Zhang
2019-02-18 16:34 ` tip-bot for Shaokun Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-f91fecc09e498529230b4d5053cb361619a0c42d@git.kernel.org \
--to=tipbot@zytor.com \
--cc=alison.schofield@intel.com \
--cc=bp@suse.de \
--cc=hpa@zytor.com \
--cc=imammedo@redhat.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=puwen@hygon.cn \
--cc=rppt@linux.vnet.ibm.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yazen.ghannam@amd.com \
--cc=zhangshaokun@hisilicon.com \
--cc=zhenzhong.duan@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).