From: Hou Tao <houtao1@huawei.com>
To: <linux-mtd@lists.infradead.org>
Cc: David Woodhouse <dwmw2@infradead.org>,
Richard Weinberger <richard@nod.at>,
<linux-kernel@vger.kernel.org>, <houtao1@huawei.com>
Subject: [PATCH 1/2] jffs2: reset pino_nlink to 0 when inode creation failed
Date: Wed, 20 Feb 2019 18:21:32 +0800 [thread overview]
Message-ID: <20190220102133.7878-2-houtao1@huawei.com> (raw)
In-Reply-To: <20190220102133.7878-1-houtao1@huawei.com>
So jffs2_do_clear_inode() could mark all flash nodes used by
the inode as obsolete and GC procedure will reclaim these
flash nodes, else these flash spaces will not be reclaimable
forever.
Cc: stable@vger.kernel.org
Signed-off-by: Hou Tao <houtao1@huawei.com>
---
fs/jffs2/dir.c | 28 ++++++++++++++++++++++++----
1 file changed, 24 insertions(+), 4 deletions(-)
diff --git a/fs/jffs2/dir.c b/fs/jffs2/dir.c
index f20cff1194bb..e02f85e516cb 100644
--- a/fs/jffs2/dir.c
+++ b/fs/jffs2/dir.c
@@ -156,6 +156,26 @@ static int jffs2_readdir(struct file *file, struct dir_context *ctx)
/***********************************************************************/
+static void jffs2_iget_failed(struct jffs2_sb_info *c, struct inode *inode)
+{
+ struct jffs2_inode_info *f = JFFS2_INODE_INFO(inode);
+
+ /*
+ * Reset pino_nlink to zero, so jffs2_do_clear_inode() will mark
+ * all flash nodes used by the inode as obsolete and GC procedure
+ * will reclaim these flash nodes, else these flash spaces will be
+ * unreclaimable forever.
+ *
+ * Update pino_nlink under inocache_lock, because no proceses could
+ * get the inode due to I_NEW flag, and only GC procedure may try to
+ * read pino_nlink under inocache_lock.
+ */
+ spin_lock(&c->inocache_lock);
+ f->inocache->pino_nlink = 0;
+ spin_unlock(&c->inocache_lock);
+
+ iget_failed(inode);
+}
static int jffs2_create(struct inode *dir_i, struct dentry *dentry,
umode_t mode, bool excl)
@@ -213,7 +233,7 @@ static int jffs2_create(struct inode *dir_i, struct dentry *dentry,
return 0;
fail:
- iget_failed(inode);
+ jffs2_iget_failed(c, inode);
jffs2_free_raw_inode(ri);
return ret;
}
@@ -433,7 +453,7 @@ static int jffs2_symlink (struct inode *dir_i, struct dentry *dentry, const char
return 0;
fail:
- iget_failed(inode);
+ jffs2_iget_failed(c, inode);
return ret;
}
@@ -577,7 +597,7 @@ static int jffs2_mkdir (struct inode *dir_i, struct dentry *dentry, umode_t mode
return 0;
fail:
- iget_failed(inode);
+ jffs2_iget_failed(c, inode);
return ret;
}
@@ -748,7 +768,7 @@ static int jffs2_mknod (struct inode *dir_i, struct dentry *dentry, umode_t mode
return 0;
fail:
- iget_failed(inode);
+ jffs2_iget_failed(c, inode);
return ret;
}
--
2.16.2.dirty
next prev parent reply other threads:[~2019-02-20 10:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-20 10:21 [PATCH 0/2] jffs2: fixes for file creation failed halfway Hou Tao
2019-02-20 10:21 ` Hou Tao [this message]
2019-02-20 10:21 ` [PATCH 2/2] jffs2: handle INO_STATE_CLEARING in jffs2_do_read_inode() Hou Tao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190220102133.7878-2-houtao1@huawei.com \
--to=houtao1@huawei.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).