perf/x86/intel: fix handling of wakeup_events for multi-entry PEBS
diff mbox series

Message ID 20190306195048.189514-1-eranian@google.com
State Accepted
Commit 583feb08e7f7ac9d533b446882eb3a54737a6dbb
Headers show
Series
  • perf/x86/intel: fix handling of wakeup_events for multi-entry PEBS
Related show

Commit Message

Stephane Eranian March 6, 2019, 7:50 p.m. UTC
When an event is programmed with attr.wakeup_events=N (N>0), it means
the caller is interested in getting a user level notification after
N samples have been recorded in the kernel sampling buffer.

With precise events on Intel processors, the kernel uses PEBS.
The kernel tries minimize sampling overhead by verifying
if the event configuration is compatible with multi-entry PEBS mode.
If so, the kernel is notified only when the buffer has reached its threshold.
Other PEBS operates in single-entry mode, the kenrel is notified for each
PEBS sample.

The problem is that the current implementation look at frequency
mode and event sample_type but ignores the wakeup_events field. Thus,
it may not be possible to receive a notification after each precise event.

This patch fixes this problem by disabling multi-entry PEBS if wakeup_events
is non-zero.

Signed-off-by: Stephane Eranian <eranian@google.com>
---
 arch/x86/events/intel/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andi Kleen March 6, 2019, 9:05 p.m. UTC | #1
> This patch fixes this problem by disabling multi-entry PEBS if wakeup_events
> is non-zero.
> 
> Signed-off-by: Stephane Eranian <eranian@google.com>

Looks good

Reviewed-by: Andi Kleen <ak@linux.intel.com>

-Andi

Patch
diff mbox series

diff --git a/arch/x86/events/intel/core.c b/arch/x86/events/intel/core.c
index 7ec265b..13d7167 100644
--- a/arch/x86/events/intel/core.c
+++ b/arch/x86/events/intel/core.c
@@ -3143,7 +3143,7 @@  static int intel_pmu_hw_config(struct perf_event *event)
 		return ret;
 
 	if (event->attr.precise_ip) {
-		if (!event->attr.freq) {
+		if (!(event->attr.freq || event->attr.wakeup_events)) {
 			event->hw.flags |= PERF_X86_EVENT_AUTO_RELOAD;
 			if (!(event->attr.sample_type &
 			      ~intel_pmu_large_pebs_flags(event)))