From: Andi Kleen <andi@firstfloor.org>
To: acme@kernel.org
Cc: jolsa@kernel.org, linux-perf-users@vger.kernel.org,
linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>
Subject: [PATCH v5 03/15] perf tools script: Filter COMM/FORK/.. events by CPU
Date: Fri, 8 Mar 2019 21:56:16 -0800 [thread overview]
Message-ID: <20190309055628.21617-4-andi@firstfloor.org> (raw)
In-Reply-To: <20190309055628.21617-1-andi@firstfloor.org>
From: Andi Kleen <ak@linux.intel.com>
The --cpu option only filtered samples. Filter other perf events,
such as COMM, FORK, SWITCH by the CPU too.
Reported-by: Jiri Olsa <jolsa@kernel.org>
Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
v2: Only filter printf output
---
tools/perf/builtin-script.c | 62 +++++++++++++++++++++++--------------
1 file changed, 39 insertions(+), 23 deletions(-)
diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
index fbc440bdf880..f6b5b19b3307 100644
--- a/tools/perf/builtin-script.c
+++ b/tools/perf/builtin-script.c
@@ -2053,9 +2053,11 @@ static int process_comm_event(struct perf_tool *tool,
sample->tid = event->comm.tid;
sample->pid = event->comm.pid;
}
- perf_sample__fprintf_start(sample, thread, evsel,
+ if (!cpu_list || test_bit(sample->cpu, cpu_bitmap)) {
+ perf_sample__fprintf_start(sample, thread, evsel,
PERF_RECORD_COMM, stdout);
- perf_event__fprintf(event, stdout);
+ perf_event__fprintf(event, stdout);
+ }
ret = 0;
out:
thread__put(thread);
@@ -2089,9 +2091,11 @@ static int process_namespaces_event(struct perf_tool *tool,
sample->tid = event->namespaces.tid;
sample->pid = event->namespaces.pid;
}
- perf_sample__fprintf_start(sample, thread, evsel,
- PERF_RECORD_NAMESPACES, stdout);
- perf_event__fprintf(event, stdout);
+ if (!cpu_list || test_bit(sample->cpu, cpu_bitmap)) {
+ perf_sample__fprintf_start(sample, thread, evsel,
+ PERF_RECORD_NAMESPACES, stdout);
+ perf_event__fprintf(event, stdout);
+ }
ret = 0;
out:
thread__put(thread);
@@ -2123,9 +2127,11 @@ static int process_fork_event(struct perf_tool *tool,
sample->tid = event->fork.tid;
sample->pid = event->fork.pid;
}
- perf_sample__fprintf_start(sample, thread, evsel,
- PERF_RECORD_FORK, stdout);
- perf_event__fprintf(event, stdout);
+ if (!cpu_list || test_bit(sample->cpu, cpu_bitmap)) {
+ perf_sample__fprintf_start(sample, thread, evsel,
+ PERF_RECORD_FORK, stdout);
+ perf_event__fprintf(event, stdout);
+ }
thread__put(thread);
return 0;
@@ -2153,9 +2159,11 @@ static int process_exit_event(struct perf_tool *tool,
sample->tid = event->fork.tid;
sample->pid = event->fork.pid;
}
- perf_sample__fprintf_start(sample, thread, evsel,
- PERF_RECORD_EXIT, stdout);
- perf_event__fprintf(event, stdout);
+ if (!cpu_list || test_bit(sample->cpu, cpu_bitmap)) {
+ perf_sample__fprintf_start(sample, thread, evsel,
+ PERF_RECORD_EXIT, stdout);
+ perf_event__fprintf(event, stdout);
+ }
if (perf_event__process_exit(tool, event, sample, machine) < 0)
err = -1;
@@ -2189,9 +2197,11 @@ static int process_mmap_event(struct perf_tool *tool,
sample->tid = event->mmap.tid;
sample->pid = event->mmap.pid;
}
- perf_sample__fprintf_start(sample, thread, evsel,
- PERF_RECORD_MMAP, stdout);
- perf_event__fprintf(event, stdout);
+ if (!cpu_list || test_bit(sample->cpu, cpu_bitmap)) {
+ perf_sample__fprintf_start(sample, thread, evsel,
+ PERF_RECORD_MMAP, stdout);
+ perf_event__fprintf(event, stdout);
+ }
thread__put(thread);
return 0;
}
@@ -2221,9 +2231,11 @@ static int process_mmap2_event(struct perf_tool *tool,
sample->tid = event->mmap2.tid;
sample->pid = event->mmap2.pid;
}
- perf_sample__fprintf_start(sample, thread, evsel,
- PERF_RECORD_MMAP2, stdout);
- perf_event__fprintf(event, stdout);
+ if (!cpu_list || test_bit(sample->cpu, cpu_bitmap)) {
+ perf_sample__fprintf_start(sample, thread, evsel,
+ PERF_RECORD_MMAP2, stdout);
+ perf_event__fprintf(event, stdout);
+ }
thread__put(thread);
return 0;
}
@@ -2248,9 +2260,11 @@ static int process_switch_event(struct perf_tool *tool,
return -1;
}
- perf_sample__fprintf_start(sample, thread, evsel,
- PERF_RECORD_SWITCH, stdout);
- perf_event__fprintf(event, stdout);
+ if (!cpu_list || test_bit(sample->cpu, cpu_bitmap)) {
+ perf_sample__fprintf_start(sample, thread, evsel,
+ PERF_RECORD_SWITCH, stdout);
+ perf_event__fprintf(event, stdout);
+ }
thread__put(thread);
return 0;
}
@@ -2271,9 +2285,11 @@ process_lost_event(struct perf_tool *tool,
if (thread == NULL)
return -1;
- perf_sample__fprintf_start(sample, thread, evsel,
- PERF_RECORD_LOST, stdout);
- perf_event__fprintf(event, stdout);
+ if (!cpu_list || test_bit(sample->cpu, cpu_bitmap)) {
+ perf_sample__fprintf_start(sample, thread, evsel,
+ PERF_RECORD_LOST, stdout);
+ perf_event__fprintf(event, stdout);
+ }
thread__put(thread);
return 0;
}
--
2.20.1
next prev parent reply other threads:[~2019-03-09 5:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-09 5:56 Support sample context in perf report Andi Kleen
2019-03-09 5:56 ` [PATCH v5 01/15] perf tools: Add utility function to fetch executable Andi Kleen
2019-03-11 12:32 ` Jiri Olsa
2019-03-09 5:56 ` [PATCH v5 02/15] perf tools script: Support insn output for normal samples Andi Kleen
2019-03-09 5:56 ` Andi Kleen [this message]
2019-03-11 12:32 ` [PATCH v5 03/15] perf tools script: Filter COMM/FORK/.. events by CPU Jiri Olsa
2019-03-09 5:56 ` [PATCH v5 04/15] perf tools report: Support nano seconds Andi Kleen
2019-03-09 5:56 ` [PATCH v5 05/15] perf tools report: Parse time quantum Andi Kleen
2019-03-09 5:56 ` [PATCH v5 06/15] perf tools report: Support time sort key Andi Kleen
2019-03-09 5:56 ` [PATCH v5 07/15] perf tools report: Use less for scripts output Andi Kleen
2019-03-22 22:07 ` [tip:perf/urgent] perf " tip-bot for Andi Kleen
2019-03-09 5:56 ` [PATCH v5 08/15] perf tools report: Support running scripts for current time range Andi Kleen
2019-03-09 5:56 ` [PATCH v5 09/15] perf tools report: Support builtin perf script in scripts menu Andi Kleen
2019-03-09 5:56 ` [PATCH v5 10/15] perf tools: Add utility function to print ns time stamps Andi Kleen
2019-03-09 5:56 ` [PATCH v5 11/15] perf tools report: Implement browsing of individual samples Andi Kleen
2019-03-11 12:32 ` Jiri Olsa
2019-03-09 5:56 ` [PATCH v5 12/15] perf tools: Add some new tips describing the new options Andi Kleen
2019-03-09 5:56 ` [PATCH v5 13/15] perf tools report: Add custom scripts to script menu Andi Kleen
2019-03-09 5:56 ` [PATCH v5 14/15] perf tools script: Add array bound checking to list_scripts Andi Kleen
2019-03-09 5:56 ` [PATCH v5 15/15] perf tools ui: Fix ui popup browser for many entries Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190309055628.21617-4-andi@firstfloor.org \
--to=andi@firstfloor.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).