From: Matthias Kaehlcke <mka@chromium.org>
To: Andy Lutomirski <luto@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H . Peter Anvin" <hpa@zytor.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
Nick Desaulniers <ndesaulniers@google.com>,
Manoj Gupta <manojgupta@chromium.org>,
Tiancong Wang <tcwang@chromium.org>,
Stephen Hines <srhines@google.com>,
clang-built-linux@googlegroups.com,
Matthias Kaehlcke <mka@chromium.org>
Subject: [PATCH] x86/vdso: include generic __lshrdi3 in 32-bit vDSO
Date: Fri, 15 Mar 2019 12:54:13 -0700 [thread overview]
Message-ID: <CAG5bF+SSMTvkgnQwHC1gx0pzysXhmMJ_+hUci_SJDPSteL4BcQ@mail.gmail.com> (raw)
Building the 32-bit vDSO with a recent clang version fails due
to undefined symbols:
arch/x86/entry/vdso/vdso32.so.dbg: undefined symbols found
The undefined symbol in this case is __lshrdi3, which is part of
the compiler runtime library, however the vDSO isn't linked against
this library.
Include the kernel version of __lshrdi3 in the 32-bit vDSO build.
Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
---
arch/x86/entry/vdso/Makefile | 7 ++++++-
lib/lshrdi3.c | 4 +++-
2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/arch/x86/entry/vdso/Makefile b/arch/x86/entry/vdso/Makefile
index 5bfe2243a08f..7517cd87e10b 100644
--- a/arch/x86/entry/vdso/Makefile
+++ b/arch/x86/entry/vdso/Makefile
@@ -144,6 +144,7 @@ KBUILD_CFLAGS_32 += $(call cc-option, -fno-stack-protector)
KBUILD_CFLAGS_32 += $(call cc-option, -foptimize-sibling-calls)
KBUILD_CFLAGS_32 += -fno-omit-frame-pointer
KBUILD_CFLAGS_32 += -DDISABLE_BRANCH_PROFILING
+KBUILD_CFLAGS_32 += -DBUILD_VDSO
ifdef CONFIG_RETPOLINE
ifneq ($(RETPOLINE_VDSO_CFLAGS),)
@@ -153,12 +154,16 @@ endif
$(obj)/vdso32.so.dbg: KBUILD_CFLAGS = $(KBUILD_CFLAGS_32)
+$(obj)/vdso32/lshrdi3.o: $(srctree)/lib/lshrdi3.c FORCE
+ $(call if_changed_rule,cc_o_c)
+
$(obj)/vdso32.so.dbg: FORCE \
$(obj)/vdso32/vdso32.lds \
$(obj)/vdso32/vclock_gettime.o \
$(obj)/vdso32/note.o \
$(obj)/vdso32/system_call.o \
- $(obj)/vdso32/sigreturn.o
+ $(obj)/vdso32/sigreturn.o \
+ $(obj)/vdso32/lshrdi3.o
$(call if_changed,vdso)
#
diff --git a/lib/lshrdi3.c b/lib/lshrdi3.c
index 99cfa5721f2d..8a4fc6bcf3a4 100644
--- a/lib/lshrdi3.c
+++ b/lib/lshrdi3.c
@@ -16,7 +16,7 @@
* to the Free Software Foundation, Inc.
*/
-#include <linux/module.h>
+#include <linux/export.h>
#include <linux/libgcc.h>
long long notrace __lshrdi3(long long u, word_type b)
@@ -42,4 +42,6 @@ long long notrace __lshrdi3(long long u, word_type b)
return w.ll;
}
+#ifndef BUILD_VDSO
EXPORT_SYMBOL(__lshrdi3);
+#endif
--
2.21.0.360.g471c308f928-goog
next reply other threads:[~2019-03-15 19:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-15 19:54 Matthias Kaehlcke [this message]
2019-03-15 21:31 ` [PATCH] x86/vdso: include generic __lshrdi3 in 32-bit vDSO Nick Desaulniers
2019-03-15 22:29 ` Matthias Kaehlcke
2019-03-15 23:18 ` hpa
2019-03-18 8:59 ` Peter Zijlstra
2019-03-18 17:09 ` Nick Desaulniers
2019-03-18 17:16 ` Peter Zijlstra
2019-03-18 20:44 ` Matthias Kaehlcke
2019-03-18 23:03 ` Peter Zijlstra
2019-03-20 14:06 ` Masahiro Yamada
2019-03-20 13:55 ` Masahiro Yamada
2019-03-20 15:45 ` Matthias Kaehlcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAG5bF+SSMTvkgnQwHC1gx0pzysXhmMJ_+hUci_SJDPSteL4BcQ@mail.gmail.com \
--to=mka@chromium.org \
--cc=bp@alien8.de \
--cc=clang-built-linux@googlegroups.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=manojgupta@chromium.org \
--cc=mingo@redhat.com \
--cc=ndesaulniers@google.com \
--cc=srhines@google.com \
--cc=tcwang@chromium.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).