From: Souptick Joarder <jrdr.linux@gmail.com> To: akpm@linux-foundation.org, willy@infradead.org, mhocko@suse.com, stefanr@s5r6.in-berlin.de, linux@armlinux.org.uk, robin.murphy@arm.com Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux1394-devel@lists.sourceforge.net Subject: [RESEND PATCH v4 3/9] drivers/firewire/core-iso.c: Convert to use vm_map_pages_zero() Date: Tue, 19 Mar 2019 07:55:27 +0530 [thread overview] Message-ID: <88645f5ea8202784a8baaf389e592aeb8c505e8e.1552921225.git.jrdr.linux@gmail.com> (raw) In-Reply-To: <cover.1552921225.git.jrdr.linux@gmail.com> Convert to use vm_map_pages_zero() to map range of kernel memory to user vma. This driver has ignored vm_pgoff and mapped the entire pages. We could later "fix" these drivers to behave according to the normal vm_pgoff offsetting simply by removing the _zero suffix on the function name and if that causes regressions, it gives us an easy way to revert. Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com> --- drivers/firewire/core-iso.c | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/firewire/core-iso.c b/drivers/firewire/core-iso.c index 35e784c..5414eb1 100644 --- a/drivers/firewire/core-iso.c +++ b/drivers/firewire/core-iso.c @@ -107,19 +107,8 @@ int fw_iso_buffer_init(struct fw_iso_buffer *buffer, struct fw_card *card, int fw_iso_buffer_map_vma(struct fw_iso_buffer *buffer, struct vm_area_struct *vma) { - unsigned long uaddr; - int i, err; - - uaddr = vma->vm_start; - for (i = 0; i < buffer->page_count; i++) { - err = vm_insert_page(vma, uaddr, buffer->pages[i]); - if (err) - return err; - - uaddr += PAGE_SIZE; - } - - return 0; + return vm_map_pages_zero(vma, buffer->pages, + buffer->page_count); } void fw_iso_buffer_destroy(struct fw_iso_buffer *buffer, -- 1.9.1
WARNING: multiple messages have this Message-ID (diff)
From: Souptick Joarder <jrdr.linux@gmail.com> To: akpm@linux-foundation.org, willy@infradead.org, mhocko@suse.com, kirill.shutemov@linux.intel.com, vbabka@suse.cz, riel@surriel.com, sfr@canb.auug.org.au, rppt@linux.vnet.ibm.com, peterz@infradead.org, linux@armlinux.org.uk, robin.murphy@arm.com, iamjoonsoo.kim@lge.com, treding@nvidia.com, keescook@chromium.org, m.szyprowski@samsung.com, stefanr@s5r6.in-berlin.de, hjc@rock-chips.com, heiko@sntech.de, airlied@linux.ie, oleksandr_andrushchenko@epam.com, joro@8bytes.org, pawel@osciak.com, kyungmin.park@samsung.com, mchehab@kernel.org, boris.ostrovsky@oracle.com, jgross@suse.com Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux1394-devel@lists.sourceforge.net, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, xen-devel@lists.xen.org, iommu@lists.linux-foundation.org, linux-media@vger.kernel.org, Souptick Joarder <jrdr.linux@gmail.com> Subject: [REBASE PATCH v5 3/9] drivers/firewire/core-iso.c: Convert to use vm_map_pages_zero() Date: Tue, 16 Apr 2019 17:19:44 +0530 [thread overview] Message-ID: <88645f5ea8202784a8baaf389e592aeb8c505e8e.1552921225.git.jrdr.linux@gmail.com> (raw) Message-ID: <20190416114944.T-xqlQGxfLfUBgpsyFH2RrzMnRNBUr9-I5c9dm6R-ME@z> (raw) In-Reply-To: <cover.1552921225.git.jrdr.linux@gmail.com> In-Reply-To: <cover.1552921225.git.jrdr.linux@gmail.com> Convert to use vm_map_pages_zero() to map range of kernel memory to user vma. This driver has ignored vm_pgoff and mapped the entire pages. We could later "fix" these drivers to behave according to the normal vm_pgoff offsetting simply by removing the _zero suffix on the function name and if that causes regressions, it gives us an easy way to revert. Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com> --- drivers/firewire/core-iso.c | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/firewire/core-iso.c b/drivers/firewire/core-iso.c index 35e784c..5414eb1 100644 --- a/drivers/firewire/core-iso.c +++ b/drivers/firewire/core-iso.c @@ -107,19 +107,8 @@ int fw_iso_buffer_init(struct fw_iso_buffer *buffer, struct fw_card *card, int fw_iso_buffer_map_vma(struct fw_iso_buffer *buffer, struct vm_area_struct *vma) { - unsigned long uaddr; - int i, err; - - uaddr = vma->vm_start; - for (i = 0; i < buffer->page_count; i++) { - err = vm_insert_page(vma, uaddr, buffer->pages[i]); - if (err) - return err; - - uaddr += PAGE_SIZE; - } - - return 0; + return vm_map_pages_zero(vma, buffer->pages, + buffer->page_count); } void fw_iso_buffer_destroy(struct fw_iso_buffer *buffer, -- 1.9.1
next prev parent reply other threads:[~2019-03-19 2:20 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-19 2:22 [RESEND PATCH v4 0/9] mm: Use vm_map_pages() and vm_map_pages_zero() API Souptick Joarder 2019-03-19 2:23 ` [RESEND PATCH v4 1/9] mm: Introduce new " Souptick Joarder 2019-04-16 11:49 ` [REBASE PATCH v5 " Souptick Joarder 2019-03-19 2:24 ` [RESEND PATCH v4 2/9] arm: mm: dma-mapping: Convert to use vm_map_pages() Souptick Joarder 2019-04-16 11:49 ` [REBASE PATCH v5 " Souptick Joarder 2019-03-19 2:25 ` Souptick Joarder [this message] 2019-04-16 11:49 ` [REBASE PATCH v5 3/9] drivers/firewire/core-iso.c: Convert to use vm_map_pages_zero() Souptick Joarder 2019-03-19 2:26 ` [RESEND PATCH v4 4/9] drm/rockchip/rockchip_drm_gem.c: Convert to use vm_map_pages() Souptick Joarder 2019-04-16 11:49 ` [REBASE PATCH v5 " Souptick Joarder 2019-03-19 2:27 ` [RESEND PATCH v4 5/9] drm/xen/xen_drm_front_gem.c: " Souptick Joarder 2019-04-16 11:49 ` [REBASE PATCH v5 " Souptick Joarder 2019-03-19 2:28 ` [RESEND PATCH v4 6/9] iommu/dma-iommu.c: " Souptick Joarder 2019-04-16 11:49 ` [REBASE PATCH v5 " Souptick Joarder 2019-03-19 2:29 ` [RESEND PATCH v4 7/9] videobuf2/videobuf2-dma-sg.c: " Souptick Joarder 2019-04-16 11:49 ` [REBASE PATCH v5 " Souptick Joarder 2019-03-19 2:30 ` [RESEND PATCH v4 8/9] xen/gntdev.c: " Souptick Joarder 2019-04-16 11:49 ` [REBASE PATCH v5 " Souptick Joarder 2019-03-19 2:30 ` [RESEND PATCH v4 9/9] xen/privcmd-buf.c: Convert to use vm_map_pages_zero() Souptick Joarder 2019-04-16 11:49 ` [REBASE PATCH v5 " Souptick Joarder 2019-04-01 5:26 ` [RESEND PATCH v4 0/9] mm: Use vm_map_pages() and vm_map_pages_zero() API Souptick Joarder 2019-04-09 6:17 ` Souptick Joarder 2019-04-16 11:49 ` [REBASE PATCH v5 " Souptick Joarder
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=88645f5ea8202784a8baaf389e592aeb8c505e8e.1552921225.git.jrdr.linux@gmail.com \ --to=jrdr.linux@gmail.com \ --cc=akpm@linux-foundation.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=linux1394-devel@lists.sourceforge.net \ --cc=linux@armlinux.org.uk \ --cc=mhocko@suse.com \ --cc=robin.murphy@arm.com \ --cc=stefanr@s5r6.in-berlin.de \ --cc=willy@infradead.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).