From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
linux-kernel@vger.kernel.org
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v2 6/7] x86/boot: Introduce MMIO accessors and their support in earlyprintk
Date: Tue, 19 Mar 2019 21:43:24 +0300 [thread overview]
Message-ID: <20190319184325.72807-7-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20190319184325.72807-1-andriy.shevchenko@linux.intel.com>
If user supplied serial base address via kernel command line and
at the same time the word 'mmio' is present, use MMIO accessors.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
arch/x86/boot/early_serial_console.c | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/arch/x86/boot/early_serial_console.c b/arch/x86/boot/early_serial_console.c
index 98aee6c6e374..cfc9e55cd68a 100644
--- a/arch/x86/boot/early_serial_console.c
+++ b/arch/x86/boot/early_serial_console.c
@@ -33,6 +33,20 @@ static void io_serial_out(unsigned long addr, int offset, int value)
outb(value, addr + offset);
}
+static void mem8_serial_out(unsigned long addr, int offset, int value)
+{
+ u8 __iomem *vaddr = (u8 __iomem *)addr;
+ /* shift implied by pointer type */
+ writeb(value, vaddr + offset);
+}
+
+static unsigned int mem8_serial_in(unsigned long addr, int offset)
+{
+ u8 __iomem *vaddr = (u8 __iomem *)addr;
+ /* shift implied by pointer type */
+ return readb(vaddr + offset);
+}
+
static void early_serial_configure(unsigned long port, int baud)
{
unsigned char c;
@@ -59,6 +73,13 @@ static void early_serial_use_io_accessors(void)
serial_out = io_serial_out;
}
+static void early_serial_use_mmio_accessors(void)
+{
+ /* It is memory mapped - assume 8-bit alignment */
+ serial_in = mem8_serial_in;
+ serial_out = mem8_serial_out;
+}
+
static void early_serial_init(unsigned long port, int baud)
{
early_serial_configure(port, baud);
@@ -101,12 +122,16 @@ static void parse_earlyprintk(void)
/*
* make sure we have
* "serial,0x3f8,115200"
+ * "serial,mmio,0xff010180,115200"
* "serial,ttyS0,115200"
* "ttyS0,115200"
*/
if (pos == 7 && !strncmp(arg + pos, "0x", 2)) {
port = parse_serial_port(arg, pos + 0, &pos);
early_serial_use_io_accessors();
+ } else if (pos == 7 && !strncmp(arg + pos, "mmio,0x", 7)) {
+ port = parse_serial_port(arg, pos + 5, &pos);
+ early_serial_use_mmio_accessors();
} else if (!strncmp(arg + pos, "ttyS", 4)) {
static const int bases[] = { 0x3f8, 0x2f8 };
int idx = 0;
--
2.20.1
next prev parent reply other threads:[~2019-03-19 18:43 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-19 18:43 [PATCH v2 0/7] x86/boot: Enable earlyprintk for HS UARTs Andy Shevchenko
2019-03-19 18:43 ` [PATCH v2 1/7] x86/boot: Convert early_serial_base to unsigned long Andy Shevchenko
2019-03-28 8:28 ` Borislav Petkov
2019-03-28 9:09 ` Andy Shevchenko
2019-03-28 10:54 ` Borislav Petkov
2019-03-19 18:43 ` [PATCH v2 2/7] x86/boot: Introduce helpers for serial I/O Andy Shevchenko
2019-03-28 12:32 ` Borislav Petkov
2019-03-28 13:11 ` Andy Shevchenko
2019-03-28 13:28 ` Borislav Petkov
2019-03-28 13:52 ` Andy Shevchenko
2019-03-28 14:05 ` Borislav Petkov
2019-03-28 14:20 ` Andy Shevchenko
2019-03-28 14:34 ` Borislav Petkov
2019-03-28 14:51 ` Andy Shevchenko
2019-03-19 18:43 ` [PATCH v2 3/7] x86/boot: Split out parse_serial_port() helper for earlyprintk Andy Shevchenko
2019-03-28 12:35 ` Borislav Petkov
2019-03-28 13:15 ` Andy Shevchenko
2019-03-28 13:39 ` Borislav Petkov
2019-03-28 13:50 ` Andy Shevchenko
2019-03-28 14:03 ` Borislav Petkov
2019-03-28 14:23 ` Andy Shevchenko
2019-03-28 14:35 ` Borislav Petkov
2019-03-28 14:49 ` Andy Shevchenko
2019-03-19 18:43 ` [PATCH v2 4/7] x86/boot: Allow longer parameter list " Andy Shevchenko
2019-03-19 18:43 ` [PATCH v2 5/7] x86/boot: Add MMIO byte accessors Andy Shevchenko
2019-03-19 18:43 ` Andy Shevchenko [this message]
2019-03-19 18:43 ` [PATCH v2 7/7] x86/boot: Support nocfg parameter for earlyprintk Andy Shevchenko
2019-03-20 15:05 ` Randy Dunlap
2019-03-20 15:17 ` Andy Shevchenko
2019-03-20 15:19 ` Randy Dunlap
2019-03-20 16:15 ` Andy Shevchenko
2019-03-20 16:30 ` Borislav Petkov
2019-03-20 17:29 ` Andy Shevchenko
2019-03-28 13:03 ` Borislav Petkov
2019-03-28 13:21 ` Andy Shevchenko
2019-03-28 13:42 ` Borislav Petkov
2019-03-28 14:00 ` Andy Shevchenko
2019-03-28 14:13 ` Borislav Petkov
2019-03-28 14:27 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190319184325.72807-7-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).