linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: linux-kernel@vger.kernel.org
Cc: x86@kernel.org, "Andy Lutomirski" <luto@kernel.org>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Radim Krčmář" <rkrcmar@redhat.com>,
	kvm@vger.kernel.org, "Jason A. Donenfeld" <Jason@zx2c4.com>,
	"Rik van Riel" <riel@surriel.com>,
	"Dave Hansen" <dave.hansen@linux.intel.com>,
	"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>
Subject: [PATCH 16/24] x86/entry: Add TIF_NEED_FPU_LOAD
Date: Thu, 21 Mar 2019 21:26:24 +0100	[thread overview]
Message-ID: <20190321202632.16810-17-bigeasy@linutronix.de> (raw)
In-Reply-To: <20190321202632.16810-1-bigeasy@linutronix.de>

Add TIF_NEED_FPU_LOAD. This is reserved for loading the FPU registers
before returning to userland. This flag must not be set for systems
without a FPU.
If this flag is cleared, the CPU's FPU register hold the current content
of current()'s FPU register. The in-memory copy (union fpregs_state) is
not valid.
If this flag is set, then all of CPU's FPU register may hold a random
value (except for PKRU) and it is required to load the content of the
FPU register on return to userland.

It is introduced now, so we can add code handling it now before adding
the main feature.

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
 arch/x86/include/asm/fpu/internal.h | 6 ++++++
 arch/x86/include/asm/thread_info.h  | 2 ++
 2 files changed, 8 insertions(+)

diff --git a/arch/x86/include/asm/fpu/internal.h b/arch/x86/include/asm/fpu/internal.h
index 82ff84a4c4ab7..b12874b7cf0cf 100644
--- a/arch/x86/include/asm/fpu/internal.h
+++ b/arch/x86/include/asm/fpu/internal.h
@@ -507,6 +507,12 @@ static inline void __fpregs_load_activate(struct fpu *fpu, int cpu)
  *
  * The FPU context is only stored/restore for user task and ->mm is used to
  * distinguish between kernel and user threads.
+ *
+ * If TIF_NEED_FPU_LOAD is cleared then the CPU's FPU registers are saved in
+ * the current thread's FPU registers state.
+ * If TIF_NEED_FPU_LOAD is set then CPU's FPU registers may not hold current()'s
+ * FPU registers. It is required to load the registers before returning to
+ * userland or using the content otherwise.
  */
 static inline void
 switch_fpu_prepare(struct fpu *old_fpu, int cpu)
diff --git a/arch/x86/include/asm/thread_info.h b/arch/x86/include/asm/thread_info.h
index e0eccbcb8447d..f9453536f9bbc 100644
--- a/arch/x86/include/asm/thread_info.h
+++ b/arch/x86/include/asm/thread_info.h
@@ -88,6 +88,7 @@ struct thread_info {
 #define TIF_USER_RETURN_NOTIFY	11	/* notify kernel of userspace return */
 #define TIF_UPROBE		12	/* breakpointed or singlestepping */
 #define TIF_PATCH_PENDING	13	/* pending live patching update */
+#define TIF_NEED_FPU_LOAD	14	/* load FPU on return to userspace */
 #define TIF_NOCPUID		15	/* CPUID is not accessible in userland */
 #define TIF_NOTSC		16	/* TSC is not accessible in userland */
 #define TIF_IA32		17	/* IA32 compatibility process */
@@ -117,6 +118,7 @@ struct thread_info {
 #define _TIF_USER_RETURN_NOTIFY	(1 << TIF_USER_RETURN_NOTIFY)
 #define _TIF_UPROBE		(1 << TIF_UPROBE)
 #define _TIF_PATCH_PENDING	(1 << TIF_PATCH_PENDING)
+#define _TIF_NEED_FPU_LOAD	(1 << TIF_NEED_FPU_LOAD)
 #define _TIF_NOCPUID		(1 << TIF_NOCPUID)
 #define _TIF_NOTSC		(1 << TIF_NOTSC)
 #define _TIF_IA32		(1 << TIF_IA32)
-- 
2.20.1


  parent reply	other threads:[~2019-03-21 20:28 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-21 20:26 [PATCH v8] x86: load FPU registers on return to userland Sebastian Andrzej Siewior
2019-03-21 20:26 ` [PATCH 01/24] x86/fpu: Remove fpu->initialized usage in __fpu__restore_sig() Sebastian Andrzej Siewior
2019-03-21 20:26 ` [PATCH 02/24] x86/fpu: Remove fpu__restore() Sebastian Andrzej Siewior
2019-03-21 20:26 ` [PATCH 03/24] x86/fpu: Remove preempt_disable() in fpu__clear() Sebastian Andrzej Siewior
2019-03-21 20:26 ` [PATCH 04/24] x86/fpu: Always init the `state' " Sebastian Andrzej Siewior
2019-03-21 20:26 ` [PATCH 05/24] x86/fpu: Remove fpu->initialized usage in copy_fpstate_to_sigframe() Sebastian Andrzej Siewior
2019-03-21 20:26 ` [PATCH 06/24] x86/fpu: Don't save fxregs for ia32 frames " Sebastian Andrzej Siewior
2019-03-21 20:26 ` [PATCH 07/24] x86/fpu: Remove fpu->initialized Sebastian Andrzej Siewior
2019-03-21 20:26 ` [PATCH 08/24] x86/fpu: Remove user_fpu_begin() Sebastian Andrzej Siewior
2019-03-21 20:26 ` [PATCH 09/24] x86/fpu: Add (__)make_fpregs_active helpers Sebastian Andrzej Siewior
2019-03-21 20:26 ` [PATCH 10/24] x86/fpu: Make __raw_xsave_addr() use feature number instead of mask Sebastian Andrzej Siewior
2019-03-21 20:26 ` [PATCH 11/24] x86/fpu: Make get_xsave_field_ptr() and get_xsave_addr() " Sebastian Andrzej Siewior
2019-03-21 20:26 ` [PATCH 12/24] x86/pkru: Provide .*_pkru_ins() functions Sebastian Andrzej Siewior
2019-03-21 20:26 ` [PATCH 13/24] x86/fpu: Only write PKRU if it is different from current Sebastian Andrzej Siewior
2019-03-21 20:26 ` [PATCH 14/24] x86/pkeys: Don't check if PKRU is zero before writting it Sebastian Andrzej Siewior
2019-03-21 20:26 ` [PATCH 15/24] x86/fpu: Eager switch PKRU state Sebastian Andrzej Siewior
2019-03-21 20:26 ` Sebastian Andrzej Siewior [this message]
2019-03-21 20:26 ` [PATCH 17/24] x86/fpu: Always store the registers in copy_fpstate_to_sigframe() Sebastian Andrzej Siewior
2019-03-31 16:54   ` Thomas Gleixner
2019-03-21 20:26 ` [PATCH 18/24] x86/fpu: Prepare copy_fpstate_to_sigframe() for TIF_NEED_FPU_LOAD Sebastian Andrzej Siewior
2019-03-31 18:20   ` Thomas Gleixner
2019-04-01  8:24     ` Sebastian Andrzej Siewior
2019-03-21 20:26 ` [PATCH 19/24] x86/fpu: Update xstate's PKRU value on write_pkru() Sebastian Andrzej Siewior
2019-03-21 20:26 ` [PATCH 20/24] x86/fpu: Inline copy_user_to_fpregs_zeroing() Sebastian Andrzej Siewior
2019-03-21 20:26 ` [PATCH 21/24] x86/fpu: Let __fpu__restore_sig() restore the !32bit+fxsr frame from kernel memory Sebastian Andrzej Siewior
2019-03-22 14:55   ` Sebastian Andrzej Siewior
2019-03-21 20:26 ` [PATCH 22/24] x86/fpu: Merge the two code paths in __fpu__restore_sig() Sebastian Andrzej Siewior
2019-03-21 20:26 ` [PATCH 23/24] x86/fpu: Defer FPU state load until return to userspace Sebastian Andrzej Siewior
2019-03-21 20:26 ` [PATCH 24/24] x86/pkeys: add PKRU value to init_fpstate Sebastian Andrzej Siewior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190321202632.16810-17-bigeasy@linutronix.de \
    --to=bigeasy@linutronix.de \
    --cc=Jason@zx2c4.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=riel@surriel.com \
    --cc=rkrcmar@redhat.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).