[19/24] dt-bindings: spi: spi-mt65xx: add support for MT8516
diff mbox series

Message ID 20190323211612.860-20-fparent@baylibre.com
State New
Headers show
Series
  • arm64: mediatek: add support for Pumpkin MT8516 board
Related show

Commit Message

Fabien Parent March 23, 2019, 9:16 p.m. UTC
Add binding documentation of spi-mt65xx for MT8516 SoC.

Signed-off-by: Fabien Parent <fparent@baylibre.com>
---
 Documentation/devicetree/bindings/spi/spi-mt65xx.txt | 1 +
 1 file changed, 1 insertion(+)

Comments

Rob Herring March 28, 2019, 7:12 p.m. UTC | #1
On Sat, Mar 23, 2019 at 4:17 PM Fabien Parent <fparent@baylibre.com> wrote:
>
> Add binding documentation of spi-mt65xx for MT8516 SoC.
>
> Signed-off-by: Fabien Parent <fparent@baylibre.com>
> ---
>  Documentation/devicetree/bindings/spi/spi-mt65xx.txt | 1 +
>  1 file changed, 1 insertion(+)

Acked-by: Rob Herring <robh@kernel.org>
Matthias Brugger April 16, 2019, 7:55 a.m. UTC | #2
On 23/03/2019 22:16, Fabien Parent wrote:
> Add binding documentation of spi-mt65xx for MT8516 SoC.
> 
> Signed-off-by: Fabien Parent <fparent@baylibre.com>
> ---
>  Documentation/devicetree/bindings/spi/spi-mt65xx.txt | 1 +
>  1 file changed, 1 insertion(+)
> 


applied to v5.1-next/dts64

Mark let me know if you want to take it through your tree and I drop the patch.

> diff --git a/Documentation/devicetree/bindings/spi/spi-mt65xx.txt b/Documentation/devicetree/bindings/spi/spi-mt65xx.txt
> index 69c356767cf8..69ac5976b952 100644
> --- a/Documentation/devicetree/bindings/spi/spi-mt65xx.txt
> +++ b/Documentation/devicetree/bindings/spi/spi-mt65xx.txt
> @@ -10,6 +10,7 @@ Required properties:
>      - mediatek,mt8135-spi: for mt8135 platforms
>      - mediatek,mt8173-spi: for mt8173 platforms
>      - mediatek,mt8183-spi: for mt8183 platforms
> +    - "mediatek,mt8516-spi", "mediatek,mt2701-spi": for mt8516 platforms
>  
>  - #address-cells: should be 1.
>  
>
Leilk Liu April 16, 2019, 8:25 a.m. UTC | #3
On Tue, 2019-04-16 at 09:55 +0200, Matthias Brugger wrote:
> 
> On 23/03/2019 22:16, Fabien Parent wrote:
> > Add binding documentation of spi-mt65xx for MT8516 SoC.
> > 
> > Signed-off-by: Fabien Parent <fparent@baylibre.com>
> > ---
> >  Documentation/devicetree/bindings/spi/spi-mt65xx.txt | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> 
> 
> applied to v5.1-next/dts64
> 
> Mark let me know if you want to take it through your tree and I drop the patch.
> 
> > diff --git a/Documentation/devicetree/bindings/spi/spi-mt65xx.txt b/Documentation/devicetree/bindings/spi/spi-mt65xx.txt
> > index 69c356767cf8..69ac5976b952 100644
> > --- a/Documentation/devicetree/bindings/spi/spi-mt65xx.txt
> > +++ b/Documentation/devicetree/bindings/spi/spi-mt65xx.txt
> > @@ -10,6 +10,7 @@ Required properties:
> >      - mediatek,mt8135-spi: for mt8135 platforms
> >      - mediatek,mt8173-spi: for mt8173 platforms
> >      - mediatek,mt8183-spi: for mt8183 platforms
> > +    - "mediatek,mt8516-spi", "mediatek,mt2701-spi": for mt8516 platforms
Hi Fabien,
mt8516 SPI design comes from mt2712 and it's different from mt2701. Here
it should compatible with mt2712.

> >  
> >  - #address-cells: should be 1.
> >  
> > 
> 
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
Matthias Brugger April 16, 2019, 8:52 a.m. UTC | #4
On 16/04/2019 10:25, lei liu wrote:
> On Tue, 2019-04-16 at 09:55 +0200, Matthias Brugger wrote:
>>
>> On 23/03/2019 22:16, Fabien Parent wrote:
>>> Add binding documentation of spi-mt65xx for MT8516 SoC.
>>>
>>> Signed-off-by: Fabien Parent <fparent@baylibre.com>
>>> ---
>>>  Documentation/devicetree/bindings/spi/spi-mt65xx.txt | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>
>>
>> applied to v5.1-next/dts64
>>
>> Mark let me know if you want to take it through your tree and I drop the patch.
>>
>>> diff --git a/Documentation/devicetree/bindings/spi/spi-mt65xx.txt b/Documentation/devicetree/bindings/spi/spi-mt65xx.txt
>>> index 69c356767cf8..69ac5976b952 100644
>>> --- a/Documentation/devicetree/bindings/spi/spi-mt65xx.txt
>>> +++ b/Documentation/devicetree/bindings/spi/spi-mt65xx.txt
>>> @@ -10,6 +10,7 @@ Required properties:
>>>      - mediatek,mt8135-spi: for mt8135 platforms
>>>      - mediatek,mt8173-spi: for mt8173 platforms
>>>      - mediatek,mt8183-spi: for mt8183 platforms
>>> +    - "mediatek,mt8516-spi", "mediatek,mt2701-spi": for mt8516 platforms
> Hi Fabien,
> mt8516 SPI design comes from mt2712 and it's different from mt2701. Here
> it should compatible with mt2712.
> 

Ok, please resend. I dropped the patch for now.

>>>  
>>>  - #address-cells: should be 1.
>>>  
>>>
>>
>> _______________________________________________
>> Linux-mediatek mailing list
>> Linux-mediatek@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-mediatek
> 
>
Mark Brown April 16, 2019, 2:28 p.m. UTC | #5
On Tue, Apr 16, 2019 at 09:55:41AM +0200, Matthias Brugger wrote:
> On 23/03/2019 22:16, Fabien Parent wrote:
> > Add binding documentation of spi-mt65xx for MT8516 SoC.

> > Signed-off-by: Fabien Parent <fparent@baylibre.com>
> > ---
> >  Documentation/devicetree/bindings/spi/spi-mt65xx.txt | 1 +
> >  1 file changed, 1 insertion(+)

> applied to v5.1-next/dts64

> Mark let me know if you want to take it through your tree and I drop the patch.

Yes, DT bindings generally get reviewed in the subsystem :(
Matthias Brugger April 17, 2019, 8:19 a.m. UTC | #6
On 16/04/2019 16:28, Mark Brown wrote:
> On Tue, Apr 16, 2019 at 09:55:41AM +0200, Matthias Brugger wrote:
>> On 23/03/2019 22:16, Fabien Parent wrote:
>>> Add binding documentation of spi-mt65xx for MT8516 SoC.
> 
>>> Signed-off-by: Fabien Parent <fparent@baylibre.com> --- 
>>> Documentation/devicetree/bindings/spi/spi-mt65xx.txt | 1 + 1 file
>>> changed, 1 insertion(+)
> 
>> applied to v5.1-next/dts64
> 
>> Mark let me know if you want to take it through your tree and I drop the
>> patch.
> 
> Yes, DT bindings generally get reviewed in the subsystem :(
> 

I already dropped it due to some comments from Lei Liu:
https://patchwork.kernel.org/patch/10867251/

Regards,
Matthias
Fabien Parent April 18, 2019, 8:05 a.m. UTC | #7
On Tue, Apr 16, 2019 at 10:25 AM lei liu <leilk.liu@mediatek.com> wrote:
>
> On Tue, 2019-04-16 at 09:55 +0200, Matthias Brugger wrote:
> >
> > On 23/03/2019 22:16, Fabien Parent wrote:
> > > Add binding documentation of spi-mt65xx for MT8516 SoC.
> > >
> > > Signed-off-by: Fabien Parent <fparent@baylibre.com>
> > > ---
> > >  Documentation/devicetree/bindings/spi/spi-mt65xx.txt | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> >
> >
> > applied to v5.1-next/dts64
> >
> > Mark let me know if you want to take it through your tree and I drop the patch.
> >
> > > diff --git a/Documentation/devicetree/bindings/spi/spi-mt65xx.txt b/Documentation/devicetree/bindings/spi/spi-mt65xx.txt
> > > index 69c356767cf8..69ac5976b952 100644
> > > --- a/Documentation/devicetree/bindings/spi/spi-mt65xx.txt
> > > +++ b/Documentation/devicetree/bindings/spi/spi-mt65xx.txt
> > > @@ -10,6 +10,7 @@ Required properties:
> > >      - mediatek,mt8135-spi: for mt8135 platforms
> > >      - mediatek,mt8173-spi: for mt8173 platforms
> > >      - mediatek,mt8183-spi: for mt8183 platforms
> > > +    - "mediatek,mt8516-spi", "mediatek,mt2701-spi": for mt8516 platforms
> Hi Fabien,
> mt8516 SPI design comes from mt2712 and it's different from mt2701. Here
> it should compatible with mt2712.

Ok, thanks. I will retry with the mt2712 compatible.

> > >
> > >  - #address-cells: should be 1.
> > >
> > >
> >
> > _______________________________________________
> > Linux-mediatek mailing list
> > Linux-mediatek@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-mediatek
>
>
Leilk Liu April 18, 2019, 8:18 a.m. UTC | #8
On Thu, 2019-04-18 at 10:05 +0200, Fabien Parent wrote:
> On Tue, Apr 16, 2019 at 10:25 AM lei liu <leilk.liu@mediatek.com> wrote:
> >
> > On Tue, 2019-04-16 at 09:55 +0200, Matthias Brugger wrote:
> > >
> > > On 23/03/2019 22:16, Fabien Parent wrote:
> > > > Add binding documentation of spi-mt65xx for MT8516 SoC.
> > > >
> > > > Signed-off-by: Fabien Parent <fparent@baylibre.com>
> > > > ---
> > > >  Documentation/devicetree/bindings/spi/spi-mt65xx.txt | 1 +
> > > >  1 file changed, 1 insertion(+)
> > > >
> > >
> > >
> > > applied to v5.1-next/dts64
> > >
> > > Mark let me know if you want to take it through your tree and I drop the patch.
> > >
> > > > diff --git a/Documentation/devicetree/bindings/spi/spi-mt65xx.txt b/Documentation/devicetree/bindings/spi/spi-mt65xx.txt
> > > > index 69c356767cf8..69ac5976b952 100644
> > > > --- a/Documentation/devicetree/bindings/spi/spi-mt65xx.txt
> > > > +++ b/Documentation/devicetree/bindings/spi/spi-mt65xx.txt
> > > > @@ -10,6 +10,7 @@ Required properties:
> > > >      - mediatek,mt8135-spi: for mt8135 platforms
> > > >      - mediatek,mt8173-spi: for mt8173 platforms
> > > >      - mediatek,mt8183-spi: for mt8183 platforms
> > > > +    - "mediatek,mt8516-spi", "mediatek,mt2701-spi": for mt8516 platforms
> > Hi Fabien,
> > mt8516 SPI design comes from mt2712 and it's different from mt2701. Here
> > it should compatible with mt2712.
> 
> Ok, thanks. I will retry with the mt2712 compatible.
> 

Hi, I already send mt8516 spi patch and it's applied by Mark. Please
don't do it again. Thanks.

> > > >
> > > >  - #address-cells: should be 1.
> > > >
> > > >
> > >
> > > _______________________________________________
> > > Linux-mediatek mailing list
> > > Linux-mediatek@lists.infradead.org
> > > http://lists.infradead.org/mailman/listinfo/linux-mediatek
> >
> >

Patch
diff mbox series

diff --git a/Documentation/devicetree/bindings/spi/spi-mt65xx.txt b/Documentation/devicetree/bindings/spi/spi-mt65xx.txt
index 69c356767cf8..69ac5976b952 100644
--- a/Documentation/devicetree/bindings/spi/spi-mt65xx.txt
+++ b/Documentation/devicetree/bindings/spi/spi-mt65xx.txt
@@ -10,6 +10,7 @@  Required properties:
     - mediatek,mt8135-spi: for mt8135 platforms
     - mediatek,mt8173-spi: for mt8173 platforms
     - mediatek,mt8183-spi: for mt8183 platforms
+    - "mediatek,mt8516-spi", "mediatek,mt2701-spi": for mt8516 platforms
 
 - #address-cells: should be 1.