From: Jianchao Wang <jianchao.w.wang@oracle.com>
To: axboe@kernel.dk
Cc: hch@lst.de, jthumshirn@suse.de, hare@suse.de,
josef@toxicpanda.com, bvanassche@acm.org, sagi@grimberg.me,
keith.busch@intel.com, jsmart2021@gmail.com,
linux-block@vger.kernel.org, linux-nvme@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: [PATCH V2 5/8] nbd: use blk_mq_queue_tag_inflight_iter
Date: Mon, 25 Mar 2019 13:38:35 +0800 [thread overview]
Message-ID: <1553492318-1810-6-git-send-email-jianchao.w.wang@oracle.com> (raw)
In-Reply-To: <1553492318-1810-1-git-send-email-jianchao.w.wang@oracle.com>
blk_mq_tagset_busy_iter is not safe that it could get stale request
in tags->rqs[]. Use blk_mq_queue_tag_inflight_iter here.
Signed-off-by: Jianchao Wang <jianchao.w.wang@oracle.com>
---
drivers/block/nbd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
index 90ba9f4..c48984b 100644
--- a/drivers/block/nbd.c
+++ b/drivers/block/nbd.c
@@ -747,7 +747,7 @@ static bool nbd_clear_req(struct request *req, void *data, bool reserved)
static void nbd_clear_que(struct nbd_device *nbd)
{
blk_mq_quiesce_queue(nbd->disk->queue);
- blk_mq_tagset_busy_iter(&nbd->tag_set, nbd_clear_req, NULL);
+ blk_mq_queue_tag_inflight_iter(nbd->disk->queue, nbd_clear_req, NULL);
blk_mq_unquiesce_queue(nbd->disk->queue);
dev_dbg(disk_to_dev(nbd->disk), "queue cleared\n");
}
--
2.7.4
next prev parent reply other threads:[~2019-03-25 5:47 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 5:38 [PATCH V2 0/8]: blk-mq: use static_rqs to iterate busy tags Jianchao Wang
2019-03-25 5:38 ` [PATCH V2 1/8] blk-mq: get rid of the synchronize_rcu in __blk_mq_update_nr_hw_queues Jianchao Wang
2019-03-25 5:38 ` [PATCH V2 2/8] blk-mq: use static_rqs instead of rqs to iterate tags Jianchao Wang
2019-03-25 7:12 ` Dongli Zhang
2019-03-25 7:14 ` jianchao.wang
2019-03-25 5:38 ` [PATCH V2 3/8] blk-mq: use blk_mq_queue_tag_inflight_iter in debugfs Jianchao Wang
2019-03-25 5:38 ` [PATCH V2 4/8] mtip32xx: use blk_mq_queue_tag_inflight_iter Jianchao Wang
2019-03-25 5:38 ` Jianchao Wang [this message]
2019-03-25 5:38 ` [PATCH V2 6/8] skd: " Jianchao Wang
2019-03-25 5:38 ` [PATCH V2 7/8] nvme: " Jianchao Wang
2019-03-25 13:49 ` Keith Busch
2019-03-26 1:17 ` jianchao.wang
2019-03-26 2:41 ` Ming Lei
2019-03-26 3:05 ` jianchao.wang
2019-03-26 23:57 ` Keith Busch
2019-03-27 2:03 ` jianchao.wang
2019-03-27 2:15 ` Keith Busch
2019-03-27 2:27 ` jianchao.wang
2019-03-27 2:33 ` Keith Busch
2019-03-27 2:45 ` jianchao.wang
2019-03-27 6:51 ` Keith Busch
2019-03-27 7:18 ` jianchao.wang
2019-03-25 5:38 ` [PATCH V2 8/8] blk-mq: remove blk_mq_tagset_busy_iter Jianchao Wang
2019-03-25 7:18 ` Hannes Reinecke
2019-03-25 7:37 ` jianchao.wang
2019-03-25 8:25 ` Hannes Reinecke
2019-03-25 9:12 ` jianchao.wang
2019-03-26 14:17 ` Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2019-03-25 5:28 [PATCH V2 0/8]: blk-mq: use static_rqs to iterate busy tags Jianchao Wang
2019-03-25 5:28 ` [PATCH V2 5/8] nbd: use blk_mq_queue_tag_inflight_iter Jianchao Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1553492318-1810-6-git-send-email-jianchao.w.wang@oracle.com \
--to=jianchao.w.wang@oracle.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=josef@toxicpanda.com \
--cc=jsmart2021@gmail.com \
--cc=jthumshirn@suse.de \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).