From: Borislav Petkov <bp@alien8.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Bjorn Helgaas <bhelgaas@google.com>,
Lukas Wunner <lukas@wunner.de>,
Alexandru Gagniuc <mr.nuke.me@gmail.com>,
linux-pci@vger.kernel.org
Subject: [PATCH] PCI/LINK: Request a one-shot IRQ with NULL handler
Date: Mon, 25 Mar 2019 19:23:38 +0100 [thread overview]
Message-ID: <20190325182338.13609-1-bp@alien8.de> (raw)
From: Borislav Petkov <bp@suse.de>
Booting v5.1-rc1 causes these new messages in dmesg here:
genirq: Threaded irq requested with handler=NULL and !ONESHOT for irq 24
pcie_bw_notification: probe of 0000:00:02.0:pcie010 failed with error -22
because requesting a threaded IRQ with NULL handler needs to be oneshot.
Otherwise a level-triggered interrupt endless loop can happen, see the
detailed explanation above the "Threaded irq... " error message in
kernel/irq/manage.c.
And PCI-MSI type interrupts are one-shot safe but not in the IOAPIC
case:
24: ... IO-APIC 28-fasteoi PCIe BW notif, PCIe BW notif, PCIe BW notif
25: ... IO-APIC 29-fasteoi PCIe BW notif, PCIe BW notif
Make the BW notification handler oneshot too.
Fixes: e8303bb7a75c ("PCI/LINK: Report degraded links via link bandwidth notification")
Suggested-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: Lukas Wunner <lukas@wunner.de>
Cc: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Cc: linux-pci@vger.kernel.org
---
drivers/pci/pcie/bw_notification.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/pcie/bw_notification.c b/drivers/pci/pcie/bw_notification.c
index d2eae3b7cc0f..16e11c09f6bd 100644
--- a/drivers/pci/pcie/bw_notification.c
+++ b/drivers/pci/pcie/bw_notification.c
@@ -81,7 +81,7 @@ static int pcie_bandwidth_notification_probe(struct pcie_device *srv)
return -ENODEV;
ret = request_threaded_irq(srv->irq, NULL, pcie_bw_notification_handler,
- IRQF_SHARED, "PCIe BW notif", srv);
+ IRQF_SHARED | IRQF_ONESHOT, "PCIe BW notif", srv);
if (ret)
return ret;
--
2.21.0
next reply other threads:[~2019-03-25 18:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 18:23 Borislav Petkov [this message]
2019-03-25 18:27 ` [PATCH] PCI/LINK: Request a one-shot IRQ with NULL handler Alex G.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190325182338.13609-1-bp@alien8.de \
--to=bp@alien8.de \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mr.nuke.me@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).