From: Baoquan He <bhe@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: linux-mm@kvack.org, akpm@linux-foundation.org, mhocko@suse.com,
rppt@linux.ibm.com, osalvador@suse.de, willy@infradead.org,
william.kucharski@oracle.com, Baoquan He <bhe@redhat.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>
Subject: [PATCH v2 4/4] drivers/base/memory.c: Rename the misleading parameter
Date: Tue, 26 Mar 2019 17:02:27 +0800 [thread overview]
Message-ID: <20190326090227.3059-5-bhe@redhat.com> (raw)
In-Reply-To: <20190326090227.3059-1-bhe@redhat.com>
The input parameter 'phys_index' of memory_block_action() is actually
the section number, but not the phys_index of memory_block. Fix it.
Signed-off-by: Baoquan He <bhe@redhat.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>
---
drivers/base/memory.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/base/memory.c b/drivers/base/memory.c
index cb8347500ce2..184f4f8d1b62 100644
--- a/drivers/base/memory.c
+++ b/drivers/base/memory.c
@@ -231,13 +231,13 @@ static bool pages_correctly_probed(unsigned long start_pfn)
* OK to have direct references to sparsemem variables in here.
*/
static int
-memory_block_action(unsigned long phys_index, unsigned long action, int online_type)
+memory_block_action(unsigned long sec, unsigned long action, int online_type)
{
unsigned long start_pfn;
unsigned long nr_pages = PAGES_PER_SECTION * sections_per_block;
int ret;
- start_pfn = section_nr_to_pfn(phys_index);
+ start_pfn = section_nr_to_pfn(sec);
switch (action) {
case MEM_ONLINE:
@@ -251,7 +251,7 @@ memory_block_action(unsigned long phys_index, unsigned long action, int online_t
break;
default:
WARN(1, KERN_WARNING "%s(%ld, %ld) unknown action: "
- "%ld\n", __func__, phys_index, action, action);
+ "%ld\n", __func__, sec, action, action);
ret = -EINVAL;
}
--
2.17.2
next prev parent reply other threads:[~2019-03-26 9:02 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-26 9:02 [PATCH v2 0/4] Clean up comments and codes in sparse_add_one_section() Baoquan He
2019-03-26 9:02 ` [PATCH v2 1/4] mm/sparse: Clean up the obsolete code comment Baoquan He
2019-03-26 9:23 ` Mike Rapoport
2019-03-26 9:23 ` Michal Hocko
2019-03-26 9:30 ` Baoquan He
2019-03-26 9:36 ` Chao Fan
2019-03-26 9:43 ` Baoquan He
2019-03-26 9:46 ` Chao Fan
2019-03-26 9:02 ` [PATCH v2 2/4] mm/sparse: Optimize sparse_add_one_section() Baoquan He
2019-03-26 9:23 ` Mike Rapoport
2019-03-26 9:29 ` Michal Hocko
2019-03-26 10:08 ` Baoquan He
2019-03-26 10:17 ` Michal Hocko
2019-03-26 13:45 ` Baoquan He
2019-03-26 13:57 ` Mike Rapoport
2019-03-26 14:03 ` Michal Hocko
2019-03-26 14:18 ` Baoquan He
2019-03-26 14:31 ` Michal Hocko
2019-03-26 22:57 ` Baoquan He
2019-03-26 9:02 ` [PATCH v2 3/4] mm/sparse: Rename function related to section memmap allocation/free Baoquan He
2019-03-26 9:02 ` Baoquan He [this message]
2019-03-26 9:20 ` [PATCH v2 4/4] drivers/base/memory.c: Rename the misleading parameter Rafael J. Wysocki
2019-03-26 9:33 ` Michal Hocko
2019-03-26 11:43 ` Matthew Wilcox
2019-03-26 12:42 ` Baoquan He
2019-03-29 6:44 ` [PATCH v2 0/4] Clean up comments and codes in sparse_add_one_section() Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190326090227.3059-5-bhe@redhat.com \
--to=bhe@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
--cc=rafael@kernel.org \
--cc=rppt@linux.ibm.com \
--cc=william.kucharski@oracle.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).