From: Nathan Chancellor <natechancellor@gmail.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org,
Ladislav Michl <ladis@linux-mips.org>,
Tony Lindgren <tony@atomide.com>,
YueHaibing <yuehaibing@huawei.com>,
Nathan Chancellor <natechancellor@gmail.com>
Subject: [PATCH] clocksource/drivers/timer-ti-dm: Remove omap_dm_timer_set_load_start
Date: Tue, 26 Mar 2019 22:01:27 -0700 [thread overview]
Message-ID: <20190327050126.12064-1-natechancellor@gmail.com> (raw)
Commit 008258d995a6 ("clocksource/drivers/timer-ti-dm: Make
omap_dm_timer_set_load_start() static") made omap_dm_time_set_load_start
static because its prototype was not defined in a header. Unfortunately,
this causes a build warning on multi_v7_defconfig because this function
is not used anywhere in this translation unit:
drivers/clocksource/timer-ti-dm.c:589:12: error: unused function
'omap_dm_timer_set_load_start' [-Werror,-Wunused-function]
In fact, omap_dm_timer_set_load_start hasn't been used anywhere since
commit f190be7f39a5 ("staging: tidspbridge: remove driver") and the
prototype was removed in commit 592ea6bd1fad ("clocksource: timer-ti-dm:
Make unexported functions static"), which is probably where this should
have happened.
Fixes: 592ea6bd1fad ("clocksource: timer-ti-dm: Make unexported functions static")
Fixes: 008258d995a6 ("clocksource/drivers/timer-ti-dm: Make omap_dm_timer_set_load_start() static")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
---
My apologies if this has already been sent, I didn't see anything in tip
or on LKML.
drivers/clocksource/timer-ti-dm.c | 28 ----------------------------
1 file changed, 28 deletions(-)
diff --git a/drivers/clocksource/timer-ti-dm.c b/drivers/clocksource/timer-ti-dm.c
index 3352da6ed61f..ee8ec5a8cb16 100644
--- a/drivers/clocksource/timer-ti-dm.c
+++ b/drivers/clocksource/timer-ti-dm.c
@@ -585,34 +585,6 @@ static int omap_dm_timer_set_load(struct omap_dm_timer *timer, int autoreload,
return 0;
}
-/* Optimized set_load which removes costly spin wait in timer_start */
-static int omap_dm_timer_set_load_start(struct omap_dm_timer *timer,
- int autoreload, unsigned int load)
-{
- u32 l;
-
- if (unlikely(!timer))
- return -EINVAL;
-
- omap_dm_timer_enable(timer);
-
- l = omap_dm_timer_read_reg(timer, OMAP_TIMER_CTRL_REG);
- if (autoreload) {
- l |= OMAP_TIMER_CTRL_AR;
- omap_dm_timer_write_reg(timer, OMAP_TIMER_LOAD_REG, load);
- } else {
- l &= ~OMAP_TIMER_CTRL_AR;
- }
- l |= OMAP_TIMER_CTRL_ST;
-
- __omap_dm_timer_load_start(timer, l, load, timer->posted);
-
- /* Save the context */
- timer->context.tclr = l;
- timer->context.tldr = load;
- timer->context.tcrr = load;
- return 0;
-}
static int omap_dm_timer_set_match(struct omap_dm_timer *timer, int enable,
unsigned int match)
{
--
2.21.0
next reply other threads:[~2019-03-27 5:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-27 5:01 Nathan Chancellor [this message]
2019-03-27 8:11 ` [PATCH] clocksource/drivers/timer-ti-dm: Remove omap_dm_timer_set_load_start Ladislav Michl
2019-04-04 14:17 ` Tony Lindgren
2019-04-04 18:39 ` Keerthy
2019-04-10 17:01 ` Daniel Lezcano
2019-04-10 20:07 ` Tony Lindgren
2019-04-11 19:20 ` Daniel Lezcano
2019-04-11 19:36 ` Nathan Chancellor
2019-04-11 20:13 ` Daniel Lezcano
2019-04-11 20:42 ` Tony Lindgren
2019-04-11 20:25 ` Daniel Lezcano
2019-04-11 20:56 ` Tony Lindgren
2019-04-12 4:59 ` Nathan Chancellor
2019-04-12 15:40 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190327050126.12064-1-natechancellor@gmail.com \
--to=natechancellor@gmail.com \
--cc=daniel.lezcano@linaro.org \
--cc=ladis@linux-mips.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tony@atomide.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).