From: Zenghui Yu <yuzenghui@huawei.com>
To: <marc.zyngier@arm.com>, <julien.thierry@arm.com>, <rostedt@goodmis.org>
Cc: <mingo@redhat.com>, <catalin.marinas@arm.com>,
<will.deacon@arm.com>, <mark.rutland@arm.com>,
<linux@armlinux.org.uk>, <james.morse@arm.com>,
<suzuki.poulose@arm.com>, <wanghaibin.wang@huawei.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, Zenghui Yu <yuzenghui@huawei.com>
Subject: [RFC PATCH] irqchip/gic-v3: Make gic_handle_irq() notrace
Date: Fri, 29 Mar 2019 13:23:28 +0000 [thread overview]
Message-ID: <1553865808-30604-1-git-send-email-yuzenghui@huawei.com> (raw)
Enable pseudo NMI together with function_graph tracer, will lead
the system to a hang. This is easy to reproduce,
1) Set "irqchip.gicv3_pseudo_nmi=1" on the kernel command line
2) echo function_graph > /sys/kernel/debug/tracing/current_tracer
This patch (RFC) set gic_handle_irq() as notrace and it seems works
fine now. But I have no idea about what the issue is exactly, and
you can regard this patch as a report then :)
Can someone give a look at it and provide some explanations ?
Thanks!
Cc: Julien Thierry <julien.thierry@arm.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Zenghui Yu <yuzenghui@huawei.com>
---
drivers/irqchip/irq-gic-v3.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c
index 15e55d3..8d0c25f 100644
--- a/drivers/irqchip/irq-gic-v3.c
+++ b/drivers/irqchip/irq-gic-v3.c
@@ -487,7 +487,7 @@ static inline void gic_handle_nmi(u32 irqnr, struct pt_regs *regs)
gic_deactivate_unhandled(irqnr);
}
-static asmlinkage void __exception_irq_entry gic_handle_irq(struct pt_regs *regs)
+static asmlinkage notrace void __exception_irq_entry gic_handle_irq(struct pt_regs *regs)
{
u32 irqnr;
--
1.8.3.1
next reply other threads:[~2019-03-29 13:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-29 13:23 Zenghui Yu [this message]
2019-03-29 13:58 ` [RFC PATCH] irqchip/gic-v3: Make gic_handle_irq() notrace Marc Zyngier
2019-03-29 14:53 ` Steven Rostedt
2019-03-29 15:35 ` Zenghui Yu
2019-03-29 15:45 ` Steven Rostedt
2019-03-29 16:19 ` Zenghui Yu
2019-03-29 15:02 ` Zenghui Yu
2019-04-02 14:00 ` Julien Thierry
2019-04-03 15:23 ` liwei (GF)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1553865808-30604-1-git-send-email-yuzenghui@huawei.com \
--to=yuzenghui@huawei.com \
--cc=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=julien.thierry@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=suzuki.poulose@arm.com \
--cc=wanghaibin.wang@huawei.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).