From: Sugar Zhang <sugar.zhang@rock-chips.com>
To: heiko@sntech.de, broonie@kernel.org
Cc: linux-rockchip@lists.infradead.org,
Sugar Zhang <sugar.zhang@rock-chips.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v1 04/12] ASoC: rockchip: pdm: optimize clear logic
Date: Wed, 3 Apr 2019 21:40:48 +0800 [thread overview]
Message-ID: <1554298856-59028-5-git-send-email-sugar.zhang@rock-chips.com> (raw)
In-Reply-To: <1554298856-59028-1-git-send-email-sugar.zhang@rock-chips.com>
There is no need to reset controller every time, do this
once in pdm_probe.
Signed-off-by: Sugar Zhang <sugar.zhang@rock-chips.com>
---
sound/soc/rockchip/rockchip_pdm.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/sound/soc/rockchip/rockchip_pdm.c b/sound/soc/rockchip/rockchip_pdm.c
index 8c1be59..abbb6d7 100644
--- a/sound/soc/rockchip/rockchip_pdm.c
+++ b/sound/soc/rockchip/rockchip_pdm.c
@@ -183,9 +183,6 @@ static int rockchip_pdm_hw_params(struct snd_pcm_substream *substream,
val);
regmap_update_bits(pdm->regmap, PDM_DMA_CTRL, PDM_DMA_RDL_MSK,
PDM_DMA_RDL(16));
- regmap_update_bits(pdm->regmap, PDM_SYSCONFIG,
- PDM_RX_MASK | PDM_RX_CLR_MASK,
- PDM_RX_STOP | PDM_RX_CLR_WR);
}
return 0;
@@ -355,6 +352,7 @@ static bool rockchip_pdm_volatile_reg(struct device *dev, unsigned int reg)
{
switch (reg) {
case PDM_SYSCONFIG:
+ case PDM_FIFO_CTRL:
case PDM_INT_CLR:
case PDM_INT_ST:
return true;
@@ -438,6 +436,7 @@ static int rockchip_pdm_probe(struct platform_device *pdev)
goto err_suspend;
}
+ rockchip_pdm_rxctrl(pdm, 0);
ret = devm_snd_dmaengine_pcm_register(&pdev->dev, NULL, 0);
if (ret) {
dev_err(&pdev->dev, "could not register pcm: %d\n", ret);
--
2.7.4
next prev parent reply other threads:[~2019-04-03 13:42 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 13:40 [PATCH v1 0/12] Patches to update pdm for rockchip socs Sugar Zhang
2019-04-03 13:40 ` [PATCH v1 01/12] ASoC: rockchip: pdm: fix regmap_ops hang issue Sugar Zhang
2019-04-04 8:17 ` Applied "ASoC: rockchip: pdm: fix regmap_ops hang issue" to the asoc tree Mark Brown
2019-04-03 13:40 ` [PATCH v1 02/12] ASoC: rockchip: pdm: using left justified store mode Sugar Zhang
2019-04-04 7:51 ` Mark Brown
2019-04-04 8:16 ` Applied "ASoC: rockchip: pdm: using left justified store mode" to the asoc tree Mark Brown
2019-04-03 13:40 ` [PATCH v1 03/12] ASoC: rockchip: pdm: add default regs Sugar Zhang
2019-04-04 8:16 ` Applied "ASoC: rockchip: pdm: add default regs" to the asoc tree Mark Brown
2019-04-03 13:40 ` Sugar Zhang [this message]
2019-04-04 8:16 ` Applied "ASoC: rockchip: pdm: optimize clear logic" " Mark Brown
2019-04-04 3:48 ` [PATCH v1 05/12] ASoC: rockchip: pdm: change dma burst to 8 Sugar Zhang
2019-04-04 8:16 ` Applied "ASoC: rockchip: pdm: change dma burst to 8" to the asoc tree Mark Brown
2019-04-04 3:51 ` [PATCH v1 06/12] ASoC: rockchip: pdm: fixup pdm fractional div Sugar Zhang
2019-04-04 8:16 ` Applied "ASoC: rockchip: pdm: fixup pdm fractional div" to the asoc tree Mark Brown
2019-04-04 3:53 ` [PATCH v1 07/12] dt-bindings: sound: rockchip: add compatible for rk3308/px30 Sugar Zhang
2019-04-04 8:16 ` Applied "dt-bindings: sound: rockchip: add compatible for rk3308/px30" to the asoc tree Mark Brown
2019-04-04 3:54 ` [PATCH v1 08/12] ASoC: rockchip: pdm: add compatible for rk1808 Sugar Zhang
2019-04-04 8:16 ` Applied "ASoC: rockchip: pdm: add compatible for rk1808" to the asoc tree Mark Brown
2019-04-04 3:55 ` [PATCH v1 09/12] dt-bindings: sound: add compatible for rk1808 Sugar Zhang
2019-04-04 8:16 ` Applied "dt-bindings: sound: add compatible for rk1808" to the asoc tree Mark Brown
2019-04-04 3:56 ` [PATCH v1 10/12] ASoC: rockchip: pdm: adjust waterlevel in frame unit Sugar Zhang
2019-04-04 8:16 ` Applied "ASoC: rockchip: pdm: adjust waterlevel in frame unit" to the asoc tree Mark Brown
2019-04-04 3:57 ` [PATCH v1 11/12] ASoC: rockchip: pdm: Mark RXFIFO_DATA as volatile and precious Sugar Zhang
2019-04-04 8:16 ` Applied "ASoC: rockchip: pdm: Mark RXFIFO_DATA as volatile and precious" to the asoc tree Mark Brown
2019-04-04 3:57 ` [PATCH v1 12/12] ASoC: rockchip: pdm: Correct PDM_CTRL0 reg value Sugar Zhang
2019-04-04 8:16 ` Applied "ASoC: rockchip: pdm: Correct PDM_CTRL0 reg value" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1554298856-59028-5-git-send-email-sugar.zhang@rock-chips.com \
--to=sugar.zhang@rock-chips.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=heiko@sntech.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).