[2/2] mfd: cros_ec: Instantiate the CrOS USB PD logger driver
diff mbox series

Message ID 20190403135403.9472-2-enric.balletbo@collabora.com
State New
Headers show
Series
  • [1/2] platform/chrome: Add CrOS USB PD logging driver
Related show

Commit Message

Enric Balletbo i Serra April 3, 2019, 1:54 p.m. UTC
Add the cros-usbpd-logger driver for logging event data for the USB PD
charger available in the Embedded Controller on ChromeOS systems. The
logging feature is logically separate functionality from charge manager,
hence is instantiated as a different driver.

Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
---
Lee, this is send as separate patch because touches the MFD subsystem,
apart from that the driver won't be instantiated if [1/2] is not
merged, which I think is not a problem, it is safe for both go through
their subsystem separately.

Thanks,
 Enric

 drivers/mfd/cros_ec_dev.c                   | 3 ++-
 drivers/platform/chrome/cros_usbpd_logger.c | 4 ++--
 2 files changed, 4 insertions(+), 3 deletions(-)

Comments

Enric Balletbo i Serra April 3, 2019, 2:03 p.m. UTC | #1
On 3/4/19 15:54, Enric Balletbo i Serra wrote:
> Add the cros-usbpd-logger driver for logging event data for the USB PD
> charger available in the Embedded Controller on ChromeOS systems. The
> logging feature is logically separate functionality from charge manager,
> hence is instantiated as a different driver.
> 
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> ---
> Lee, this is send as separate patch because touches the MFD subsystem,
> apart from that the driver won't be instantiated if [1/2] is not
> merged, which I think is not a problem, it is safe for both go through
> their subsystem separately.
> 
> Thanks,
>  Enric
> 
>  drivers/mfd/cros_ec_dev.c                   | 3 ++-
>  drivers/platform/chrome/cros_usbpd_logger.c | 4 ++--

Uggh, sending a v2, sorry for the noise.

>  2 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c
> index 0638a0d82d97..3e33fa5b8657 100644
> --- a/drivers/mfd/cros_ec_dev.c
> +++ b/drivers/mfd/cros_ec_dev.c
> @@ -612,7 +612,8 @@ static const struct mfd_cell cros_ec_rtc_cells[] = {
>  };
>  
>  static const struct mfd_cell cros_usbpd_charger_cells[] = {
> -	{ .name = "cros-usbpd-charger" }
> +	{ .name = "cros-usbpd-charger" },
> +	{ .name = "cros-usbpd-logger" },
>  };
>  
>  static const struct mfd_cell cros_ec_platform_cells[] = {
> diff --git a/drivers/platform/chrome/cros_usbpd_logger.c b/drivers/platform/chrome/cros_usbpd_logger.c
> index 2091ad7c2afa..eb27078aae47 100644
> --- a/drivers/platform/chrome/cros_usbpd_logger.c
> +++ b/drivers/platform/chrome/cros_usbpd_logger.c
> @@ -136,10 +136,10 @@ static void cros_usbpd_print_log_entry(struct ec_response_pd_log *r,
>  		break;
>  	case PD_EVENT_VIDEO_CODEC:
>  		minfo = (struct mcdp_info *)r->payload;
> -		len += append_str(buf, len, "HDMI info: family:%04x chipid:%04x"
> +		len += append_str(buf, len, "HDMI info: family:%04x chipid:%04x ",
>  				  MCDP_FAMILY(minfo->family),
>  				  MCDP_CHIPID(minfo->chipid));
> -		len += append_str(buf, len, " irom:%d.%d.%d fw:%d.%d.%d",
> +		len += append_str(buf, len, "irom:%d.%d.%d fw:%d.%d.%d",
>  				  minfo->irom.major, minfo->irom.minor,
>  				  minfo->irom.build, minfo->fw.major,
>  				  minfo->fw.minor, minfo->fw.build);
>

Patch
diff mbox series

diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c
index 0638a0d82d97..3e33fa5b8657 100644
--- a/drivers/mfd/cros_ec_dev.c
+++ b/drivers/mfd/cros_ec_dev.c
@@ -612,7 +612,8 @@  static const struct mfd_cell cros_ec_rtc_cells[] = {
 };
 
 static const struct mfd_cell cros_usbpd_charger_cells[] = {
-	{ .name = "cros-usbpd-charger" }
+	{ .name = "cros-usbpd-charger" },
+	{ .name = "cros-usbpd-logger" },
 };
 
 static const struct mfd_cell cros_ec_platform_cells[] = {
diff --git a/drivers/platform/chrome/cros_usbpd_logger.c b/drivers/platform/chrome/cros_usbpd_logger.c
index 2091ad7c2afa..eb27078aae47 100644
--- a/drivers/platform/chrome/cros_usbpd_logger.c
+++ b/drivers/platform/chrome/cros_usbpd_logger.c
@@ -136,10 +136,10 @@  static void cros_usbpd_print_log_entry(struct ec_response_pd_log *r,
 		break;
 	case PD_EVENT_VIDEO_CODEC:
 		minfo = (struct mcdp_info *)r->payload;
-		len += append_str(buf, len, "HDMI info: family:%04x chipid:%04x"
+		len += append_str(buf, len, "HDMI info: family:%04x chipid:%04x ",
 				  MCDP_FAMILY(minfo->family),
 				  MCDP_CHIPID(minfo->chipid));
-		len += append_str(buf, len, " irom:%d.%d.%d fw:%d.%d.%d",
+		len += append_str(buf, len, "irom:%d.%d.%d fw:%d.%d.%d",
 				  minfo->irom.major, minfo->irom.minor,
 				  minfo->irom.build, minfo->fw.major,
 				  minfo->fw.minor, minfo->fw.build);