From: Qian Cai <cai@lca.pw>
To: akpm@linux-foundation.org
Cc: cl@linux.com, penberg@kernel.org, rientjes@google.com,
iamjoonsoo.kim@lge.com, tj@kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, Qian Cai <cai@lca.pw>
Subject: [PATCH] slab: fix a crash by reading /proc/slab_allocators
Date: Sat, 6 Apr 2019 18:59:01 -0400 [thread overview]
Message-ID: <20190406225901.35465-1-cai@lca.pw> (raw)
The commit 510ded33e075 ("slab: implement slab_root_caches list")
changes the name of the list node within "struct kmem_cache" from
"list" to "root_caches_node", but leaks_show() still use the "list"
which causes a crash when reading /proc/slab_allocators.
BUG: unable to handle kernel NULL pointer dereference at
00000000000000aa
PGD 0 P4D 0
Oops: 0000 [#1] SMP DEBUG_PAGEALLOC PTI
CPU: 3 PID: 5925 Comm: ldd Not tainted 5.1.0-rc3-mm1+ #6
RIP: 0010:__lock_acquire.isra.14+0x4b4/0xa50
Call Trace:
<IRQ>
lock_acquire+0xa3/0x180
_raw_spin_lock+0x2f/0x40
do_drain+0x61/0xc0
flush_smp_call_function_queue+0x3a/0x110
generic_smp_call_function_single_interrupt+0x13/0x2b
smp_call_function_interrupt+0x66/0x1a0
call_function_interrupt+0xf/0x20
</IRQ>
RIP: 0010:__tlb_remove_page_size+0x8c/0xe0
zap_pte_range+0x39f/0xc80
unmap_page_range+0x38a/0x550
unmap_single_vma+0x7d/0xe0
unmap_vmas+0xae/0xd0
exit_mmap+0xae/0x190
mmput+0x7a/0x150
do_exit+0x2d9/0xd40
do_group_exit+0x41/0xd0
__x64_sys_exit_group+0x18/0x20
do_syscall_64+0x68/0x381
entry_SYSCALL_64_after_hwframe+0x44/0xa9
Fixes: 510ded33e075 ("slab: implement slab_root_caches list")
Signed-off-by: Qian Cai <cai@lca.pw>
---
mm/slab.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/mm/slab.c b/mm/slab.c
index 46a6e084222b..9142ee992493 100644
--- a/mm/slab.c
+++ b/mm/slab.c
@@ -4307,7 +4307,8 @@ static void show_symbol(struct seq_file *m, unsigned long address)
static int leaks_show(struct seq_file *m, void *p)
{
- struct kmem_cache *cachep = list_entry(p, struct kmem_cache, list);
+ struct kmem_cache *cachep = list_entry(p, struct kmem_cache,
+ root_caches_node);
struct page *page;
struct kmem_cache_node *n;
const char *name;
--
2.17.2 (Apple Git-113)
next reply other threads:[~2019-04-06 22:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-06 22:59 Qian Cai [this message]
2019-04-08 1:59 ` [PATCH] slab: fix a crash by reading /proc/slab_allocators Tobin C. Harding
2019-04-08 2:18 ` Qian Cai
2019-04-08 5:03 ` Tobin C. Harding
2019-04-08 5:35 ` Linus Torvalds
2019-04-08 13:17 ` Qian Cai
2019-04-08 15:15 ` Christopher Lameter
2019-04-08 23:41 ` Tobin C. Harding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190406225901.35465-1-cai@lca.pw \
--to=cai@lca.pw \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).