From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
To: lee.jones@linaro.org
Cc: gwendal@chromium.org, bleung@chromium.org,
linux-kernel@vger.kernel.org, groeck@chromium.org,
kernel@collabora.com, dtor@chromium.org,
rushikesh.s.kadam@intel.com,
Vincent Palatin <vpalatin@chromium.org>
Subject: [PATCH v3 3/4] mfd: cros_ec: instantiate properly CrOS FP MCU device
Date: Mon, 8 Apr 2019 11:41:40 +0200 [thread overview]
Message-ID: <20190408094141.27858-4-enric.balletbo@collabora.com> (raw)
In-Reply-To: <20190408094141.27858-1-enric.balletbo@collabora.com>
Support Fingerprint MCU as a special of CrOS EC devices. The current FP
MCU uses the same EC SPI protocol v3 as other CrOS EC devices on a SPI
bus.
When a MCU has fingerprint support (aka EC_FEATURE_FINGERPRINT), it is
instantiated as a special CrOS EC device with device name 'cros_fp'. So
regardless of the probing order between the actual cros_ec and cros_fp,
the userspace and other kernel drivers should not confuse them.
Signed-off-by: Vincent Palatin <vpalatin@chromium.org>
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
---
Changes in v3: None
Changes in v2: None
drivers/mfd/cros_ec_dev.c | 10 ++++++++++
include/linux/mfd/cros_ec.h | 1 +
2 files changed, 11 insertions(+)
diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c
index 1daccd4e05a3..79746e817cdb 100644
--- a/drivers/mfd/cros_ec_dev.c
+++ b/drivers/mfd/cros_ec_dev.c
@@ -636,6 +636,16 @@ static int ec_device_probe(struct platform_device *pdev)
device_initialize(&ec->class_dev);
cdev_init(&ec->cdev, &fops);
+ /* Check whether this is actually a Fingerprint MCU rather than an EC */
+ if (cros_ec_check_features(ec, EC_FEATURE_FINGERPRINT)) {
+ dev_info(dev, "CrOS Fingerprint MCU detected.\n");
+ /*
+ * Help userspace differentiating ECs from FP MCU,
+ * regardless of the probing order.
+ */
+ ec_platform->ec_name = CROS_EC_DEV_FP_NAME;
+ }
+
/*
* Check whether this is actually an Integrated Sensor Hub (ISH)
* rather than an EC.
diff --git a/include/linux/mfd/cros_ec.h b/include/linux/mfd/cros_ec.h
index ce50628aa5e7..b393bd4e4b73 100644
--- a/include/linux/mfd/cros_ec.h
+++ b/include/linux/mfd/cros_ec.h
@@ -23,6 +23,7 @@
#include <linux/mutex.h>
#define CROS_EC_DEV_NAME "cros_ec"
+#define CROS_EC_DEV_FP_NAME "cros_fp"
#define CROS_EC_DEV_ISH_NAME "cros_ish"
#define CROS_EC_DEV_PD_NAME "cros_pd"
--
2.20.1
next prev parent reply other threads:[~2019-04-08 9:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 9:41 [PATCH v3 0/4] mfd: cros_ec: Instantiate CrOS FP, TP and ISH devices Enric Balletbo i Serra
2019-04-08 9:41 ` [PATCH v3 1/4] mfd: cros_ec: Update the EC feature codes Enric Balletbo i Serra
2019-05-08 11:56 ` Lee Jones
2019-04-08 9:41 ` [PATCH v3 2/4] mfd: cros_ec: instantiate properly CrOS ISH MCU device Enric Balletbo i Serra
2019-04-08 10:28 ` Andy Shevchenko
2019-04-08 10:39 ` Enric Balletbo i Serra
2019-04-08 12:39 ` Andy Shevchenko
2019-04-08 9:41 ` Enric Balletbo i Serra [this message]
2019-04-08 18:19 ` [PATCH v3 3/4] mfd: cros_ec: instantiate properly CrOS FP " Benson Leung
2019-04-08 9:41 ` [PATCH v3 4/4] mfd: cros_ec: instantiate properly CrOS Touchpad " Enric Balletbo i Serra
2019-04-08 18:19 ` Benson Leung
2019-05-08 8:14 ` [PATCH v3 0/4] mfd: cros_ec: Instantiate CrOS FP, TP and ISH devices Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190408094141.27858-4-enric.balletbo@collabora.com \
--to=enric.balletbo@collabora.com \
--cc=bleung@chromium.org \
--cc=dtor@chromium.org \
--cc=groeck@chromium.org \
--cc=gwendal@chromium.org \
--cc=kernel@collabora.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rushikesh.s.kadam@intel.com \
--cc=vpalatin@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).