From: Nicholas Mc Guire <hofrat@osadl.org>
To: Russell King <linux@armlinux.org.uk>
Cc: Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Mark Brown <broonie@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Tony Lindgren <tony@atomide.com>,
Mike Rapoport <rppt@linux.vnet.ibm.com>,
Janusz Krzysztofik <jmkrzyszt@gmail.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Nicholas Mc Guire <hofrat@osadl.org>
Subject: [PATCH 3/4 RFC] ARM: imx legacy: wrap complex macro in ()
Date: Sat, 13 Apr 2019 09:23:32 +0200 [thread overview]
Message-ID: <1555140213-1081-4-git-send-email-hofrat@osadl.org> (raw)
In-Reply-To: <1555140213-1081-1-git-send-email-hofrat@osadl.org>
Checkpatch suggests to place a parenthesis around this complex macro.
Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
---
Problem reported by checkpatch
I'm actually not sure this really is improving readability but by
default checkpatch gets it right so...
Patch was compile-tested with: imx_v4_v5_defconfig (implies
CONFIG_MACH_MX27ADS=y)
Patch is against 5.1-rc4 (localversion-next is 20190412)
arch/arm/mach-imx/mach-mx27ads.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-imx/mach-mx27ads.c b/arch/arm/mach-imx/mach-mx27ads.c
index 49ac898..c83fdd3 100644
--- a/arch/arm/mach-imx/mach-mx27ads.c
+++ b/arch/arm/mach-imx/mach-mx27ads.c
@@ -42,8 +42,8 @@
* Base address of PBC controller, CS4
*/
#define PBC_BASE_ADDRESS 0xf4300000
-#define PBC_REG_ADDR(offset) (void __force __iomem *) \
- (PBC_BASE_ADDRESS + (offset))
+#define PBC_REG_ADDR(offset) ((void __force __iomem *) \
+ (PBC_BASE_ADDRESS + (offset)))
/* When the PBC address connection is fixed in h/w, defined as 1 */
#define PBC_ADDR_SH 0
--
2.1.4
next prev parent reply other threads:[~2019-04-13 7:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-13 7:23 [PATCH 0/4] ARM: imx legacy: cleanups Nicholas Mc Guire
2019-04-13 7:23 ` [PATCH 1/4 RFC] ARM: imx legacy: warn on failed allocation Nicholas Mc Guire
2019-04-13 7:23 ` [PATCH 2/4] ARM: imx legacy: declare unsigned int rather than unsigned Nicholas Mc Guire
2019-04-13 7:23 ` Nicholas Mc Guire [this message]
2019-04-13 7:23 ` [PATCH 4/4] ARM: imx legacy: add an SPDX license identifier Nicholas Mc Guire
2019-04-13 14:11 ` Fabio Estevam
2019-04-13 23:54 ` Nicholas Mc Guire
-- strict thread matches above, loose matches on Subject: below --
2019-04-13 7:14 [PATCH 0/4] ARM: imx legacy: cleanups Nicholas Mc Guire
2019-04-13 7:14 ` [PATCH 3/4 RFC] ARM: imx legacy: wrap complex macro in () Nicholas Mc Guire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1555140213-1081-4-git-send-email-hofrat@osadl.org \
--to=hofrat@osadl.org \
--cc=broonie@kernel.org \
--cc=festevam@gmail.com \
--cc=jmkrzyszt@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=rppt@linux.vnet.ibm.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).