[v2,01/36] coresight: Fix freeing up the coresight connections
diff mbox series

Message ID 1555344260-12375-2-git-send-email-suzuki.poulose@arm.com
State Superseded
Headers show
  • coresight: Support for ACPI bindings
Related show

Commit Message

Suzuki Kuruppassery Poulose April 15, 2019, 4:03 p.m. UTC
With commit c2c729415b2d2132 ("coresight: platform: Cleanup coresight
connection handling"), we switched to re-using coresight_connections
for the coresight_device. However, that introduced a mismatch in the
alloc/free of the connections. The allocation is made using devm_*,
while we use kfree() to release the memory when a device is released
(even though we don't support this at the moment). Fix this by leaving
it to the automatic freeing of the memory.

Fixes: c2c729415b2d2132 ("coresight: platform: Cleanup coresight connection handling")
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
 drivers/hwtracing/coresight/coresight.c | 1 -
 1 file changed, 1 deletion(-)

diff mbox series

diff --git a/drivers/hwtracing/coresight/coresight.c b/drivers/hwtracing/coresight/coresight.c
index 29cef89..55204dd 100644
--- a/drivers/hwtracing/coresight/coresight.c
+++ b/drivers/hwtracing/coresight/coresight.c
@@ -973,7 +973,6 @@  static void coresight_device_release(struct device *dev)
 	struct coresight_device *csdev = to_coresight_device(dev);
-	kfree(csdev->conns);