[v3,4/4] DT: arm: exynos4412: add event data type which is monitored
diff mbox series

Message ID 1555681688-19643-5-git-send-email-l.luba@partner.samsung.com
State New, archived
Headers show
Series
  • Exynos Performance Monitoring Counters enhancements
Related show

Commit Message

Lukasz Luba April 19, 2019, 1:48 p.m. UTC
The patch adds new field in the PPMU event which shows explicitly
what kind of data the event is monitoring. It is possible to change it
using defined values in exynos_ppmu.h file.

Signed-off-by: Lukasz Luba <l.luba@partner.samsung.com>
---
 arch/arm/boot/dts/exynos4412-ppmu-common.dtsi | 10 ++++++++++
 1 file changed, 10 insertions(+)

Comments

Chanwoo Choi April 30, 2019, 6:10 a.m. UTC | #1
Hi,

On 19. 4. 19. 오후 10:48, Lukasz Luba wrote:
> The patch adds new field in the PPMU event which shows explicitly
> what kind of data the event is monitoring. It is possible to change it
> using defined values in exynos_ppmu.h file.
> 
> Signed-off-by: Lukasz Luba <l.luba@partner.samsung.com>
> ---
>  arch/arm/boot/dts/exynos4412-ppmu-common.dtsi | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/exynos4412-ppmu-common.dtsi b/arch/arm/boot/dts/exynos4412-ppmu-common.dtsi
> index 3a3b2fa..549faba 100644
> --- a/arch/arm/boot/dts/exynos4412-ppmu-common.dtsi
> +++ b/arch/arm/boot/dts/exynos4412-ppmu-common.dtsi
> @@ -6,12 +6,16 @@
>   * Author: Chanwoo Choi <cw00.choi@samsung.com>
>   */
>  
> +#include <dt-bindings/pmu/exynos_ppmu.h>
> +
>  &ppmu_dmc0 {
>         status = "okay";
>  
>         events {
>  	       ppmu_dmc0_3: ppmu-event3-dmc0 {
>  		       event-name = "ppmu-event3-dmc0";
> +		       event-data-type = <(PPMU_RO_DATA_CNT |
> +					   PPMU_WO_DATA_CNT)>;
>  	       };
>         };
>  };
> @@ -22,6 +26,8 @@
>         events {
>  	       ppmu_dmc1_3: ppmu-event3-dmc1 {
>  		       event-name = "ppmu-event3-dmc1";
> +		       event-data-type = <(PPMU_RO_DATA_CNT |
> +					   PPMU_WO_DATA_CNT)>;
>  	       };
>         };
>  };
> @@ -32,6 +38,8 @@
>         events {
>  	       ppmu_leftbus_3: ppmu-event3-leftbus {
>  		       event-name = "ppmu-event3-leftbus";
> +		       event-data-type = <(PPMU_RO_DATA_CNT |
> +					   PPMU_WO_DATA_CNT)>;
>  	       };
>         };
>  };
> @@ -42,6 +50,8 @@
>         events {
>  	       ppmu_rightbus_3: ppmu-event3-rightbus {
>  		       event-name = "ppmu-event3-rightbus";
> +		       event-data-type = <(PPMU_RO_DATA_CNT |
> +					   PPMU_WO_DATA_CNT)>;
>  	       };
>         };
>  };
> 

Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
Lukasz Luba April 30, 2019, 9:24 p.m. UTC | #2
On 4/30/19 8:10 AM, Chanwoo Choi wrote:
> Hi,
> 
> On 19. 4. 19. 오후 10:48, Lukasz Luba wrote:
>> The patch adds new field in the PPMU event which shows explicitly
>> what kind of data the event is monitoring. It is possible to change it
>> using defined values in exynos_ppmu.h file.
>>
>> Signed-off-by: Lukasz Luba <l.luba@partner.samsung.com>
>> ---
>>   arch/arm/boot/dts/exynos4412-ppmu-common.dtsi | 10 ++++++++++
>>   1 file changed, 10 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos4412-ppmu-common.dtsi b/arch/arm/boot/dts/exynos4412-ppmu-common.dtsi
>> index 3a3b2fa..549faba 100644
>> --- a/arch/arm/boot/dts/exynos4412-ppmu-common.dtsi
>> +++ b/arch/arm/boot/dts/exynos4412-ppmu-common.dtsi
>> @@ -6,12 +6,16 @@
>>    * Author: Chanwoo Choi <cw00.choi@samsung.com>
>>    */
>>   
>> +#include <dt-bindings/pmu/exynos_ppmu.h>
>> +
>>   &ppmu_dmc0 {
>>          status = "okay";
>>   
>>          events {
>>   	       ppmu_dmc0_3: ppmu-event3-dmc0 {
>>   		       event-name = "ppmu-event3-dmc0";
>> +		       event-data-type = <(PPMU_RO_DATA_CNT |
>> +					   PPMU_WO_DATA_CNT)>;
>>   	       };
>>          };
>>   };
>> @@ -22,6 +26,8 @@
>>          events {
>>   	       ppmu_dmc1_3: ppmu-event3-dmc1 {
>>   		       event-name = "ppmu-event3-dmc1";
>> +		       event-data-type = <(PPMU_RO_DATA_CNT |
>> +					   PPMU_WO_DATA_CNT)>;
>>   	       };
>>          };
>>   };
>> @@ -32,6 +38,8 @@
>>          events {
>>   	       ppmu_leftbus_3: ppmu-event3-leftbus {
>>   		       event-name = "ppmu-event3-leftbus";
>> +		       event-data-type = <(PPMU_RO_DATA_CNT |
>> +					   PPMU_WO_DATA_CNT)>;
>>   	       };
>>          };
>>   };
>> @@ -42,6 +50,8 @@
>>          events {
>>   	       ppmu_rightbus_3: ppmu-event3-rightbus {
>>   		       event-name = "ppmu-event3-rightbus";
>> +		       event-data-type = <(PPMU_RO_DATA_CNT |
>> +					   PPMU_WO_DATA_CNT)>;
>>   	       };
>>          };
>>   };
>>
> 
> Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
Thank you, added to the patch.

Regards,
Lukasz
> 
>

Patch
diff mbox series

diff --git a/arch/arm/boot/dts/exynos4412-ppmu-common.dtsi b/arch/arm/boot/dts/exynos4412-ppmu-common.dtsi
index 3a3b2fa..549faba 100644
--- a/arch/arm/boot/dts/exynos4412-ppmu-common.dtsi
+++ b/arch/arm/boot/dts/exynos4412-ppmu-common.dtsi
@@ -6,12 +6,16 @@ 
  * Author: Chanwoo Choi <cw00.choi@samsung.com>
  */
 
+#include <dt-bindings/pmu/exynos_ppmu.h>
+
 &ppmu_dmc0 {
        status = "okay";
 
        events {
 	       ppmu_dmc0_3: ppmu-event3-dmc0 {
 		       event-name = "ppmu-event3-dmc0";
+		       event-data-type = <(PPMU_RO_DATA_CNT |
+					   PPMU_WO_DATA_CNT)>;
 	       };
        };
 };
@@ -22,6 +26,8 @@ 
        events {
 	       ppmu_dmc1_3: ppmu-event3-dmc1 {
 		       event-name = "ppmu-event3-dmc1";
+		       event-data-type = <(PPMU_RO_DATA_CNT |
+					   PPMU_WO_DATA_CNT)>;
 	       };
        };
 };
@@ -32,6 +38,8 @@ 
        events {
 	       ppmu_leftbus_3: ppmu-event3-leftbus {
 		       event-name = "ppmu-event3-leftbus";
+		       event-data-type = <(PPMU_RO_DATA_CNT |
+					   PPMU_WO_DATA_CNT)>;
 	       };
        };
 };
@@ -42,6 +50,8 @@ 
        events {
 	       ppmu_rightbus_3: ppmu-event3-rightbus {
 		       event-name = "ppmu-event3-rightbus";
+		       event-data-type = <(PPMU_RO_DATA_CNT |
+					   PPMU_WO_DATA_CNT)>;
 	       };
        };
 };