From: Jiada Wang <jiada_wang@mentor.com>
To: <rui.zhang@intel.com>, <edubezval@gmail.com>,
<daniel.lezcano@linaro.org>
Cc: <linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<jiada_wang@mentor.com>, <horms+renesas@verge.net.au>,
<niklas.soderlund+renesas@ragnatech.se>,
<geert+renesas@glider.be>, <sergei.shtylyov@cogentembedded.com>,
<marek.vasut+renesas@gmail.com>,
<kuninori.morimoto.gx@renesas.com>, <hien.dang.eb@renesas.com>,
<fabrizio.castro@bp.renesas.com>, <dien.pham.ry@renesas.com>,
<biju.das@bp.renesas.com>, <erosca@de.adit-jv.com>,
<george_davis@mentor.com>, <joshua_frkuska@mentor.com>
Subject: [PATCH v3 2/2] thermal: rcar_gen3_thermal: disable interrupt in .remove
Date: Tue, 23 Apr 2019 23:14:14 +0900 [thread overview]
Message-ID: <20190423141414.24264-3-jiada_wang@mentor.com> (raw)
In-Reply-To: <20190423141414.24264-1-jiada_wang@mentor.com>
Currently IRQ is remain enabled after .remove, later if device is probed,
IRQ is requested before .thermal_init, this may cause IRQ function be
called before device is initialized.
this patch by disable interrupt in .remove, to ensure irq function
only be called after device is fully initialized.
Signed-off-by: Jiada Wang <jiada_wang@mentor.com>
---
drivers/thermal/rcar_gen3_thermal.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/thermal/rcar_gen3_thermal.c b/drivers/thermal/rcar_gen3_thermal.c
index ebbaef5a3cf1..c63a86d3dac6 100644
--- a/drivers/thermal/rcar_gen3_thermal.c
+++ b/drivers/thermal/rcar_gen3_thermal.c
@@ -309,6 +309,9 @@ MODULE_DEVICE_TABLE(of, rcar_gen3_thermal_dt_ids);
static int rcar_gen3_thermal_remove(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
+ struct rcar_gen3_thermal_priv *priv = dev_get_drvdata(dev);
+
+ rcar_thermal_irq_set(priv, false);
pm_runtime_put(dev);
pm_runtime_disable(dev);
--
2.19.2
next prev parent reply other threads:[~2019-04-23 14:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-23 14:14 [PATCH v3 0/2] thermal: rcar_gen3_thermal: fix IRQ issues Jiada Wang
2019-04-23 14:14 ` [PATCH v3 1/2] thermal: rcar_gen3_thermal: fix interrupt type Jiada Wang
2019-04-23 14:57 ` Eugeniu Rosca
2019-04-23 22:35 ` Daniel Lezcano
2019-04-23 14:14 ` Jiada Wang [this message]
2019-04-23 14:44 ` [PATCH v3 2/2] thermal: rcar_gen3_thermal: disable interrupt in .remove Sergei Shtylyov
2019-04-23 22:27 ` [PATCH v3 0/2] thermal: rcar_gen3_thermal: fix IRQ issues Eugeniu Rosca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190423141414.24264-3-jiada_wang@mentor.com \
--to=jiada_wang@mentor.com \
--cc=biju.das@bp.renesas.com \
--cc=daniel.lezcano@linaro.org \
--cc=dien.pham.ry@renesas.com \
--cc=edubezval@gmail.com \
--cc=erosca@de.adit-jv.com \
--cc=fabrizio.castro@bp.renesas.com \
--cc=geert+renesas@glider.be \
--cc=george_davis@mentor.com \
--cc=hien.dang.eb@renesas.com \
--cc=horms+renesas@verge.net.au \
--cc=joshua_frkuska@mentor.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=marek.vasut+renesas@gmail.com \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=rui.zhang@intel.com \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).