From: Jiada Wang <jiada_wang@mentor.com>
To: <rui.zhang@intel.com>, <edubezval@gmail.com>,
<daniel.lezcano@linaro.org>
Cc: <linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<jiada_wang@mentor.com>, <horms+renesas@verge.net.au>,
<niklas.soderlund+renesas@ragnatech.se>,
<geert+renesas@glider.be>, <sergei.shtylyov@cogentembedded.com>,
<marek.vasut+renesas@gmail.com>,
<kuninori.morimoto.gx@renesas.com>, <hien.dang.eb@renesas.com>,
<fabrizio.castro@bp.renesas.com>, <dien.pham.ry@renesas.com>,
<biju.das@bp.renesas.com>, <erosca@de.adit-jv.com>,
<george_davis@mentor.com>, <joshua_frkuska@mentor.com>
Subject: [PATCH v4 2/2] thermal: rcar_gen3_thermal: disable interrupt in .remove
Date: Wed, 24 Apr 2019 14:11:45 +0900 [thread overview]
Message-ID: <20190424051145.23072-3-jiada_wang@mentor.com> (raw)
In-Reply-To: <20190424051145.23072-1-jiada_wang@mentor.com>
Currently IRQ remains enabled after .remove, later if device is probed,
IRQ is requested before .thermal_init, this may cause IRQ function be
called before device is initialized.
this patch disables interrupt in .remove, to ensure irq function
only be called after device is fully initialized.
Signed-off-by: Jiada Wang <jiada_wang@mentor.com>
---
drivers/thermal/rcar_gen3_thermal.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/thermal/rcar_gen3_thermal.c b/drivers/thermal/rcar_gen3_thermal.c
index 065e16f53285..280230951dfe 100644
--- a/drivers/thermal/rcar_gen3_thermal.c
+++ b/drivers/thermal/rcar_gen3_thermal.c
@@ -307,6 +307,9 @@ MODULE_DEVICE_TABLE(of, rcar_gen3_thermal_dt_ids);
static int rcar_gen3_thermal_remove(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
+ struct rcar_gen3_thermal_priv *priv = dev_get_drvdata(dev);
+
+ rcar_thermal_irq_set(priv, false);
pm_runtime_put(dev);
pm_runtime_disable(dev);
--
2.19.2
next prev parent reply other threads:[~2019-04-24 5:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-24 5:11 [PATCH v4 0/2] thermal: rcar_gen3_thermal: fix IRQ issues Jiada Wang
2019-04-24 5:11 ` [PATCH v4 1/2] thermal: rcar_gen3_thermal: fix interrupt type Jiada Wang
2019-04-24 9:23 ` Simon Horman
2019-04-24 9:31 ` Daniel Lezcano
2019-04-24 12:28 ` Eugeniu Rosca
2019-04-24 5:11 ` Jiada Wang [this message]
2019-04-24 9:23 ` [PATCH v4 2/2] thermal: rcar_gen3_thermal: disable interrupt in .remove Simon Horman
2019-04-24 9:38 ` Daniel Lezcano
2019-04-24 12:31 ` Eugeniu Rosca
2019-04-24 6:51 ` [PATCH v4 0/2] thermal: rcar_gen3_thermal: fix IRQ issues Niklas Söderlund
2019-04-24 12:09 ` Eugeniu Rosca
2019-05-07 23:54 ` Niklas Söderlund
2019-05-10 10:42 ` Eugeniu Rosca
2019-05-10 11:36 ` Niklas Söderlund
2019-05-10 15:50 ` Eugeniu Rosca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190424051145.23072-3-jiada_wang@mentor.com \
--to=jiada_wang@mentor.com \
--cc=biju.das@bp.renesas.com \
--cc=daniel.lezcano@linaro.org \
--cc=dien.pham.ry@renesas.com \
--cc=edubezval@gmail.com \
--cc=erosca@de.adit-jv.com \
--cc=fabrizio.castro@bp.renesas.com \
--cc=geert+renesas@glider.be \
--cc=george_davis@mentor.com \
--cc=hien.dang.eb@renesas.com \
--cc=horms+renesas@verge.net.au \
--cc=joshua_frkuska@mentor.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=marek.vasut+renesas@gmail.com \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=rui.zhang@intel.com \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).