[2/2] x86/Kconfig: deprecate DISCONTIGMEM support for 32-bit
diff mbox series

Message ID 1556112252-9339-3-git-send-email-rppt@linux.ibm.com
State Accepted
Commit 2792107dc3af29ecc1a9b3dc5bc873dac4b61cd6
Headers show
Series
  • x86/Kconfig: deprecate DISCONTIGMEM support for 32-bit
Related show

Commit Message

Mike Rapoport April 24, 2019, 1:24 p.m. UTC
Mel Gorman says:
  32-bit NUMA systems should be non-existent in practice.  The last NUMA
  system I'm aware of that was both NUMA and 32-bit only died somewhere
  between 2004 and 2007. If someone is running a 64-bit capable system in
  32-bit mode with NUMA, they really are just punishing themselves for fun.

Mark DISCONTIGMEM broken for now and remove it in a couple of releases.

Suggested-by: Christoph Hellwig <hch@infradead.org>
Suggested-by: Mel Gorman <mgorman@techsingularity.net>
Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
---
 arch/x86/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Mel Gorman April 24, 2019, 2:20 p.m. UTC | #1
On Wed, Apr 24, 2019 at 04:24:12PM +0300, Mike Rapoport wrote:
> Mel Gorman says:
>   32-bit NUMA systems should be non-existent in practice.  The last NUMA
>   system I'm aware of that was both NUMA and 32-bit only died somewhere
>   between 2004 and 2007. If someone is running a 64-bit capable system in
>   32-bit mode with NUMA, they really are just punishing themselves for fun.
> 
> Mark DISCONTIGMEM broken for now and remove it in a couple of releases.
> 
> Suggested-by: Christoph Hellwig <hch@infradead.org>
> Suggested-by: Mel Gorman <mgorman@techsingularity.net>
> Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>

It was really Christoph that suggested marking it broken but I do agree
that it should be marked broken to see if anyone complains and if not,
there is no real reason to keep discontig available on x86.

Acked-by: Mel Gorman <mgorman@techsingularity.net>

Patch
diff mbox series

diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 5662a3e..bd6f93c 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -1606,8 +1606,9 @@  config ARCH_FLATMEM_ENABLE
 	depends on X86_32 && !NUMA
 
 config ARCH_DISCONTIGMEM_ENABLE
-	def_bool y
+	def_bool n
 	depends on NUMA && X86_32
+	depends on BROKEN
 
 config ARCH_SPARSEMEM_ENABLE
 	def_bool y