From: Petr Mladek <pmladek@suse.com>
To: Jiri Kosina <jikos@kernel.org>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Miroslav Benes <mbenes@suse.cz>
Cc: Joe Lawrence <joe.lawrence@redhat.com>,
Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>,
live-patching@vger.kernel.org, linux-kernel@vger.kernel.org,
Petr Mladek <pmladek@suse.com>
Subject: [PATCH v2 2/2] livepatch: Use static buffer for debugging messages under rq lock
Date: Tue, 30 Apr 2019 11:10:49 +0200 [thread overview]
Message-ID: <20190430091049.30413-3-pmladek@suse.com> (raw)
In-Reply-To: <20190430091049.30413-1-pmladek@suse.com>
klp_try_switch_task() is called under klp_mutex. The buffer for
debugging messages might be static.
Signed-off-by: Petr Mladek <pmladek@suse.com>
---
kernel/livepatch/transition.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/kernel/livepatch/transition.c b/kernel/livepatch/transition.c
index 8e0274075e75..d66086fd6d75 100644
--- a/kernel/livepatch/transition.c
+++ b/kernel/livepatch/transition.c
@@ -304,11 +304,11 @@ static int klp_check_stack(struct task_struct *task, char *err_buf)
*/
static bool klp_try_switch_task(struct task_struct *task)
{
+ static char err_buf[STACK_ERR_BUF_SIZE];
struct rq *rq;
struct rq_flags flags;
int ret;
bool success = false;
- char err_buf[STACK_ERR_BUF_SIZE];
err_buf[0] = '\0';
@@ -351,7 +351,6 @@ static bool klp_try_switch_task(struct task_struct *task)
pr_debug("%s", err_buf);
return success;
-
}
/*
--
2.16.4
next prev parent reply other threads:[~2019-04-30 9:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-30 9:10 [PATCH v2 0/2] livepatch: Clean up of reliable stacktrace warnings Petr Mladek
2019-04-30 9:10 ` [PATCH v2 1/2] livepatch: Remove duplicate warning about missing reliable stacktrace support Petr Mladek
2019-04-30 11:30 ` Miroslav Benes
2019-04-30 11:56 ` Kamalesh Babulal
2019-05-07 0:40 ` Josh Poimboeuf
2019-05-07 1:43 ` Josh Poimboeuf
2019-05-07 11:29 ` Petr Mladek
2019-05-07 12:03 ` Josh Poimboeuf
2019-05-07 14:28 ` Petr Mladek
2019-05-07 21:24 ` Josh Poimboeuf
2019-05-09 7:24 ` Miroslav Benes
2019-05-13 10:43 ` Petr Mladek
2019-05-13 16:46 ` Josh Poimboeuf
2019-05-07 8:58 ` Miroslav Benes
2019-04-30 9:10 ` Petr Mladek [this message]
2019-04-30 11:32 ` [PATCH v2 2/2] livepatch: Use static buffer for debugging messages under rq lock Miroslav Benes
2019-04-30 12:30 ` Kamalesh Babulal
2019-05-07 0:43 ` Josh Poimboeuf
2019-05-07 11:50 ` Petr Mladek
2019-05-07 13:19 ` Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190430091049.30413-3-pmladek@suse.com \
--to=pmladek@suse.com \
--cc=jikos@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=jpoimboe@redhat.com \
--cc=kamalesh@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).