From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: "Rafael J . Wysocki" <rjw@rjwysocki.net>, linux-acpi@vger.kernel.org
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Robert Moore <robert.moore@intel.com>,
linux-kernel@vger.kernel.org, Len Brown <lenb@kernel.org>,
Erik Schmauss <erik.schmauss@intel.com>,
devel@acpica.org
Subject: [PATCH v2] tools/power/acpi: exclude tools/* from .gitignore pattern
Date: Wed, 1 May 2019 22:53:05 +0900 [thread overview]
Message-ID: <1556718785-4417-1-git-send-email-yamada.masahiro@socionext.com> (raw)
tools/power/acpi/.gitignore has the following entries:
acpidbg
acpidump
ec
They are intended to ignore the following build artifacts:
tools/power/acpi/acpidbg
tools/power/acpi/acpidump
tools/power/acpi/ec
However, those .gitignore entries are effective not only for the
current directory, but also for any sub-directories.
So, from the point of .gitignore grammar, the following check-in
directories are also considered to be ignored:
tools/power/acpi/tools/acpidbg
tools/power/acpi/tools/acpidump
tools/power/acpi/tools/ec
As the manual gitignore(5) says "Files already tracked by Git are not
affected", this is not a problem as far as Git is concerned.
However, Git is not the only program that parses .gitignore because
.gitignore is useful to distinguish build artifacts from source files.
For example, tar(1) supports the --exclude-vcs-ignore option. As of
writing, this option does not work perfectly, but it intends to create
a tarball excluding files specified by .gitignore.
So, I believe it is better to fix this issue.
You can fix it by prefixing the pattern with a slash; the leading slash
means the specified pattern is relative to the current directory.
I also prefixed the "include" consistently. IMHO, it is safer when you
intend to ignore specific files or directories.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
Changes in v2:
- Add more information to the commit log to clarify my main motivation
tools/power/acpi/.gitignore | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/tools/power/acpi/.gitignore b/tools/power/acpi/.gitignore
index cba3d99..f698a0e 100644
--- a/tools/power/acpi/.gitignore
+++ b/tools/power/acpi/.gitignore
@@ -1,4 +1,4 @@
-acpidbg
-acpidump
-ec
-include
+/acpidbg
+/acpidump
+/ec
+/include/
--
2.7.4
next reply other threads:[~2019-05-01 13:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-01 13:53 Masahiro Yamada [this message]
2019-05-31 9:24 ` [PATCH v2] tools/power/acpi: exclude tools/* from .gitignore pattern Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1556718785-4417-1-git-send-email-yamada.masahiro@socionext.com \
--to=yamada.masahiro@socionext.com \
--cc=devel@acpica.org \
--cc=erik.schmauss@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rjw@rjwysocki.net \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).