From: Michael Ellerman <mpe@ellerman.id.au>
To: linux-edac@vger.kernel.org
Cc: morbidrsa@gmail.com, bp@alien8.de, mchehab@kernel.org,
james.morse@arm.com, linux-kernel@vger.kernel.org,
linuxppc-dev@ozlabs.org
Subject: [PATCH] EDAC, mpc85xx: Prevent building as a module
Date: Fri, 3 May 2019 00:19:41 +1000 [thread overview]
Message-ID: <20190502141941.12927-1-mpe@ellerman.id.au> (raw)
The mpc85xx EDAC code can be configured as a module but then fails to
build because it uses two unexported symbols:
ERROR: ".pci_find_hose_for_OF_device" [drivers/edac/mpc85xx_edac_mod.ko] undefined!
ERROR: ".early_find_capability" [drivers/edac/mpc85xx_edac_mod.ko] undefined!
We don't want to export those symbols just for this driver, so make
the driver only configurable as a built-in.
This seems to have been broken since at least commit c92132f59806
("edac/85xx: Add PCIe error interrupt edac support") (Nov 2013).
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
---
drivers/edac/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/edac/Kconfig b/drivers/edac/Kconfig
index 47eb4d13ed5f..6317519f9d88 100644
--- a/drivers/edac/Kconfig
+++ b/drivers/edac/Kconfig
@@ -263,7 +263,7 @@ config EDAC_PND2
micro-server but may appear on others in the future.
config EDAC_MPC85XX
- tristate "Freescale MPC83xx / MPC85xx"
+ bool "Freescale MPC83xx / MPC85xx"
depends on FSL_SOC
help
Support for error detection and correction on the Freescale
--
2.20.1
next reply other threads:[~2019-05-02 14:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-02 14:19 Michael Ellerman [this message]
2019-05-06 6:50 ` [PATCH] EDAC, mpc85xx: Prevent building as a module Johannes Thumshirn
2019-05-08 10:12 ` Borislav Petkov
2019-05-09 14:52 ` Michael Ellerman
2019-05-09 14:55 ` Borislav Petkov
2019-05-09 18:02 ` Borislav Petkov
2019-05-10 10:50 ` Michael Ellerman
2019-05-10 14:13 ` Borislav Petkov
2019-05-10 18:25 ` Borislav Petkov
2019-05-14 6:50 ` Michael Ellerman
2019-05-14 8:31 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190502141941.12927-1-mpe@ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=bp@alien8.de \
--cc=james.morse@arm.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mchehab@kernel.org \
--cc=morbidrsa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).