From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Daniel Vetter <daniel.vetter@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
Dmitry Vyukov <dvyukov@google.com>,
"Paul E. McKenney" <paulmck@linux.ibm.com>,
Valdis Kletnieks <valdis.kletnieks@vt.edu>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
"Liu, Chuansheng" <chuansheng.liu@intel.com>
Subject: [PATCH] RFC: hung_task: taint kernel
Date: Thu, 2 May 2019 22:46:48 +0200 [thread overview]
Message-ID: <20190502204648.5537-1-daniel.vetter@ffwll.ch> (raw)
In-Reply-To: <20190502194208.3535-1-daniel.vetter@ffwll.ch>
There's the hung_task_panic sysctl, but that's a bit an extreme measure.
As a fallback taint at least the machine.
Our CI uses this to decide when a reboot is necessary, plus to figure
out whether the kernel is still happy.
v2: Works much better when I put the else { add_taint() } at the right
place.
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: Dmitry Vyukov <dvyukov@google.com>
Cc: "Paul E. McKenney" <paulmck@linux.ibm.com>
Cc: Valdis Kletnieks <valdis.kletnieks@vt.edu>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Vitaly Kuznetsov <vkuznets@redhat.com>
Cc: "Liu, Chuansheng" <chuansheng.liu@intel.com>
---
kernel/hung_task.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/kernel/hung_task.c b/kernel/hung_task.c
index f108a95882c6..d90d98f53ccb 100644
--- a/kernel/hung_task.c
+++ b/kernel/hung_task.c
@@ -117,6 +117,8 @@ static void check_hung_task(struct task_struct *t, unsigned long timeout)
console_verbose();
hung_task_show_lock = true;
hung_task_call_panic = true;
+ } else {
+ add_taint(TAINT_WARN, LOCKDEP_STILL_OK);
}
/*
--
2.20.1
next prev parent reply other threads:[~2019-05-02 20:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-02 19:42 [PATCH 1/2] RFC: hung_task: taint kernel Daniel Vetter
2019-05-02 19:42 ` [PATCH 2/2] RFC: soft/hardlookup: " Daniel Vetter
2019-05-03 0:00 ` Laurence Oberman
2019-05-09 9:24 ` Sergey Senozhatsky
2019-05-09 10:16 ` Daniel Vetter
2019-05-02 20:46 ` Daniel Vetter [this message]
2019-05-03 0:47 ` [PATCH] RFC: hung_task: " Tetsuo Handa
2019-05-03 8:51 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190502204648.5537-1-daniel.vetter@ffwll.ch \
--to=daniel.vetter@ffwll.ch \
--cc=akpm@linux-foundation.org \
--cc=chuansheng.liu@intel.com \
--cc=daniel.vetter@intel.com \
--cc=dvyukov@google.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.ibm.com \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=valdis.kletnieks@vt.edu \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).