From: Qian Cai <cai@lca.pw>
To: akpm@linux-foundation.org
Cc: cl@linux.com, penberg@kernel.org, rientjes@google.com,
iamjoonsoo.kim@lge.com, catalin.marinas@arm.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Qian Cai <cai@lca.pw>
Subject: [PATCH] slab: skip kmemleak_object in leaks_show()
Date: Tue, 7 May 2019 20:38:38 -0400 [thread overview]
Message-ID: <20190508003838.62264-1-cai@lca.pw> (raw)
Running tests on a debug kernel will usually generate a large number of
kmemleak objects.
# grep kmemleak /proc/slabinfo
kmemleak_object 2243606 3436210 ...
As the result, reading /proc/slab_allocators could easily loop forever
while processing the kmemleak_object cache and any additional freeing or
allocating objects will trigger a reprocessing. To make a situation
worse, soft-lockups could easily happen in this sitatuion which will
call printk() to allocate more kmemleak objects to guarantee a livelock.
Since kmemleak_object has a single call site (create_object()), there
isn't much new information compared with slabinfo. Just skip it.
Signed-off-by: Qian Cai <cai@lca.pw>
---
mm/slab.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/mm/slab.c b/mm/slab.c
index 20f318f4f56e..85d1d223f879 100644
--- a/mm/slab.c
+++ b/mm/slab.c
@@ -4285,6 +4285,15 @@ static int leaks_show(struct seq_file *m, void *p)
if (!(cachep->flags & SLAB_RED_ZONE))
return 0;
+ /*
+ * /proc/slabinfo has the same information, so skip kmemleak here due to
+ * a high volume and its RCU free could make cachep->store_user_clean
+ * dirty all the time.
+ */
+ if (IS_ENABLED(CONFIG_DEBUG_KMEMLEAK) &&
+ !strcmp("kmemleak_object", cachep->name))
+ return 0;
+
/*
* Set store_user_clean and start to grab stored user information
* for all objects on this cache. If some alloc/free requests comes
--
2.20.1 (Apple Git-117)
reply other threads:[~2019-05-08 0:39 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190508003838.62264-1-cai@lca.pw \
--to=cai@lca.pw \
--cc=akpm@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).