From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: tglx@linutronix.de
Cc: linux-kernel@vger.kernel.org,
Sugaya Taichi <sugaya.taichi@socionext.com>
Subject: [PATCH 04/15] clocksource/drivers/timer-milbeaut: Fix to enable one-shot timer
Date: Thu, 9 May 2019 13:10:37 +0200 [thread overview]
Message-ID: <20190509111048.11151-4-daniel.lezcano@linaro.org> (raw)
In-Reply-To: <20190509111048.11151-1-daniel.lezcano@linaro.org>
From: Sugaya Taichi <sugaya.taichi@socionext.com>
Fix mlb_set_oneshot_state() to enable one-shot timer.
The function should stop and start a timer, but "start" statement was
dropped. Kick the register to start one-shot timer.
Fixes: b58f28f306db ("clocksource/drivers/timer-milbeaut: Introduce timer for Milbeaut SoCs")
Signed-off-by: Sugaya Taichi <sugaya.taichi@socionext.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
drivers/clocksource/timer-milbeaut.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/clocksource/timer-milbeaut.c b/drivers/clocksource/timer-milbeaut.c
index f2019a88e3ee..9fd5d081fac4 100644
--- a/drivers/clocksource/timer-milbeaut.c
+++ b/drivers/clocksource/timer-milbeaut.c
@@ -79,6 +79,8 @@ static int mlb_set_state_oneshot(struct clock_event_device *clk)
struct timer_of *to = to_timer_of(clk);
u32 val = MLB_TMR_TMCSR_CSL_DIV2;
+ writel_relaxed(val, timer_of_base(to) + MLB_TMR_EVT_TMCSR_OFS);
+ val |= MLB_TMR_TMCSR_CNTE | MLB_TMR_TMCSR_TRG | MLB_TMR_TMCSR_INTE;
writel_relaxed(val, timer_of_base(to) + MLB_TMR_EVT_TMCSR_OFS);
return 0;
}
--
2.17.1
next prev parent reply other threads:[~2019-05-09 11:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-09 11:08 [GIT PULL] timer drivers for 5.2 Daniel Lezcano
2019-05-09 11:10 ` [PATCH 01/15] clocksource/drivers/sun4i: Add a compatible for suniv Daniel Lezcano
2019-05-09 11:10 ` [PATCH 02/15] clocksource/drivers/sp804: Add COMPILE_TEST to CONFIG_ARM_TIMER_SP804 Daniel Lezcano
2019-06-18 12:07 ` Helmut Grohne
2019-05-09 11:10 ` [PATCH 03/15] clocksource/drivers/tegra: Rework for compensation of suspend time Daniel Lezcano
2019-05-09 11:10 ` Daniel Lezcano [this message]
2019-05-09 11:10 ` [PATCH 05/15] clocksource/drivers/timer-milbeaut: Add shutdown function Daniel Lezcano
2019-05-09 11:10 ` [PATCH 06/15] clocksource/drivers/timer-milbeaut: Cleanup common register accesses Daniel Lezcano
2019-05-09 11:10 ` [PATCH 07/15] ARM: at91: move SoC specific definitions to SoC folder Daniel Lezcano
2019-05-09 11:10 ` [PATCH 08/15] clocksource/drivers/tcb_clksrc: Stop depending on atmel_tclib Daniel Lezcano
2019-05-09 11:10 ` [PATCH 09/15] clocksource/drivers/tcb_clksrc: Use tcb as sched_clock Daniel Lezcano
2019-05-09 11:10 ` [PATCH 10/15] ARM: at91: Implement clocksource selection Daniel Lezcano
2019-05-09 11:10 ` [PATCH 11/15] clocksource/drivers/tcb_clksrc: Move Kconfig option Daniel Lezcano
2019-05-09 11:10 ` [PATCH 12/15] clocksource/drivers/timer-atmel-pit: Rework " Daniel Lezcano
2019-05-09 11:10 ` [PATCH 13/15] clocksource/drivers/tcb_clksrc: Rename the file for consistency Daniel Lezcano
2019-05-09 11:10 ` [PATCH 14/15] clocksource/drivers/timer-atmel-tcb: Convert tc_clksrc_suspend|resume() to static Daniel Lezcano
2019-05-09 11:10 ` [PATCH 15/15] misc: atmel_tclib: Do not probe already used TCBs Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190509111048.11151-4-daniel.lezcano@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sugaya.taichi@socionext.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).