From: Borislav Petkov <bp@alien8.de>
To: Tony Luck <tony.luck@intel.com>
Cc: linux-edac <linux-edac@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 08/11] RAS/CEC: Rename count_threshold to action_threshold
Date: Thu, 9 May 2019 20:09:23 +0200 [thread overview]
Message-ID: <20190509180926.31932-9-bp@alien8.de> (raw)
In-Reply-To: <20190509180926.31932-1-bp@alien8.de>
From: Borislav Petkov <bp@suse.de>
... which is the better, more-fitting name anyway.
Tony:
- make action_threshold u64 due to debugfs accessors expecting u64.
- rename the remaining: s/count_threshold/action_threshold/g
Co-developed-by: Tony Luck <tony.luck@intel.com>
Signed-off-by: Tony Luck <tony.luck@intel.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: linux-edac <linux-edac@vger.kernel.org>
---
drivers/ras/cec.c | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/ras/cec.c b/drivers/ras/cec.c
index 2c92a70fa2f0..1cbc1ed82afe 100644
--- a/drivers/ras/cec.c
+++ b/drivers/ras/cec.c
@@ -37,9 +37,9 @@
* thus emulate an an LRU-like behavior when deleting elements to free up space
* in the page.
*
- * When an element reaches it's max count of count_threshold, we try to poison
- * it by assuming that errors triggered count_threshold times in a single page
- * are excessive and that page shouldn't be used anymore. count_threshold is
+ * When an element reaches it's max count of action_threshold, we try to poison
+ * it by assuming that errors triggered action_threshold times in a single page
+ * are excessive and that page shouldn't be used anymore. action_threshold is
* initialized to COUNT_MASK which is the maximum.
*
* That error event entry causes cec_add_elem() to return !0 value and thus
@@ -122,7 +122,7 @@ static DEFINE_MUTEX(ce_mutex);
static u64 dfs_pfn;
/* Amount of errors after which we offline */
-static unsigned int count_threshold = COUNT_MASK;
+static u64 action_threshold = COUNT_MASK;
/* Each element "decays" each decay_interval which is 24hrs by default. */
#define CEC_DECAY_DEFAULT_INTERVAL 24 * 60 * 60 /* 24 hrs */
@@ -345,7 +345,7 @@ int cec_add_elem(u64 pfn)
/* Check action threshold and soft-offline, if reached. */
count = COUNT(ca->array[to]);
- if (count >= count_threshold) {
+ if (count >= action_threshold) {
u64 pfn = ca->array[to] >> PAGE_SHIFT;
if (!pfn_valid(pfn)) {
@@ -416,18 +416,18 @@ static int decay_interval_set(void *data, u64 val)
}
DEFINE_DEBUGFS_ATTRIBUTE(decay_interval_ops, pfn_get, decay_interval_set, "%lld\n");
-static int count_threshold_set(void *data, u64 val)
+static int action_threshold_set(void *data, u64 val)
{
*(u64 *)data = val;
if (val > COUNT_MASK)
val = COUNT_MASK;
- count_threshold = val;
+ action_threshold = val;
return 0;
}
-DEFINE_DEBUGFS_ATTRIBUTE(count_threshold_ops, pfn_get, count_threshold_set, "%lld\n");
+DEFINE_DEBUGFS_ATTRIBUTE(action_threshold_ops, pfn_get, action_threshold_set, "%lld\n");
static int array_dump(struct seq_file *m, void *v)
{
@@ -453,7 +453,7 @@ static int array_dump(struct seq_file *m, void *v)
seq_printf(m, "Decay interval: %lld seconds\n", decay_interval);
seq_printf(m, "Decays: %lld\n", ca->decays_done);
- seq_printf(m, "Action threshold: %d\n", count_threshold);
+ seq_printf(m, "Action threshold: %lld\n", action_threshold);
mutex_unlock(&ce_mutex);
@@ -502,10 +502,10 @@ static int __init create_debugfs_nodes(void)
goto err;
}
- count = debugfs_create_file("count_threshold", S_IRUSR | S_IWUSR, d,
- &count_threshold, &count_threshold_ops);
+ count = debugfs_create_file("action_threshold", S_IRUSR | S_IWUSR, d,
+ &action_threshold, &action_threshold_ops);
if (!count) {
- pr_warn("Error creating count_threshold debugfs node!\n");
+ pr_warn("Error creating action_threshold debugfs node!\n");
goto err;
}
--
2.21.0
next prev parent reply other threads:[~2019-05-09 18:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-09 18:09 [PATCH 00/11] RAS/CEC: Fixes and cleanups Borislav Petkov
2019-05-09 18:09 ` [PATCH 01/11] RAS/CEC: Fix binary search function Borislav Petkov
2019-05-09 18:09 ` [PATCH 02/11] RAS/CEC: Convert the timer callback to a workqueue Borislav Petkov
2019-05-09 18:09 ` [PATCH 03/11] RAS/CEC: Fix pfn insertion Borislav Petkov
2019-05-09 18:09 ` [PATCH 04/11] RAS/CEC: Check count_threshold unconditionally Borislav Petkov
2019-05-09 18:09 ` [PATCH 05/11] RAS/CEC: Do not set decay value on error Borislav Petkov
2019-05-09 18:09 ` [PATCH 06/11] RAS/CEC: Fix potential memory leak Borislav Petkov
2019-05-09 18:09 ` [PATCH 07/11] RAS/CEC: Sanity-check array on every insertion Borislav Petkov
2019-05-09 18:09 ` Borislav Petkov [this message]
2019-05-09 18:09 ` [PATCH 09/11] RAS/CEC: Dump the different array element sections Borislav Petkov
2019-05-09 18:09 ` [PATCH 10/11] RAS/CEC: Add CONFIG_RAS_CEC_DEBUG and move CEC debug features there Borislav Petkov
2019-05-09 18:09 ` [PATCH 11/11] RAS/CEC: Add copyright Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190509180926.31932-9-bp@alien8.de \
--to=bp@alien8.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).