From: Borislav Petkov <bp@alien8.de>
To: Tony Luck <tony.luck@intel.com>
Cc: linux-edac <linux-edac@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 06/11] RAS/CEC: Fix potential memory leak
Date: Thu, 9 May 2019 20:09:21 +0200 [thread overview]
Message-ID: <20190509180926.31932-7-bp@alien8.de> (raw)
In-Reply-To: <20190509180926.31932-1-bp@alien8.de>
From: Borislav Petkov <bp@suse.de>
Free the array page if a failure is encountered while creating the
debugfs nodes.
Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: Tony Luck <tony.luck@intel.com>
Cc: linux-edac <linux-edac@vger.kernel.org>
---
drivers/ras/cec.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/ras/cec.c b/drivers/ras/cec.c
index 667a126f39f1..8a04b9864192 100644
--- a/drivers/ras/cec.c
+++ b/drivers/ras/cec.c
@@ -504,8 +504,10 @@ void __init cec_init(void)
return;
}
- if (create_debugfs_nodes())
+ if (create_debugfs_nodes()) {
+ free_page((unsigned long)ce_arr.array);
return;
+ }
INIT_DELAYED_WORK(&cec_work, cec_work_fn);
schedule_delayed_work(&cec_work, CEC_DECAY_DEFAULT_INTERVAL);
--
2.21.0
next prev parent reply other threads:[~2019-05-09 18:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-09 18:09 [PATCH 00/11] RAS/CEC: Fixes and cleanups Borislav Petkov
2019-05-09 18:09 ` [PATCH 01/11] RAS/CEC: Fix binary search function Borislav Petkov
2019-05-09 18:09 ` [PATCH 02/11] RAS/CEC: Convert the timer callback to a workqueue Borislav Petkov
2019-05-09 18:09 ` [PATCH 03/11] RAS/CEC: Fix pfn insertion Borislav Petkov
2019-05-09 18:09 ` [PATCH 04/11] RAS/CEC: Check count_threshold unconditionally Borislav Petkov
2019-05-09 18:09 ` [PATCH 05/11] RAS/CEC: Do not set decay value on error Borislav Petkov
2019-05-09 18:09 ` Borislav Petkov [this message]
2019-05-09 18:09 ` [PATCH 07/11] RAS/CEC: Sanity-check array on every insertion Borislav Petkov
2019-05-09 18:09 ` [PATCH 08/11] RAS/CEC: Rename count_threshold to action_threshold Borislav Petkov
2019-05-09 18:09 ` [PATCH 09/11] RAS/CEC: Dump the different array element sections Borislav Petkov
2019-05-09 18:09 ` [PATCH 10/11] RAS/CEC: Add CONFIG_RAS_CEC_DEBUG and move CEC debug features there Borislav Petkov
2019-05-09 18:09 ` [PATCH 11/11] RAS/CEC: Add copyright Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190509180926.31932-7-bp@alien8.de \
--to=bp@alien8.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).