perf/x86/intel: allow PEBS multi-entry in watermark mode
diff mbox series

Message ID
State Accepted
Commit c7a286577d7592720c2f179aadfb325a1ff48c95
Headers show
  • perf/x86/intel: allow PEBS multi-entry in watermark mode
Related show

Commit Message

Stephane Eranian May 14, 2019, 12:34 a.m. UTC
This patch fixes an issue introduced with:

   583feb08e7f7 ("perf/x86/intel: Fix handling of wakeup_events for multi-entry PEBS")

The original patch prevented using multi-entry PEBS when wakeup_events != 0.
However given that wakeup_events is part of a union with wakeup_watermark, it
means that in watermark mode, PEBS multi-entry is also disabled which is not the
intent. This patch fixes this by checking is watermark mode is enabled.

Signed-off-by: Stephane Eranian <>
Change-Id: I8362bbcf9035c860b64b4c2e8faf310ebd74c234
 arch/x86/events/intel/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff mbox series

diff --git a/arch/x86/events/intel/core.c b/arch/x86/events/intel/core.c
index 416233f92b3c..613fabba2c99 100644
--- a/arch/x86/events/intel/core.c
+++ b/arch/x86/events/intel/core.c
@@ -3280,7 +3280,7 @@  static int intel_pmu_hw_config(struct perf_event *event)
 		return ret;
 	if (event->attr.precise_ip) {
-		if (!(event->attr.freq || event->attr.wakeup_events)) {
+		if (!(event->attr.freq || (event->attr.wakeup_events && !event->attr.watermark))) {
 			event->hw.flags |= PERF_X86_EVENT_AUTO_RELOAD;
 			if (!(event->attr.sample_type &