From: Jose Abreu <Jose.Abreu@synopsys.com>
To: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Jose Abreu <Jose.Abreu@synopsys.com>,
Joao Pinto <Joao.Pinto@synopsys.com>,
"David S . Miller" <davem@davemloft.net>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
Corentin Labbe <clabbe.montjoie@gmail.com>
Subject: [RFC net-next v2 14/14] net: stmmac: dwmac4/5: Fix Hash Filter
Date: Tue, 14 May 2019 17:45:36 +0200 [thread overview]
Message-ID: <a9fffe7f06f8aaaa86d85f4f944cc8b79acd8928.1557848472.git.joabreu@synopsys.com> (raw)
In-Reply-To: <cover.1557848472.git.joabreu@synopsys.com>
In-Reply-To: <cover.1557848472.git.joabreu@synopsys.com>
In order for hash filter to work we need to set the HPF bit.
Fout out while running stmmac selftests
Signed-off-by: Jose Abreu <joabreu@synopsys.com>
Cc: Joao Pinto <jpinto@synopsys.com>
Cc: David S. Miller <davem@davemloft.net>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
Cc: Alexandre Torgue <alexandre.torgue@st.com>
Cc: Corentin Labbe <clabbe.montjoie@gmail.com>
---
drivers/net/ethernet/stmicro/stmmac/dwmac4.h | 1 +
drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c | 2 ++
2 files changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4.h b/drivers/net/ethernet/stmicro/stmmac/dwmac4.h
index c3cbca804bcd..01c10893b7a5 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac4.h
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4.h
@@ -65,6 +65,7 @@
#define GMAC_PACKET_FILTER_HMC BIT(2)
#define GMAC_PACKET_FILTER_PM BIT(4)
#define GMAC_PACKET_FILTER_PCF BIT(7)
+#define GMAC_PACKET_FILTER_HPF BIT(10)
#define GMAC_MAX_PERFECT_ADDRESSES 128
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c b/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c
index 02a3a7e2db6e..094bd069c093 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c
@@ -438,6 +438,8 @@ static void dwmac4_set_filter(struct mac_device_info *hw,
writel(mc_filter[1], ioaddr + GMAC_HASH_TAB_32_63);
}
+ value |= GMAC_PACKET_FILTER_HPF;
+
/* Handle multiple unicast addresses */
if (netdev_uc_count(dev) > GMAC_MAX_PERFECT_ADDRESSES) {
/* Switch to promiscuous mode if more than 128 addrs
--
2.7.4
next prev parent reply other threads:[~2019-05-14 15:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-14 15:45 [RFC net-next v2 00/14] net: stmmac: Selftests Jose Abreu
2019-05-14 15:45 ` [RFC net-next v2 01/14] net: stmmac: Add MAC loopback callback to HWIF Jose Abreu
2019-05-14 15:45 ` [RFC net-next v2 02/14] net: stmmac: dwmac100: Add MAC loopback support Jose Abreu
2019-05-14 15:45 ` [RFC net-next v2 03/14] net: stmmac: dwmac1000: " Jose Abreu
2019-05-14 15:45 ` [RFC net-next v2 04/14] net: stmmac: dwmac4/5: " Jose Abreu
2019-05-14 15:45 ` [RFC net-next v2 05/14] net: stmmac: dwxgmac2: " Jose Abreu
2019-05-14 15:45 ` [RFC net-next v2 06/14] net: ethernet: stmmac: dwmac-sun8i: Enable control of loopback Jose Abreu
2019-05-14 15:45 ` [RFC net-next v2 07/14] net: stmmac: Switch MMC functions to HWIF callbacks Jose Abreu
2019-05-14 15:45 ` [RFC net-next v2 08/14] net: stmmac: dwmac1000: Also pass control frames while in promisc mode Jose Abreu
2019-05-14 15:45 ` [RFC net-next v2 09/14] net: stmmac: dwmac4/5: " Jose Abreu
2019-05-14 15:45 ` [RFC net-next v2 10/14] net: stmmac: dwxgmac2: " Jose Abreu
2019-05-14 15:45 ` [RFC net-next v2 11/14] net: stmmac: Introduce selftests support Jose Abreu
2019-05-14 15:45 ` [RFC net-next v2 12/14] net: stmmac: dwmac1000: Fix Hash Filter Jose Abreu
2019-05-14 15:45 ` [RFC net-next v2 13/14] net: stmmac: dwmac1000: Clear unused address entries Jose Abreu
2019-05-14 15:45 ` Jose Abreu [this message]
2019-05-14 18:09 ` [RFC net-next v2 00/14] net: stmmac: Selftests David Miller
2019-05-15 17:29 ` Corentin Labbe
2019-05-16 7:52 ` Jose Abreu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9fffe7f06f8aaaa86d85f4f944cc8b79acd8928.1557848472.git.joabreu@synopsys.com \
--to=jose.abreu@synopsys.com \
--cc=Joao.Pinto@synopsys.com \
--cc=alexandre.torgue@st.com \
--cc=clabbe.montjoie@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).