linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jose Abreu <Jose.Abreu@synopsys.com>
To: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Jose Abreu <Jose.Abreu@synopsys.com>,
	Joao Pinto <Joao.Pinto@synopsys.com>,
	"David S . Miller" <davem@davemloft.net>,
	Giuseppe Cavallaro <peppe.cavallaro@st.com>,
	Alexandre Torgue <alexandre.torgue@st.com>,
	Corentin Labbe <clabbe.montjoie@gmail.com>
Subject: [RFC net-next v2 08/14] net: stmmac: dwmac1000: Also pass control frames while in promisc mode
Date: Tue, 14 May 2019 17:45:30 +0200	[thread overview]
Message-ID: <61a44d1f91134574defb7bf597ac327a0d8d66a1.1557848472.git.joabreu@synopsys.com> (raw)
In-Reply-To: <cover.1557848472.git.joabreu@synopsys.com>
In-Reply-To: <cover.1557848472.git.joabreu@synopsys.com>

In order for the selftests to run the Flow Control selftest we need to
also pass pause frames to the stack.

Pass this type of frames while in promiscuous mode.

Signed-off-by: Jose Abreu <joabreu@synopsys.com>
Cc: Joao Pinto <jpinto@synopsys.com>
Cc: David S. Miller <davem@davemloft.net>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
Cc: Alexandre Torgue <alexandre.torgue@st.com>
Cc: Corentin Labbe <clabbe.montjoie@gmail.com>
---
 drivers/net/ethernet/stmicro/stmmac/dwmac1000.h      | 1 +
 drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac1000.h b/drivers/net/ethernet/stmicro/stmmac/dwmac1000.h
index 184ca13c8f79..56a69fb6f0b9 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac1000.h
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac1000.h
@@ -146,6 +146,7 @@ enum inter_frame_gap {
 #define GMAC_FRAME_FILTER_DAIF	0x00000008	/* DA Inverse Filtering */
 #define GMAC_FRAME_FILTER_PM	0x00000010	/* Pass all multicast */
 #define GMAC_FRAME_FILTER_DBF	0x00000020	/* Disable Broadcast frames */
+#define GMAC_FRAME_FILTER_PCF	0x00000080	/* Pass Control frames */
 #define GMAC_FRAME_FILTER_SAIF	0x00000100	/* Inverse Filtering */
 #define GMAC_FRAME_FILTER_SAF	0x00000200	/* Source Address Filter */
 #define GMAC_FRAME_FILTER_HPF	0x00000400	/* Hash or perfect Filter */
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c b/drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c
index 398303c783f4..8ca73bd15e07 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac1000_core.c
@@ -172,7 +172,7 @@ static void dwmac1000_set_filter(struct mac_device_info *hw,
 	memset(mc_filter, 0, sizeof(mc_filter));
 
 	if (dev->flags & IFF_PROMISC) {
-		value = GMAC_FRAME_FILTER_PR;
+		value = GMAC_FRAME_FILTER_PR | GMAC_FRAME_FILTER_PCF;
 	} else if (dev->flags & IFF_ALLMULTI) {
 		value = GMAC_FRAME_FILTER_PM;	/* pass all multi */
 	} else if (!netdev_mc_empty(dev)) {
-- 
2.7.4


  parent reply	other threads:[~2019-05-14 15:46 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-14 15:45 [RFC net-next v2 00/14] net: stmmac: Selftests Jose Abreu
2019-05-14 15:45 ` [RFC net-next v2 01/14] net: stmmac: Add MAC loopback callback to HWIF Jose Abreu
2019-05-14 15:45 ` [RFC net-next v2 02/14] net: stmmac: dwmac100: Add MAC loopback support Jose Abreu
2019-05-14 15:45 ` [RFC net-next v2 03/14] net: stmmac: dwmac1000: " Jose Abreu
2019-05-14 15:45 ` [RFC net-next v2 04/14] net: stmmac: dwmac4/5: " Jose Abreu
2019-05-14 15:45 ` [RFC net-next v2 05/14] net: stmmac: dwxgmac2: " Jose Abreu
2019-05-14 15:45 ` [RFC net-next v2 06/14] net: ethernet: stmmac: dwmac-sun8i: Enable control of loopback Jose Abreu
2019-05-14 15:45 ` [RFC net-next v2 07/14] net: stmmac: Switch MMC functions to HWIF callbacks Jose Abreu
2019-05-14 15:45 ` Jose Abreu [this message]
2019-05-14 15:45 ` [RFC net-next v2 09/14] net: stmmac: dwmac4/5: Also pass control frames while in promisc mode Jose Abreu
2019-05-14 15:45 ` [RFC net-next v2 10/14] net: stmmac: dwxgmac2: " Jose Abreu
2019-05-14 15:45 ` [RFC net-next v2 11/14] net: stmmac: Introduce selftests support Jose Abreu
2019-05-14 15:45 ` [RFC net-next v2 12/14] net: stmmac: dwmac1000: Fix Hash Filter Jose Abreu
2019-05-14 15:45 ` [RFC net-next v2 13/14] net: stmmac: dwmac1000: Clear unused address entries Jose Abreu
2019-05-14 15:45 ` [RFC net-next v2 14/14] net: stmmac: dwmac4/5: Fix Hash Filter Jose Abreu
2019-05-14 18:09 ` [RFC net-next v2 00/14] net: stmmac: Selftests David Miller
2019-05-15 17:29 ` Corentin Labbe
2019-05-16  7:52   ` Jose Abreu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=61a44d1f91134574defb7bf597ac327a0d8d66a1.1557848472.git.joabreu@synopsys.com \
    --to=jose.abreu@synopsys.com \
    --cc=Joao.Pinto@synopsys.com \
    --cc=alexandre.torgue@st.com \
    --cc=clabbe.montjoie@gmail.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=peppe.cavallaro@st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).