From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: Linux Kernel Development <linux-kernel@vger.kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: [PATCH] M68k IDE lock fixes
Date: Wed, 30 Oct 2002 17:52:39 +0100 (MET) [thread overview]
Message-ID: <200210301652.g9UGqdc11582@vervain.sonytel.be> (raw)
M68k IDE lock fixes:
- Kill warning: ide_{get,release}_lock() can be real routines only if
IDE_ARCH_LOCK is defined, the same is true for ide_intr_lock
- Use the correct lock for ide_{get,release}_lock()
--- linux-2.5.x-bk-20021030/drivers/ide/ide.c Wed Sep 18 10:36:42 2002
+++ linux-m68k-2.5.x/drivers/ide/ide.c Wed Sep 18 10:48:17 2002
@@ -181,13 +181,13 @@
static int ide_scan_direction; /* THIS was formerly 2.2.x pci=reverse */
-#if defined(__mc68000__) || defined(CONFIG_APUS)
+#ifdef IDE_ARCH_LOCK
/*
* ide_lock is used by the Atari code to obtain access to the IDE interrupt,
* which is shared between several drivers.
*/
static int ide_intr_lock;
-#endif /* __mc68000__ || CONFIG_APUS */
+#endif /* IDE_ARCH_LOCK */
#ifdef CONFIG_IDEDMA_AUTO
int noautodma = 0;
@@ -1097,7 +1097,7 @@
*/
/* for atari only */
- ide_release_lock(&ide_lock);
+ ide_release_lock(&ide_intr_lock);
hwgroup->busy = 0;
}
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next reply other threads:[~2002-10-30 16:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-30 16:52 Geert Uytterhoeven [this message]
-- strict thread matches above, loose matches on Subject: below --
2002-09-28 20:42 [PATCH] M68k IDE lock fixes Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200210301652.g9UGqdc11582@vervain.sonytel.be \
--to=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).