From: kan.liang@linux.intel.com
To: peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com,
linux-kernel@vger.kernel.org
Cc: eranian@google.com, tj@kernel.org, mark.rutland@arm.com,
irogers@google.com, ak@linux.intel.com,
Kan Liang <kan.liang@linux.intel.com>
Subject: [PATCH V2 2/4] perf: Add filter_match() as a parameter for pinned/flexible_sched_in()
Date: Wed, 15 May 2019 14:01:30 -0700 [thread overview]
Message-ID: <1557954092-67275-3-git-send-email-kan.liang@linux.intel.com> (raw)
In-Reply-To: <1557954092-67275-1-git-send-email-kan.liang@linux.intel.com>
From: Kan Liang <kan.liang@linux.intel.com>
A fast path will be introduced in the following patches to speed up the
cgroup events sched in, which only needs a simpler filter_match().
Add filter_match() as a parameter for pinned/flexible_sched_in().
No functional change.
Signed-off-by: Kan Liang <kan.liang@linux.intel.com>
---
kernel/events/core.c | 15 +++++++++------
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/kernel/events/core.c b/kernel/events/core.c
index e7ca0474..a3885e68 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -3316,7 +3316,8 @@ static void cpu_ctx_sched_out(struct perf_cpu_context *cpuctx,
}
static int visit_groups_merge(struct perf_event_groups *groups, int cpu,
- int (*func)(struct perf_event *, void *), void *data)
+ int (*func)(struct perf_event *, void *, int (*)(struct perf_event *)),
+ void *data)
{
struct perf_event **evt, *evt1, *evt2;
int ret;
@@ -3336,7 +3337,7 @@ static int visit_groups_merge(struct perf_event_groups *groups, int cpu,
evt = &evt2;
}
- ret = func(*evt, data);
+ ret = func(*evt, data, event_filter_match);
if (ret)
return ret;
@@ -3353,7 +3354,8 @@ struct sched_in_data {
enum event_type_t event_type;
};
-static int pinned_sched_in(struct perf_event *event, void *data)
+static int pinned_sched_in(struct perf_event *event, void *data,
+ int (*filter_match)(struct perf_event *))
{
struct sched_in_data *sid = data;
@@ -3363,7 +3365,7 @@ static int pinned_sched_in(struct perf_event *event, void *data)
if (perf_cgroup_skip_switch(sid->event_type, event, true))
return 0;
- if (!event_filter_match(event))
+ if (!filter_match(event))
return 0;
if (group_can_go_on(event, sid->cpuctx, sid->can_add_hw)) {
@@ -3381,7 +3383,8 @@ static int pinned_sched_in(struct perf_event *event, void *data)
return 0;
}
-static int flexible_sched_in(struct perf_event *event, void *data)
+static int flexible_sched_in(struct perf_event *event, void *data,
+ int (*filter_match)(struct perf_event *))
{
struct sched_in_data *sid = data;
@@ -3391,7 +3394,7 @@ static int flexible_sched_in(struct perf_event *event, void *data)
if (perf_cgroup_skip_switch(sid->event_type, event, false))
return 0;
- if (!event_filter_match(event))
+ if (!filter_match(event))
return 0;
if (group_can_go_on(event, sid->cpuctx, sid->can_add_hw)) {
--
2.7.4
next prev parent reply other threads:[~2019-05-15 21:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-15 21:01 [PATCH V2 0/4] Optimize cgroup context switch kan.liang
2019-05-15 21:01 ` [PATCH V2 1/4] perf: Fix system-wide events miscounting during cgroup monitoring kan.liang
2019-05-15 21:01 ` kan.liang [this message]
2019-05-15 21:01 ` [PATCH V2 3/4] perf cgroup: Add new RB tree keys for cgroup kan.liang
2019-05-15 21:01 ` [PATCH V2 4/4] perf cgroup: Add fast path for cgroup switch kan.liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1557954092-67275-3-git-send-email-kan.liang@linux.intel.com \
--to=kan.liang@linux.intel.com \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=irogers@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).