From: Sven Van Asbroeck <thesven73@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: devel@driverdev.osuosl.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [PATCH] staging: fieldbus: anybuss: force address space conversion
Date: Tue, 21 May 2019 10:51:16 -0400 [thread overview]
Message-ID: <20190521145116.24378-1-TheSven73@gmail.com> (raw)
The regmap's context (stored as 'void *') consists of a pointer to
__iomem. Mixing __iomem and non-__iomem addresses generates
sparse warnings.
Fix by using __force when converting to/from 'void __iomem *' and
the regmap's context.
Signed-off-by: Sven Van Asbroeck <TheSven73@gmail.com>
---
drivers/staging/fieldbus/anybuss/arcx-anybus.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/fieldbus/anybuss/arcx-anybus.c b/drivers/staging/fieldbus/anybuss/arcx-anybus.c
index a167fb68e355..8126e5535ada 100644
--- a/drivers/staging/fieldbus/anybuss/arcx-anybus.c
+++ b/drivers/staging/fieldbus/anybuss/arcx-anybus.c
@@ -114,7 +114,7 @@ static void export_reset_1(struct device *dev, bool assert)
static int read_reg_bus(void *context, unsigned int reg,
unsigned int *val)
{
- void __iomem *base = context;
+ void __iomem *base = (__force void __iomem *)context;
*val = readb(base + reg);
return 0;
@@ -123,7 +123,7 @@ static int read_reg_bus(void *context, unsigned int reg,
static int write_reg_bus(void *context, unsigned int reg,
unsigned int val)
{
- void __iomem *base = context;
+ void __iomem *base = (__force void __iomem *)context;
writeb(val, base + reg);
return 0;
@@ -153,7 +153,7 @@ static struct regmap *create_parallel_regmap(struct platform_device *pdev,
base = devm_ioremap_resource(dev, res);
if (IS_ERR(base))
return ERR_CAST(base);
- return devm_regmap_init(dev, NULL, base, ®map_cfg);
+ return devm_regmap_init(dev, NULL, (__force void *)base, ®map_cfg);
}
static struct anybuss_host *
--
2.17.1
next reply other threads:[~2019-05-21 14:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-21 14:51 Sven Van Asbroeck [this message]
2019-05-21 15:10 ` [PATCH] staging: fieldbus: anybuss: force address space conversion Dan Carpenter
2019-05-21 15:19 ` Sven Van Asbroeck
2019-05-21 15:42 ` Greg KH
2019-05-21 15:53 ` Sven Van Asbroeck
2019-05-21 16:24 ` Greg KH
2019-05-21 16:53 ` Sven Van Asbroeck
2019-05-21 17:06 ` Sven Van Asbroeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190521145116.24378-1-TheSven73@gmail.com \
--to=thesven73@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).