From: Mao Wenan <maowenan@huawei.com>
To: <gregkh@linuxfoundation.org>, <jeremy@azazel.net>
Cc: <devel@driverdev.osuosl.org>, <linux-kernel@vger.kernel.org>,
<kernel-janitors@vger.kernel.org>,
Mao Wenan <maowenan@huawei.com>
Subject: [PATCH net] staging: Remove set but not used variable ‘status’
Date: Sat, 25 May 2019 12:26:42 +0800 [thread overview]
Message-ID: <20190525042642.78482-1-maowenan@huawei.com> (raw)
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/staging/kpc2000/kpc_spi/spi_driver.c: In function
‘kp_spi_transfer_one_message’:
drivers/staging/kpc2000/kpc_spi/spi_driver.c:282:9: warning: variable
‘status’ set but not used [-Wunused-but-set-variable]
int status = 0;
^~~~~~
The variable 'status' is not used any more, remve it.
Signed-off-by: Mao Wenan <maowenan@huawei.com>
---
drivers/staging/kpc2000/kpc_spi/spi_driver.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/kpc2000/kpc_spi/spi_driver.c b/drivers/staging/kpc2000/kpc_spi/spi_driver.c
index 86df16547a92..16f9518f8d63 100644
--- a/drivers/staging/kpc2000/kpc_spi/spi_driver.c
+++ b/drivers/staging/kpc2000/kpc_spi/spi_driver.c
@@ -279,7 +279,6 @@ kp_spi_transfer_one_message(struct spi_master *master, struct spi_message *m)
struct kp_spi *kpspi;
struct spi_transfer *transfer;
union kp_spi_config sc;
- int status = 0;
spidev = m->spi;
kpspi = spi_master_get_devdata(master);
@@ -332,7 +331,6 @@ kp_spi_transfer_one_message(struct spi_master *master, struct spi_message *m)
/* do the transfers for this message */
list_for_each_entry(transfer, &m->transfers, transfer_list) {
if (transfer->tx_buf == NULL && transfer->rx_buf == NULL && transfer->len) {
- status = -EINVAL;
break;
}
@@ -370,7 +368,6 @@ kp_spi_transfer_one_message(struct spi_master *master, struct spi_message *m)
m->actual_length += count;
if (count != transfer->len) {
- status = -EIO;
break;
}
}
--
2.20.1
next reply other threads:[~2019-05-25 4:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-25 4:26 Mao Wenan [this message]
2019-05-25 5:01 ` [PATCH net] staging: Remove set but not used variable ‘status’ Greg KH
2019-05-25 6:39 ` maowenan
2019-05-25 8:13 ` [PATCH -next v2] staging: kpc2000: " Mao Wenan
2019-05-28 2:09 ` maowenan
2019-05-28 8:02 ` [PATCH -next v3 0/2] cleanup for kpc2000_spi.c Mao Wenan
2019-05-28 8:02 ` [PATCH -next v3 1/2] staging: kpc2000: report error status to spi core Mao Wenan
2019-05-28 8:02 ` [PATCH -next v3 2/2] staging: kpc2000: replace white spaces with tabs for kpc2000_spi.c Mao Wenan
2019-05-25 12:59 ` [PATCH net] staging: Remove set but not used variable ‘status’ Sven Van Asbroeck
2019-05-27 2:33 ` maowenan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190525042642.78482-1-maowenan@huawei.com \
--to=maowenan@huawei.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jeremy@azazel.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).