linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: tglx@linutronix.de
Cc: linux-kernel@vger.kernel.org, andriy.shevchenko@linux.intel.com
Subject: [PATCH V3 3/8] genirq/timings: Optimize the period detection speed
Date: Mon, 27 May 2019 22:55:16 +0200	[thread overview]
Message-ID: <20190527205521.12091-4-daniel.lezcano@linaro.org> (raw)
In-Reply-To: <20190527205521.12091-1-daniel.lezcano@linaro.org>

If we have a minimal period and if there is a period which is a
multiple of it but lesser than the max period then it will be detected
before and the minimal period will be never reached.

 1 2 1 2 1 2 1 2 1 2 1 2
 <-----> <-----> <----->
 <-> <-> <-> <-> <-> <->

In our case, the minimum period is 2 and the maximum period is 5. That
means all repeating pattern of 2 will be detected as repeating pattern
of 4, it is pointless to go up to 2 when searching for the period as it
will always fail.

Remove one loop iteration by increasing the minimal period to 3.

Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
 kernel/irq/timings.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/irq/timings.c b/kernel/irq/timings.c
index 19d2fad379ee..1d1c411d4cae 100644
--- a/kernel/irq/timings.c
+++ b/kernel/irq/timings.c
@@ -261,7 +261,7 @@ void irq_timings_disable(void)
 #define EMA_ALPHA_VAL		64
 #define EMA_ALPHA_SHIFT		7
 
-#define PREDICTION_PERIOD_MIN	2
+#define PREDICTION_PERIOD_MIN	3
 #define PREDICTION_PERIOD_MAX	5
 #define PREDICTION_FACTOR	4
 #define PREDICTION_MAX		10 /* 2 ^ PREDICTION_MAX useconds */
-- 
2.17.1


  parent reply	other threads:[~2019-05-27 20:55 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-27 20:55 [PATCH V3 0/8] genirq/timings: Fixes and selftests Daniel Lezcano
2019-05-27 20:55 ` [PATCH V3 1/8] genirq/timings: Fix next event index function Daniel Lezcano
2019-06-12 12:27   ` [tip:irq/core] " tip-bot for Daniel Lezcano
2019-05-27 20:55 ` [PATCH V3 2/8] genirq/timings: Fix timings buffer inspection Daniel Lezcano
2019-06-12 12:28   ` [tip:irq/core] " tip-bot for Daniel Lezcano
2019-05-27 20:55 ` Daniel Lezcano [this message]
2019-06-12 12:29   ` [tip:irq/core] genirq/timings: Optimize the period detection speed tip-bot for Daniel Lezcano
2019-05-27 20:55 ` [PATCH V3 4/8] genirq/timings: Encapsulate timings push Daniel Lezcano
2019-06-12 12:29   ` [tip:irq/core] " tip-bot for Daniel Lezcano
2019-05-27 20:55 ` [PATCH V3 5/8] genirq/timings: Encapsulate storing function Daniel Lezcano
2019-06-12 12:30   ` [tip:irq/core] " tip-bot for Daniel Lezcano
2019-05-27 20:55 ` [PATCH V3 6/8] genirq/timings: Add selftest for circular array Daniel Lezcano
2019-06-12 12:31   ` [tip:irq/core] " tip-bot for Daniel Lezcano
2019-05-27 20:55 ` [PATCH V3 7/8] genirq/timings: Add selftest for irqs circular buffer Daniel Lezcano
2019-06-12 12:31   ` [tip:irq/core] " tip-bot for Daniel Lezcano
2019-05-27 20:55 ` [PATCH V3 8/8] genirq/timings: Add selftest for next event computation Daniel Lezcano
2019-06-12 12:32   ` [tip:irq/core] " tip-bot for Daniel Lezcano
2019-06-04  6:15 ` [PATCH V3 0/8] genirq/timings: Fixes and selftests Daniel Lezcano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190527205521.12091-4-daniel.lezcano@linaro.org \
    --to=daniel.lezcano@linaro.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).