From: YueHaibing <yuehaibing@huawei.com>
To: <dvhart@infradead.org>, <andy@infradead.org>, <lkundrak@v3.sk>
Cc: <linux-kernel@vger.kernel.org>,
<platform-driver-x86@vger.kernel.org>,
YueHaibing <yuehaibing@huawei.com>
Subject: [PATCH -next 2/2] Platform: OLPC: Add INPUT dependencies
Date: Tue, 28 May 2019 17:28:06 +0800 [thread overview]
Message-ID: <20190528092806.20080-3-yuehaibing@huawei.com> (raw)
In-Reply-To: <20190528092806.20080-1-yuehaibing@huawei.com>
Building with CONFIG_INPUT set to m:
drivers/platform/olpc/olpc-xo175-ec.o: In function `olpc_xo175_ec_complete':
olpc-xo175-ec.c:(.text+0x75d): undefined reference to `input_event'
olpc-xo175-ec.c:(.text+0x76f): undefined reference to `input_event'
olpc-xo175-ec.c:(.text+0x787): undefined reference to `input_event'
olpc-xo175-ec.c:(.text+0x799): undefined reference to `input_event'
drivers/platform/olpc/olpc-xo175-ec.o: In function `olpc_xo175_ec_probe':
olpc-xo175-ec.c:(.text+0x8d5): undefined reference to `devm_input_allocate_device'
olpc-xo175-ec.c:(.text+0x910): undefined reference to `input_set_capability'
olpc-xo175-ec.c:(.text+0x91c): undefined reference to `input_register_device'
This patch add INPUT dependencies to fix this.
Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: 0c3d931b3ab9 ("Platform: OLPC: Add XO-1.75 EC driver")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/platform/olpc/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/platform/olpc/Kconfig b/drivers/platform/olpc/Kconfig
index 1d3244a..1fa676c 100644
--- a/drivers/platform/olpc/Kconfig
+++ b/drivers/platform/olpc/Kconfig
@@ -6,6 +6,7 @@ config OLPC_XO175_EC
tristate "OLPC XO 1.75 Embedded Controller"
depends on ARCH_MMP || COMPILE_TEST
depends on SPI_SLAVE
+ depends on INPUT
select OLPC_EC
help
Include support for the OLPC XO Embedded Controller (EC). The EC
--
2.7.4
next prev parent reply other threads:[~2019-05-28 9:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-28 9:28 [PATCH -next 0/2] Platform: OLPC: Fix two randbuild error YueHaibing
2019-05-28 9:28 ` [PATCH -next 1/2] Platform: OLPC: Fix build error without CONFIG_SPI YueHaibing
2019-05-28 9:28 ` YueHaibing [this message]
2019-05-28 11:06 ` [PATCH -next 0/2] Platform: OLPC: Fix two randbuild error Lubomir Rintel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190528092806.20080-3-yuehaibing@huawei.com \
--to=yuehaibing@huawei.com \
--cc=andy@infradead.org \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkundrak@v3.sk \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).