From: Abel Vesa <abel.vesa@nxp.com>
To: Mike Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Shawn Guo <shawnguo@kernel.org>
Cc: Fabio Estevam <fabio.estevam@nxp.com>,
Aisheng Dong <aisheng.dong@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
dl-linux-imx <linux-imx@nxp.com>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
Jacky Bai <ping.bai@nxp.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Abel Vesa <abel.vesa@nxp.com>
Subject: [RESEND 10/18] clk: imx: clk-fixup-div: Switch to clk_hw based API
Date: Wed, 29 May 2019 12:26:44 +0000 [thread overview]
Message-ID: <1559132773-12884-11-git-send-email-abel.vesa@nxp.com> (raw)
In-Reply-To: <1559132773-12884-1-git-send-email-abel.vesa@nxp.com>
Switch the imx_clk_fixup_divider function to clk_hw based API, rename
accordingly and add a macro for clk based legacy. This allows us to
move closer to a clear split between consumer and provider clk APIs.
Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
---
drivers/clk/imx/clk-fixup-div.c | 15 ++++++++++-----
drivers/clk/imx/clk.h | 7 +++++--
2 files changed, 15 insertions(+), 7 deletions(-)
diff --git a/drivers/clk/imx/clk-fixup-div.c b/drivers/clk/imx/clk-fixup-div.c
index ce572273..287539b 100644
--- a/drivers/clk/imx/clk-fixup-div.c
+++ b/drivers/clk/imx/clk-fixup-div.c
@@ -91,13 +91,14 @@ static const struct clk_ops clk_fixup_div_ops = {
.set_rate = clk_fixup_div_set_rate,
};
-struct clk *imx_clk_fixup_divider(const char *name, const char *parent,
+struct clk_hw *imx_clk_hw_fixup_divider(const char *name, const char *parent,
void __iomem *reg, u8 shift, u8 width,
void (*fixup)(u32 *val))
{
struct clk_fixup_div *fixup_div;
- struct clk *clk;
+ struct clk_hw *hw;
struct clk_init_data init;
+ int ret;
if (!fixup)
return ERR_PTR(-EINVAL);
@@ -120,9 +121,13 @@ struct clk *imx_clk_fixup_divider(const char *name, const char *parent,
fixup_div->ops = &clk_divider_ops;
fixup_div->fixup = fixup;
- clk = clk_register(NULL, &fixup_div->divider.hw);
- if (IS_ERR(clk))
+ hw = &fixup_div->divider.hw;
+
+ ret = clk_hw_register(NULL, hw);
+ if (ret) {
kfree(fixup_div);
+ return ERR_PTR(ret);
+ }
- return clk;
+ return hw;
}
diff --git a/drivers/clk/imx/clk.h b/drivers/clk/imx/clk.h
index 1c6300a..e199d73 100644
--- a/drivers/clk/imx/clk.h
+++ b/drivers/clk/imx/clk.h
@@ -73,6 +73,9 @@ struct imx_pll14xx_clk {
#define imx_clk_gate_exclusive(name, parent, reg, shift, exclusive_mask) \
imx_clk_hw_gate_exclusive(name, parent, reg, shift, exclusive_mask)->clk
+#define imx_clk_fixup_divider(name, parent, reg, shift, width, fixup) \
+ imx_clk_hw_fixup_divider(name, parent, reg, shift, width, fixup)->clk
+
struct clk *imx_clk_pll14xx(const char *name, const char *parent_name,
void __iomem *base, const struct imx_pll14xx_clk *pll_clk);
@@ -149,11 +152,11 @@ struct clk_hw *imx7ulp_clk_composite(const char *name,
bool rate_present, bool gate_present,
void __iomem *reg);
-struct clk *imx_clk_fixup_divider(const char *name, const char *parent,
+struct clk_hw *imx_clk_hw_fixup_divider(const char *name, const char *parent,
void __iomem *reg, u8 shift, u8 width,
void (*fixup)(u32 *val));
-struct clk *imx_clk_fixup_mux(const char *name, void __iomem *reg,
+struct clk_hw *imx_clk_hw_fixup_mux(const char *name, void __iomem *reg,
u8 shift, u8 width, const char * const *parents,
int num_parents, void (*fixup)(u32 *val));
--
2.7.4
next prev parent reply other threads:[~2019-05-29 12:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-29 12:26 [RESEND v2 00/18] clk: imx: Switch the imx6 and imx7 to clk_hw based API Abel Vesa
2019-05-29 12:26 ` [RESEND 01/18] clk: imx: Add imx_obtain_fixed_clock clk_hw based variant Abel Vesa
2019-05-29 12:26 ` [RESEND 02/18] clk: imx6sx: Do not reparent to unregistered IMX6SX_CLK_AXI Abel Vesa
2019-05-29 12:26 ` [RESEND 03/18] clk: imx6q: Do not reparent uninitialized IMX6QDL_CLK_PERIPH2 clock Abel Vesa
2019-05-29 12:26 ` [RESEND 04/18] clk: imx: clk-busy: Switch to clk_hw based API Abel Vesa
2019-05-29 12:26 ` [RESEND 05/18] clk: imx: clk-cpu: " Abel Vesa
2019-05-29 12:26 ` [RESEND 06/18] clk: imx: clk-gate2: " Abel Vesa
2019-05-29 12:26 ` [RESEND 09/18] clk: imx: clk-gate-exclusive: " Abel Vesa
2019-05-29 12:26 ` [RESEND 07/18] clk: imx: clk-pllv3: " Abel Vesa
2019-05-29 12:26 ` [RESEND 08/18] clk: imx: clk-pfd: " Abel Vesa
2019-05-29 12:26 ` Abel Vesa [this message]
2019-05-29 12:26 ` [RESEND 11/18] clk: imx: clk-fixup-mux: " Abel Vesa
2019-05-29 12:26 ` [RESEND 12/18] clk: imx: Switch wrappers " Abel Vesa
2019-05-29 12:26 ` [RESEND 13/18] clk: imx6q: Switch " Abel Vesa
2019-05-29 12:26 ` [RESEND 14/18] clk: imx6sl: " Abel Vesa
2019-05-29 12:26 ` [RESEND 16/18] clk: imx6ul: " Abel Vesa
2019-05-29 12:26 ` [RESEND 15/18] clk: imx6sx: " Abel Vesa
2019-05-29 12:26 ` [RESEND 17/18] clk: imx7d: " Abel Vesa
2019-05-29 12:26 ` [RESEND 18/18] clk: imx6sll: " Abel Vesa
2019-06-06 18:29 ` [RESEND v2 00/18] clk: imx: Switch the imx6 and imx7 " Stephen Boyd
2019-06-07 0:41 ` Shawn Guo
2019-06-07 8:01 ` Abel Vesa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1559132773-12884-11-git-send-email-abel.vesa@nxp.com \
--to=abel.vesa@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=ping.bai@nxp.com \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).