From: YueHaibing <yuehaibing@huawei.com>
To: Thierry Reding <thierry.reding@gmail.com>,
<u.kleine-koenig@pengutronix.de>,
<andriy.shevchenko@linux.intel.com>, <thesven73@gmail.com>
Cc: YueHaibing <yuehaibing@huawei.com>, <linux-pwm@vger.kernel.org>,
<kernel-janitors@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH -next] pwm: pca9685: Remove set but not used variable 'pwm'
Date: Sat, 1 Jun 2019 03:57:09 +0000 [thread overview]
Message-ID: <20190601035709.85379-1-yuehaibing@huawei.com> (raw)
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/pwm/pwm-pca9685.c: In function 'pca9685_pwm_gpio_free':
drivers/pwm/pwm-pca9685.c:173:21: warning:
variable 'pwm' set but not used [-Wunused-but-set-variable]
It's not used since commit e926b12c611c ("pwm: Clear chip_data in pwm_put()")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/pwm/pwm-pca9685.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/pwm/pwm-pca9685.c b/drivers/pwm/pwm-pca9685.c
index 567f5e2771c4..d16215c276bd 100644
--- a/drivers/pwm/pwm-pca9685.c
+++ b/drivers/pwm/pwm-pca9685.c
@@ -170,12 +170,10 @@ static void pca9685_pwm_gpio_set(struct gpio_chip *gpio, unsigned int offset,
static void pca9685_pwm_gpio_free(struct gpio_chip *gpio, unsigned int offset)
{
struct pca9685 *pca = gpiochip_get_data(gpio);
- struct pwm_device *pwm;
pca9685_pwm_gpio_set(gpio, offset, 0);
pm_runtime_put(pca->chip.dev);
mutex_lock(&pca->lock);
- pwm = &pca->chip.pwms[offset];
mutex_unlock(&pca->lock);
}
next reply other threads:[~2019-06-01 3:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-01 3:57 YueHaibing [this message]
2019-06-01 13:03 ` [PATCH -next] pwm: pca9685: Remove set but not used variable 'pwm' Sven Van Asbroeck
2019-06-01 16:04 ` Uwe Kleine-König
2019-06-02 14:18 ` Sven Van Asbroeck
2019-06-03 11:40 ` Mika Westerberg
2019-06-03 15:08 ` Sven Van Asbroeck
2019-06-03 15:58 ` Mika Westerberg
2019-06-04 16:01 ` Andy Shevchenko
2019-06-06 15:11 ` Sven Van Asbroeck
2020-05-23 20:17 ` Uwe Kleine-König
2020-05-24 0:24 ` Sven Van Asbroeck
2020-05-24 10:21 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190601035709.85379-1-yuehaibing@huawei.com \
--to=yuehaibing@huawei.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=thesven73@gmail.com \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).