linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Liangyan <liangyan.peng@linux.alibaba.com>
To: mingo@redhat.com, peterz@infradead.org, linux-kernel@vger.kernel.org
Cc: yun.wang@linux.alibaba.com, shanpeic@linux.alibaba.com,
	xlpang@linux.alibaba.com,
	"liangyan.ply" <liangyan.ply@linux.alibaba.com>,
	Liangyan <liangyan.peng@linux.alibaba.com>
Subject: [PATCH] sched/fair: don't restart enqueued cfs quota slack timer
Date: Mon,  3 Jun 2019 12:43:09 +0800	[thread overview]
Message-ID: <20190603044309.168065-1-liangyan.peng@linux.alibaba.com> (raw)

From: "liangyan.ply" <liangyan.ply@linux.alibaba.com>

start_cfs_slack_bandwidth() will restart the quota slack timer,
if it is called frequently, this timer will be restarted continuously
and may have no chance to expire to unthrottle cfs tasks.
This will cause that the throttled tasks can't be unthrottled in time
although they have remaining quota.

Signed-off-by: Liangyan <liangyan.peng@linux.alibaba.com>
---
 kernel/sched/fair.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index d90a64620072..fdb03c752f97 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -4411,9 +4411,11 @@ static void start_cfs_slack_bandwidth(struct cfs_bandwidth *cfs_b)
 	if (runtime_refresh_within(cfs_b, min_left))
 		return;
 
-	hrtimer_start(&cfs_b->slack_timer,
+	if (!hrtimer_active(&cfs_b->slack_timer)) {
+		hrtimer_start(&cfs_b->slack_timer,
 			ns_to_ktime(cfs_bandwidth_slack_period),
 			HRTIMER_MODE_REL);
+	}
 }
 
 /* we know any runtime found here is valid as update_curr() precedes return */
-- 
2.14.4.44.g2045bb6


             reply	other threads:[~2019-06-03  4:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-03  4:43 Liangyan [this message]
2019-06-03  9:49 ` [PATCH] sched/fair: don't restart enqueued cfs quota slack timer Peter Zijlstra
2019-06-03 20:23   ` bsegall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190603044309.168065-1-liangyan.peng@linux.alibaba.com \
    --to=liangyan.peng@linux.alibaba.com \
    --cc=liangyan.ply@linux.alibaba.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=shanpeic@linux.alibaba.com \
    --cc=xlpang@linux.alibaba.com \
    --cc=yun.wang@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).