[1/3] x86/CPU: Add more Icelake model number
diff mbox series

Message ID 20190603134122.13853-1-kan.liang@linux.intel.com
State New
Headers show
Series
  • [1/3] x86/CPU: Add more Icelake model number
Related show

Commit Message

Liang, Kan June 3, 2019, 1:41 p.m. UTC
From: Kan Liang <kan.liang@linux.intel.com>

Add the CPUID model number of Icelake (ICL) desktop and server
processors to the Intel family list.

Signed-off-by: Kan Liang <kan.liang@linux.intel.com>
Signed-off-by: Qiuxu Zhuo <qiuxu.zhuo@intel.com>
---
 arch/x86/include/asm/intel-family.h | 3 +++
 1 file changed, 3 insertions(+)

Comments

Borislav Petkov June 6, 2019, 6:35 a.m. UTC | #1
On Mon, Jun 03, 2019 at 06:41:20AM -0700, kan.liang@linux.intel.com wrote:
> From: Kan Liang <kan.liang@linux.intel.com>
> 
> Add the CPUID model number of Icelake (ICL) desktop and server
> processors to the Intel family list.
> 
> Signed-off-by: Kan Liang <kan.liang@linux.intel.com>
> Signed-off-by: Qiuxu Zhuo <qiuxu.zhuo@intel.com>

You're sending this patch but it has Qiuxu's SOB too. What's that
supposed to mean?
Zhuo, Qiuxu June 6, 2019, 7:13 a.m. UTC | #2
> From: Borislav Petkov [mailto:bp@alien8.de]
> ...
> > From: Kan Liang <kan.liang@linux.intel.com>
> >
> > Add the CPUID model number of Icelake (ICL) desktop and server
> > processors to the Intel family list.
> >
> > Signed-off-by: Kan Liang <kan.liang@linux.intel.com>
> > Signed-off-by: Qiuxu Zhuo <qiuxu.zhuo@intel.com>
> 
> You're sending this patch but it has Qiuxu's SOB too. What's that supposed to mean?

Hi Boris,

During internal co-work, based on Kan's original patch, I got the "#define" in the Ice Lake group sorted by model number(the header of the file requires the sorting) and added my SOB. Dropping my SOB or adding a text "[Qiuxu: Get the macros in the Ice Lake group sorted by model number.]" at the end of the commit message - which one is better/clear for you?

Thanks!
-Qiuxu
Borislav Petkov June 6, 2019, 7:33 a.m. UTC | #3
On Thu, Jun 06, 2019 at 07:13:18AM +0000, Zhuo, Qiuxu wrote:
> During internal co-work, based on Kan's original patch, I got the
> "#define" in the Ice Lake group sorted by model number(the header of
> the file requires the sorting) and added my SOB. Dropping my SOB or
> adding a text "[Qiuxu: Get the macros in the Ice Lake group sorted
> by model number.]" at the end of the commit message - which one is
> better/clear for you?

I'll add that note when applying.

Thx.
Zhuo, Qiuxu June 6, 2019, 8:44 a.m. UTC | #4
> From: Borislav Petkov [mailto:bp@alien8.de]
>> ...
>> Dropping my SOB or adding a text "[Qiuxu: Get the macros in the Ice Lake group sorted by
> > model number.]" at the end of the commit message - which one is better/clear for you?
> 
> I'll add that note when applying.
> 
> Thx.

Thanks Boris!
-Qiuxu

Patch
diff mbox series

diff --git a/arch/x86/include/asm/intel-family.h b/arch/x86/include/asm/intel-family.h
index 9f15384c504a..310118805f57 100644
--- a/arch/x86/include/asm/intel-family.h
+++ b/arch/x86/include/asm/intel-family.h
@@ -52,6 +52,9 @@ 
 
 #define INTEL_FAM6_CANNONLAKE_MOBILE	0x66
 
+#define INTEL_FAM6_ICELAKE_X		0x6A
+#define INTEL_FAM6_ICELAKE_XEON_D	0x6C
+#define INTEL_FAM6_ICELAKE_DESKTOP	0x7D
 #define INTEL_FAM6_ICELAKE_MOBILE	0x7E
 
 /* "Small Core" Processors (Atom) */