From: Saravana Kannan <saravanak@google.com>
To: Georgi Djakov <georgi.djakov@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Viresh Kumar <vireshk@kernel.org>, Nishanth Menon <nm@ti.com>,
Stephen Boyd <sboyd@kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
0001-crypto-qcom-rng-Add-interconnect-dev.patch@google.com
Cc: Saravana Kannan <saravanak@google.com>,
Rajendra Nayak <rnayak@codeaurora.org>,
Jordan Crouse <jcrouse@codeaurora.org>,
vincent.guittot@linaro.org, bjorn.andersson@linaro.org,
amit.kucheria@linaro.org, seansw@qti.qualcomm.com,
daidavid1@codeaurora.org, evgreen@chromium.org,
sibis@codeaurora.org, kernel-team@android.com,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [Example code] crypto: qcom-rng: Add interconnect devfreq support
Date: Mon, 10 Jun 2019 16:12:39 -0700 [thread overview]
Message-ID: <20190610231239.103913-1-saravanak@google.com> (raw)
In-Reply-To: <20190608054711.GZ22737@tuxbook-pro>
This is just an example code and I'm not actually trying to get this
merged.
Bjorn,
This is what the code would look like. It compiles, but I can't test it.
I'm not sending this as part of the patch series as I'm not sure what
the interconnects property should be set to in DT for qcom-rng device
nor is QCOM RNG an ideal candidate for bandwidth scaling using devfreq.
It can probably just set the bandwidth to some fixed low value like 1
KB/s. But this is pretty much all the code one would need if they wanted
to enable interconnect scaling for their interconnect path using
devfreq.
-Saravana
Signed-off-by: Saravana Kannan <saravanak@google.com>
---
drivers/crypto/qcom-rng.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/crypto/qcom-rng.c b/drivers/crypto/qcom-rng.c
index e54249ccc009..7a92238061ca 100644
--- a/drivers/crypto/qcom-rng.c
+++ b/drivers/crypto/qcom-rng.c
@@ -9,6 +9,7 @@
#include <linux/crypto.h>
#include <linux/module.h>
#include <linux/of.h>
+#include <linux/interconnect.h>
#include <linux/platform_device.h>
/* Device specific register offsets */
@@ -37,6 +38,7 @@ struct qcom_rng_ctx {
};
static struct qcom_rng *qcom_rng_dev;
+static struct icc_devfreq *icc_df;
static int qcom_rng_read(struct qcom_rng *rng, u8 *data, unsigned int max)
{
@@ -186,6 +188,13 @@ static int qcom_rng_probe(struct platform_device *pdev)
qcom_rng_dev = NULL;
}
+ ret = dev_pm_opp_of_add_table_indexed(&pdev->dev, 0);
+ if (ret)
+ return ret;
+ icc_df = icc_create_devfreq(&pdev->dev, "prng-slv");
+ if (IS_ERR(icc_df))
+ return PTR_ERR(icc_df);
+
return ret;
}
--
2.22.0.rc2.383.gf4fbbf30c2-goog
prev parent reply other threads:[~2019-06-10 23:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-08 4:43 [PATCH v1 0/9] Introduce Bandwidth OPPs & interconnect devfreq driver Saravana Kannan
2019-06-08 4:43 ` [PATCH v1 1/9] dt-bindings: opp: Introduce opp-peak-KBps and opp-avg-KBps bindings Saravana Kannan
2019-06-08 4:43 ` [PATCH v1 2/9] OPP: Add support for bandwidth OPP tables Saravana Kannan
2019-06-08 4:43 ` [PATCH v1 3/9] OPP: Add helper function " Saravana Kannan
2019-06-08 4:43 ` [PATCH v1 4/9] OPP: Add API to find an OPP table from its DT node Saravana Kannan
2019-06-08 4:43 ` [PATCH v1 5/9] dt-bindings: interconnect: Add interconnect-opp-table property Saravana Kannan
2019-06-08 4:43 ` [PATCH v1 6/9] interconnect: Add OPP table support for interconnects Saravana Kannan
2019-06-08 4:43 ` [PATCH v1 7/9] OPP: Add function to look up required OPP's for a given OPP Saravana Kannan
2019-06-08 4:43 ` [PATCH v1 8/9] OPP: Allow copying OPPs tables between devices Saravana Kannan
2019-06-08 4:43 ` [PATCH v1 9/9] interconnect: Add devfreq support Saravana Kannan
2019-06-08 5:47 ` [PATCH v1 0/9] Introduce Bandwidth OPPs & interconnect devfreq driver Bjorn Andersson
2019-06-08 20:34 ` Saravana Kannan
2019-06-10 23:12 ` Saravana Kannan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190610231239.103913-1-saravanak@google.com \
--to=saravanak@google.com \
--cc=0001-crypto-qcom-rng-Add-interconnect-dev.patch@google.com \
--cc=amit.kucheria@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=daidavid1@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=evgreen@chromium.org \
--cc=georgi.djakov@linaro.org \
--cc=jcrouse@codeaurora.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nm@ti.com \
--cc=rjw@rjwysocki.net \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=seansw@qti.qualcomm.com \
--cc=sibis@codeaurora.org \
--cc=vincent.guittot@linaro.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).