From: Julien Thierry <julien.thierry@arm.com>
To: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, rostedt@goodmis.org,
marc.zyngier@arm.com, yuzenghui@huawei.com,
wanghaibin.wang@huawei.com, james.morse@arm.com,
will.deacon@arm.com, catalin.marinas@arm.com,
mark.rutland@arm.com, liwei391@huawei.com,
Julien Thierry <julien.thierry@arm.com>
Subject: [PATCH v4 1/8] arm64: Do not enable IRQs for ct_user_exit
Date: Tue, 11 Jun 2019 10:38:06 +0100 [thread overview]
Message-ID: <1560245893-46998-2-git-send-email-julien.thierry@arm.com> (raw)
In-Reply-To: <1560245893-46998-1-git-send-email-julien.thierry@arm.com>
For el0_dbg and el0_error, DAIF bits get explicitly cleared before
calling ct_user_exit.
When context tracking is disabled, DAIF gets set (almost) immediately
after. When context tracking is enabled, among the first things done
is disabling IRQs.
What is actually needed is:
- PSR.D = 0 so the system can be debugged (should be already the case)
- PSR.A = 0 so async error can be handled during context tracking
Do not clear PSR.I in those two locations.
Signed-off-by: Julien Thierry <julien.thierry@arm.com>
Reviewed-by: James Morse <james.morse@arm.com>
Cc:Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will.deacon@arm.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Marc Zyngier <marc.zyngier@arm.com>
---
arch/arm64/kernel/entry.S | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/kernel/entry.S b/arch/arm64/kernel/entry.S
index cd0c7af..89ab6bd 100644
--- a/arch/arm64/kernel/entry.S
+++ b/arch/arm64/kernel/entry.S
@@ -870,7 +870,7 @@ el0_dbg:
mov x1, x25
mov x2, sp
bl do_debug_exception
- enable_daif
+ enable_da_f
ct_user_exit
b ret_to_user
el0_inv:
@@ -922,7 +922,7 @@ el0_error_naked:
enable_dbg
mov x0, sp
bl do_serror
- enable_daif
+ enable_da_f
ct_user_exit
b ret_to_user
ENDPROC(el0_error)
--
1.9.1
next prev parent reply other threads:[~2019-06-11 9:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 9:38 [PATCH v4 0/8] arm64: IRQ priority masking and Pseudo-NMI fixes Julien Thierry
2019-06-11 9:38 ` Julien Thierry [this message]
2019-06-11 12:45 ` [PATCH v4 1/8] arm64: Do not enable IRQs for ct_user_exit Mark Rutland
2019-06-11 9:38 ` [PATCH v4 2/8] arm64: irqflags: Pass flags as readonly operand to restore instruction Julien Thierry
2019-06-11 12:46 ` Mark Rutland
2019-06-11 9:38 ` [PATCH v4 3/8] arm64: irqflags: Add condition flags to inline asm clobber list Julien Thierry
2019-06-11 12:52 ` Mark Rutland
2019-06-11 9:38 ` [PATCH v4 4/8] arm64: Fix interrupt tracing in the presence of NMIs Julien Thierry
2019-06-11 9:38 ` [PATCH v4 5/8] arm64: Fix incorrect irqflag restore for priority masking Julien Thierry
2019-06-11 9:38 ` [PATCH v4 6/8] arm64: irqflags: Introduce explicit debugging for IRQ priorities Julien Thierry
2019-06-11 9:38 ` [PATCH v4 7/8] arm64: fix kernel stack overflow in kdump capture kernel Julien Thierry
2019-06-11 9:38 ` [PATCH v4 8/8] arm64: Allow selecting Pseudo-NMI again Julien Thierry
2019-06-11 13:28 ` [PATCH v4 0/8] arm64: IRQ priority masking and Pseudo-NMI fixes Marc Zyngier
2019-06-21 10:27 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1560245893-46998-2-git-send-email-julien.thierry@arm.com \
--to=julien.thierry@arm.com \
--cc=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liwei391@huawei.com \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=rostedt@goodmis.org \
--cc=wanghaibin.wang@huawei.com \
--cc=will.deacon@arm.com \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).