From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
To: stefan.wahren@i2se.com, Eric Anholt <eric@anholt.net>,
Florian Fainelli <f.fainelli@gmail.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com
Cc: mbrugger@suse.de, viresh.kumar@linaro.org, rjw@rjwysocki.net,
sboyd@kernel.org, ptesarik@suse.com,
linux-rpi-kernel@lists.infradead.org, ssuloev@orpaltech.com,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
mturquette@baylibre.com, linux-pm@vger.kernel.org,
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
linux-kernel@vger.kernel.org
Subject: [PATCH v3 1/7] clk: bcm2835: remove pllb
Date: Tue, 11 Jun 2019 19:58:34 +0200 [thread overview]
Message-ID: <20190611175839.28351-2-nsaenzjulienne@suse.de> (raw)
In-Reply-To: <20190611175839.28351-1-nsaenzjulienne@suse.de>
Raspberry Pi's firmware controls this pll, we should use the firmware
interface to access it.
Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Acked-by: Eric Anholt <eric@anholt.net>
---
Changes since v1:
- Add comment to explain why pllb isn't there anymore
drivers/clk/bcm/clk-bcm2835.c | 28 ++++------------------------
1 file changed, 4 insertions(+), 24 deletions(-)
diff --git a/drivers/clk/bcm/clk-bcm2835.c b/drivers/clk/bcm/clk-bcm2835.c
index 770bb01f523e..867ae3c20041 100644
--- a/drivers/clk/bcm/clk-bcm2835.c
+++ b/drivers/clk/bcm/clk-bcm2835.c
@@ -1651,30 +1651,10 @@ static const struct bcm2835_clk_desc clk_desc_array[] = {
.fixed_divider = 1,
.flags = CLK_SET_RATE_PARENT),
- /* PLLB is used for the ARM's clock. */
- [BCM2835_PLLB] = REGISTER_PLL(
- .name = "pllb",
- .cm_ctrl_reg = CM_PLLB,
- .a2w_ctrl_reg = A2W_PLLB_CTRL,
- .frac_reg = A2W_PLLB_FRAC,
- .ana_reg_base = A2W_PLLB_ANA0,
- .reference_enable_mask = A2W_XOSC_CTRL_PLLB_ENABLE,
- .lock_mask = CM_LOCK_FLOCKB,
-
- .ana = &bcm2835_ana_default,
-
- .min_rate = 600000000u,
- .max_rate = 3000000000u,
- .max_fb_rate = BCM2835_MAX_FB_RATE),
- [BCM2835_PLLB_ARM] = REGISTER_PLL_DIV(
- .name = "pllb_arm",
- .source_pll = "pllb",
- .cm_reg = CM_PLLB,
- .a2w_reg = A2W_PLLB_ARM,
- .load_mask = CM_PLLB_LOADARM,
- .hold_mask = CM_PLLB_HOLDARM,
- .fixed_divider = 1,
- .flags = CLK_SET_RATE_PARENT),
+ /*
+ * PLLB is used for the ARM's clock. Controlled by firmware, see
+ * clk-raspberrypi.c.
+ */
/*
* PLLC is the core PLL, used to drive the core VPU clock.
--
2.21.0
next prev parent reply other threads:[~2019-06-11 17:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 17:58 [PATCH v3 0/7] cpufreq support for Raspberry Pi Nicolas Saenz Julienne
2019-06-11 17:58 ` Nicolas Saenz Julienne [this message]
2019-06-25 23:00 ` [PATCH v3 1/7] clk: bcm2835: remove pllb Stephen Boyd
2019-06-11 17:58 ` [PATCH v3 2/7] clk: bcm283x: add driver interfacing with Raspberry Pi's firmware Nicolas Saenz Julienne
2019-06-25 23:00 ` Stephen Boyd
2019-06-11 17:58 ` [PATCH v3 3/7] firmware: raspberrypi: register clk device Nicolas Saenz Julienne
2019-06-25 23:00 ` Stephen Boyd
2019-06-11 17:58 ` [PATCH v3 4/7] cpufreq: add driver for Raspbery Pi Nicolas Saenz Julienne
2019-06-12 10:08 ` Nicolas Saenz Julienne
2019-06-11 17:58 ` [PATCH v3 5/7] clk: raspberrypi: register platform device for raspberrypi-cpufreq Nicolas Saenz Julienne
2019-06-25 23:01 ` Stephen Boyd
2019-06-11 17:58 ` [PATCH v3 6/7] ARM: defconfig: enable cpufreq driver for RPi Nicolas Saenz Julienne
2019-06-11 17:58 ` [PATCH v3 7/7] arm64: defconfig: enable cpufreq support for RPi3 Nicolas Saenz Julienne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190611175839.28351-2-nsaenzjulienne@suse.de \
--to=nsaenzjulienne@suse.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mbrugger@suse.de \
--cc=mturquette@baylibre.com \
--cc=ptesarik@suse.com \
--cc=rjui@broadcom.com \
--cc=rjw@rjwysocki.net \
--cc=sboyd@kernel.org \
--cc=sbranden@broadcom.com \
--cc=ssuloev@orpaltech.com \
--cc=stefan.wahren@i2se.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).