From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
To: stefan.wahren@i2se.com, linux-kernel@vger.kernel.org
Cc: mbrugger@suse.de, viresh.kumar@linaro.org, rjw@rjwysocki.net,
sboyd@kernel.org, eric@anholt.net, f.fainelli@gmail.com,
bcm-kernel-feedback-list@broadcom.com, ptesarik@suse.com,
linux-rpi-kernel@lists.infradead.org, ssuloev@orpaltech.com,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
mturquette@baylibre.com, linux-pm@vger.kernel.org,
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Subject: [PATCH v3 3/7] firmware: raspberrypi: register clk device
Date: Tue, 11 Jun 2019 19:58:38 +0200 [thread overview]
Message-ID: <20190611175839.28351-4-nsaenzjulienne@suse.de> (raw)
In-Reply-To: <20190611175839.28351-1-nsaenzjulienne@suse.de>
Since clk-raspberrypi is tied to the VC4 firmware instead of particular
hardware it's registration should be performed by the firmware driver.
Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Acked-by: Eric Anholt <eric@anholt.net>
---
drivers/firmware/raspberrypi.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/firmware/raspberrypi.c b/drivers/firmware/raspberrypi.c
index 61be15d9df7d..da26a584dca0 100644
--- a/drivers/firmware/raspberrypi.c
+++ b/drivers/firmware/raspberrypi.c
@@ -20,6 +20,7 @@
#define MBOX_CHAN_PROPERTY 8
static struct platform_device *rpi_hwmon;
+static struct platform_device *rpi_clk;
struct rpi_firmware {
struct mbox_client cl;
@@ -207,6 +208,12 @@ rpi_register_hwmon_driver(struct device *dev, struct rpi_firmware *fw)
-1, NULL, 0);
}
+static void rpi_register_clk_driver(struct device *dev)
+{
+ rpi_clk = platform_device_register_data(dev, "raspberrypi-clk",
+ -1, NULL, 0);
+}
+
static int rpi_firmware_probe(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
@@ -234,6 +241,7 @@ static int rpi_firmware_probe(struct platform_device *pdev)
rpi_firmware_print_firmware_revision(fw);
rpi_register_hwmon_driver(dev, fw);
+ rpi_register_clk_driver(dev);
return 0;
}
@@ -254,6 +262,8 @@ static int rpi_firmware_remove(struct platform_device *pdev)
platform_device_unregister(rpi_hwmon);
rpi_hwmon = NULL;
+ platform_device_unregister(rpi_clk);
+ rpi_clk = NULL;
mbox_free_channel(fw->chan);
return 0;
--
2.21.0
next prev parent reply other threads:[~2019-06-11 18:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 17:58 [PATCH v3 0/7] cpufreq support for Raspberry Pi Nicolas Saenz Julienne
2019-06-11 17:58 ` [PATCH v3 1/7] clk: bcm2835: remove pllb Nicolas Saenz Julienne
2019-06-25 23:00 ` Stephen Boyd
2019-06-11 17:58 ` [PATCH v3 2/7] clk: bcm283x: add driver interfacing with Raspberry Pi's firmware Nicolas Saenz Julienne
2019-06-25 23:00 ` Stephen Boyd
2019-06-11 17:58 ` Nicolas Saenz Julienne [this message]
2019-06-25 23:00 ` [PATCH v3 3/7] firmware: raspberrypi: register clk device Stephen Boyd
2019-06-11 17:58 ` [PATCH v3 4/7] cpufreq: add driver for Raspbery Pi Nicolas Saenz Julienne
2019-06-12 10:08 ` Nicolas Saenz Julienne
2019-06-11 17:58 ` [PATCH v3 5/7] clk: raspberrypi: register platform device for raspberrypi-cpufreq Nicolas Saenz Julienne
2019-06-25 23:01 ` Stephen Boyd
2019-06-11 17:58 ` [PATCH v3 6/7] ARM: defconfig: enable cpufreq driver for RPi Nicolas Saenz Julienne
2019-06-11 17:58 ` [PATCH v3 7/7] arm64: defconfig: enable cpufreq support for RPi3 Nicolas Saenz Julienne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190611175839.28351-4-nsaenzjulienne@suse.de \
--to=nsaenzjulienne@suse.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mbrugger@suse.de \
--cc=mturquette@baylibre.com \
--cc=ptesarik@suse.com \
--cc=rjw@rjwysocki.net \
--cc=sboyd@kernel.org \
--cc=ssuloev@orpaltech.com \
--cc=stefan.wahren@i2se.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).