From: Hariprasad Kelam <hariprasad.kelam@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Hariprasad Kelam <hariprasad.kelam@gmail.com>,
Kimberly Brown <kimbrownkd@gmail.com>,
Shobhit Kukreti <shobhitkukreti@gmail.com>,
Bastien Nocera <hadess@hadess.net>,
Anirudh Rayabharam <anirudh.rayabharam@gmail.com>,
Nishka Dasgupta <nishka.dasgupta@yahoo.com>,
Hardik Singh Rathore <hardiksingh.k@gmail.com>,
Mamta Shukla <mamtashukla555@gmail.com>,
Puranjay Mohan <puranjay12@gmail.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [PATCH] staging/rtl8723bs/core/rtw_ap: Remove redundant call to memset
Date: Sun, 16 Jun 2019 09:05:27 +0530 [thread overview]
Message-ID: <20190616033527.GA14062@hari-Inspiron-1545> (raw)
rtw_zmalloc is internally doing memset . So there is no need to call memset
again.
Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_ap.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c b/drivers/staging/rtl8723bs/core/rtw_ap.c
index 87b201a..df055b8 100644
--- a/drivers/staging/rtl8723bs/core/rtw_ap.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ap.c
@@ -1502,8 +1502,6 @@ static int rtw_ap_set_key(
goto exit;
}
- memset(psetkeyparm, 0, sizeof(struct setkey_parm));
-
psetkeyparm->keyid = (u8)keyid;
if (is_wep_enc(alg))
padapter->securitypriv.key_mask |= BIT(psetkeyparm->keyid);
--
2.7.4
reply other threads:[~2019-06-16 3:35 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190616033527.GA14062@hari-Inspiron-1545 \
--to=hariprasad.kelam@gmail.com \
--cc=anirudh.rayabharam@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hadess@hadess.net \
--cc=hardiksingh.k@gmail.com \
--cc=kimbrownkd@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mamtashukla555@gmail.com \
--cc=nishka.dasgupta@yahoo.com \
--cc=puranjay12@gmail.com \
--cc=shobhitkukreti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).